[INFO] cloning repository https://github.com/dlom/runescape [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dlom/runescape" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdlom%2Frunescape", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdlom%2Frunescape'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c5ed16bc746fe1c68c6bcc87674531d39083e1cb [INFO] checking dlom/runescape/c5ed16bc746fe1c68c6bcc87674531d39083e1cb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdlom%2Frunescape" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dlom/runescape on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dlom/runescape [INFO] finished tweaking git repo https://github.com/dlom/runescape [INFO] tweaked toml for git repo https://github.com/dlom/runescape written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dlom/runescape already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9f3c565ff50e072939bb341a60863b964a9f6cca4393cc08c6d555b9cc34ac4 [INFO] running `Command { std: "docker" "start" "-a" "b9f3c565ff50e072939bb341a60863b964a9f6cca4393cc08c6d555b9cc34ac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9f3c565ff50e072939bb341a60863b964a9f6cca4393cc08c6d555b9cc34ac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9f3c565ff50e072939bb341a60863b964a9f6cca4393cc08c6d555b9cc34ac4", kill_on_drop: false }` [INFO] [stdout] b9f3c565ff50e072939bb341a60863b964a9f6cca4393cc08c6d555b9cc34ac4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20cb9aebfb3e369ca6e9dafcaca79e1b1386cd38e47f4c92714d1f59ff1ecee3 [INFO] running `Command { std: "docker" "start" "-a" "20cb9aebfb3e369ca6e9dafcaca79e1b1386cd38e47f4c92714d1f59ff1ecee3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.61 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling cc v1.0.40 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking spin v0.5.1 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling serde v1.0.98 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking chunked_transfer v1.0.0 [INFO] [stderr] Checking ascii v0.9.2 [INFO] [stderr] Checking qstring v0.6.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking fixedbitset v0.1.9 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking pathfinding v1.1.12 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.98 [INFO] [stderr] Checking webpki v0.19.1 [INFO] [stderr] Checking sct v0.5.0 [INFO] [stderr] Checking webpki-roots v0.16.0 [INFO] [stderr] Checking rustls v0.15.2 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking ureq v0.11.0 [INFO] [stderr] Checking runescape v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 87 | #[derive(Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:98:10 [INFO] [stdout] | [INFO] [stdout] 98 | #[derive(Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/mod.rs:116:2 [INFO] [stdout] | [INFO] [stdout] 115 | fn normalize_gear, P: FnMut(&(RunescapeInt, Item)) -> bool>(iter: T, predicate: P) -> BTreeMap... [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / iter.into_iter() [INFO] [stdout] 117 | | .filter(predicate) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/mod.rs:156:2 [INFO] [stdout] | [INFO] [stdout] 154 | fn filter_by_breakpoint<'a, T: IntoIterator>(iter: T, breakpoint: Breakpoint) -> Vec<&'a Item> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let stats = breakpoint.into(); [INFO] [stdout] 156 | / iter.into_iter() [INFO] [stdout] 157 | | .filter(|item| { [INFO] [stdout] 158 | | match &item.equipment.requirements { [INFO] [stdout] 159 | | Some(requirements) => { [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/item_group.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn group_similar_items<'a, T: IntoIterator>(iter: T) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / iter.into_iter() [INFO] [stdout] 37 | | .flat_map(decompose_item) [INFO] [stdout] 38 | | .filter(|item| { [INFO] [stdout] 39 | | item.attack_value >= 0 && item.strength_value >= 0 [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/runescape/gear/item_group.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | std::mem::replace(best, item.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 193 | let _ = std::mem::replace(best, item.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:87:10 [INFO] [stdout] | [INFO] [stdout] 87 | #[derive(Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/osrsbox_db/types.rs:98:10 [INFO] [stdout] | [INFO] [stdout] 98 | #[derive(Deserialize, Debug, PartialEq, Eq, Copy, Clone, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/mod.rs:116:2 [INFO] [stdout] | [INFO] [stdout] 115 | fn normalize_gear, P: FnMut(&(RunescapeInt, Item)) -> bool>(iter: T, predicate: P) -> BTreeMap... [INFO] [stdout] | ------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | / iter.into_iter() [INFO] [stdout] 117 | | .filter(predicate) [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/mod.rs:156:2 [INFO] [stdout] | [INFO] [stdout] 154 | fn filter_by_breakpoint<'a, T: IntoIterator>(iter: T, breakpoint: Breakpoint) -> Vec<&'a Item> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let stats = breakpoint.into(); [INFO] [stdout] 156 | / iter.into_iter() [INFO] [stdout] 157 | | .filter(|item| { [INFO] [stdout] 158 | | match &item.equipment.requirements { [INFO] [stdout] 159 | | Some(requirements) => { [INFO] [stdout] ... | [INFO] [stdout] 169 | | }) [INFO] [stdout] 170 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runescape/gear/item_group.rs:36:2 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn group_similar_items<'a, T: IntoIterator>(iter: T) -> Vec { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | / iter.into_iter() [INFO] [stdout] 37 | | .flat_map(decompose_item) [INFO] [stdout] 38 | | .filter(|item| { [INFO] [stdout] 39 | | item.attack_value >= 0 && item.strength_value >= 0 [INFO] [stdout] ... | [INFO] [stdout] 48 | | } [INFO] [stdout] 49 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `runescape` (bin "runescape") due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/runescape/gear/item_group.rs:193:6 [INFO] [stdout] | [INFO] [stdout] 193 | std::mem::replace(best, item.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 193 | let _ = std::mem::replace(best, item.clone()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `runescape` (bin "runescape" test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "20cb9aebfb3e369ca6e9dafcaca79e1b1386cd38e47f4c92714d1f59ff1ecee3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20cb9aebfb3e369ca6e9dafcaca79e1b1386cd38e47f4c92714d1f59ff1ecee3", kill_on_drop: false }` [INFO] [stdout] 20cb9aebfb3e369ca6e9dafcaca79e1b1386cd38e47f4c92714d1f59ff1ecee3