[INFO] cloning repository https://github.com/dj8yfo/hzrd_ptr_old [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dj8yfo/hzrd_ptr_old" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdj8yfo%2Fhzrd_ptr_old", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdj8yfo%2Fhzrd_ptr_old'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a42392a1621e1eb2b4097c8419445aa56ef20e17 [INFO] checking dj8yfo/hzrd_ptr_old/a42392a1621e1eb2b4097c8419445aa56ef20e17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdj8yfo%2Fhzrd_ptr_old" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dj8yfo/hzrd_ptr_old on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dj8yfo/hzrd_ptr_old [INFO] finished tweaking git repo https://github.com/dj8yfo/hzrd_ptr_old [INFO] tweaked toml for git repo https://github.com/dj8yfo/hzrd_ptr_old written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dj8yfo/hzrd_ptr_old already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ac8d6df32fcc6f23672a3be8a0ea9f05ab2a3bb2b8ee03f8e60d8018f627abf6 [INFO] running `Command { std: "docker" "start" "-a" "ac8d6df32fcc6f23672a3be8a0ea9f05ab2a3bb2b8ee03f8e60d8018f627abf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ac8d6df32fcc6f23672a3be8a0ea9f05ab2a3bb2b8ee03f8e60d8018f627abf6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac8d6df32fcc6f23672a3be8a0ea9f05ab2a3bb2b8ee03f8e60d8018f627abf6", kill_on_drop: false }` [INFO] [stdout] ac8d6df32fcc6f23672a3be8a0ea9f05ab2a3bb2b8ee03f8e60d8018f627abf6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cf5af5741de09313ff3cd1d1542bcbf629c584091f2c5ef95b4420b624d34a2 [INFO] running `Command { std: "docker" "start" "-a" "5cf5af5741de09313ff3cd1d1542bcbf629c584091f2c5ef95b4420b624d34a2", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking owning_ref v0.3.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Checking conc v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::sync::atomic` [INFO] [stdout] --> src/guard.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::atomic; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/local.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{mem, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/global.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | /// The global state. [INFO] [stdout] 11 | | /// [INFO] [stdout] 12 | | /// This state is shared between all the threads. [INFO] [stdout] 13 | | static ref STATE: State = State::new(); [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::atomic` [INFO] [stdout] --> src/guard.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::atomic; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `thread` [INFO] [stdout] --> src/local.rs:3:16 [INFO] [stdout] | [INFO] [stdout] 3 | use std::{mem, thread}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/global.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / lazy_static! { [INFO] [stdout] 10 | | /// The global state. [INFO] [stdout] 11 | | /// [INFO] [stdout] 12 | | /// This state is shared between all the threads. [INFO] [stdout] 13 | | static ref STATE: State = State::new(); [INFO] [stdout] 14 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/atomic.rs:183:23 [INFO] [stdout] | [INFO] [stdout] 183 | if self.inner.compare_and_swap(old as *mut T, new, ordering) as *const T == old { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/atomic.rs:257:24 [INFO] [stdout] | [INFO] [stdout] 257 | self.inner.compare_and_swap(old as *mut T, new, ordering).as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/sync/treiber.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | self.head.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/sync/treiber.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 100 | self.head.compare_and_swap(next, node, atomic::Ordering::Release).as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/local.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sync/treiber.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let mut node = Box::into_raw(Box::new(Node { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/atomic.rs:183:23 [INFO] [stdout] | [INFO] [stdout] 183 | if self.inner.compare_and_swap(old as *mut T, new, ordering) as *const T == old { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/atomic.rs:257:24 [INFO] [stdout] | [INFO] [stdout] 257 | self.inner.compare_and_swap(old as *mut T, new, ordering).as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn swap(&self, new: Option>, ordering: atomic::Ordering) -> Option> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | / Guard::maybe_new(|| unsafe { [INFO] [stdout] 150 | | // Swap the atomic pointer with the new one. [INFO] [stdout] 151 | | self.inner.swap(new_ptr, ordering).as_ref() [INFO] [stdout] 152 | | }).map(|guard| { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:296:15 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn compare_and_swap(&self, old: Option<*const T>, new: Option>, ordering: atomic::Ordering) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | match unsafe { [INFO] [stdout] | _______________^ [INFO] [stdout] 297 | | self.compare_and_swap_raw( [INFO] [stdout] 298 | | // Convert the input to raw pointers. [INFO] [stdout] 299 | | old.unwrap_or(ptr::null()), [INFO] [stdout] ... | [INFO] [stdout] 302 | | ) [INFO] [stdout] 303 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/garbage.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | Box::from_raw(ptr as *mut u8 as *mut T); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = Box::from_raw(ptr as *mut u8 as *mut T); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 82 | let (send, recv) = mpsc::channel(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | garbo: Mutex::new(Garbo { [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | chan: recv, [INFO] [stdout] 89 | | garbage: Vec::new(), [INFO] [stdout] 90 | | hazards: Vec::new(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(ptr: F) -> Guard [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | where F: FnOnce() -> &'static T { [INFO] [stdout] 113 | Guard::try_new::<_, ()>(|| Ok(ptr())).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn maybe_new(ptr: F) -> Option> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | where F: FnOnce() -> Option<&'static T> { [INFO] [stdout] 121 | Guard::try_new(|| ptr().ok_or(())).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn try_map(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | where F: FnOnce(&T) -> Result<&U, E> { [INFO] [stdout] 143 | Ok(Guard { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | hazard: self.hazard, [INFO] [stdout] 145 | | pointer: f(self.pointer)?, [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn maybe_map(self, f: F) -> Option> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | where F: FnOnce(&T) -> Option<&U> { [INFO] [stdout] 154 | let hazard = self.hazard; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | f(self.pointer).map(|res| Guard { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | hazard: hazard, [INFO] [stdout] 157 | | pointer: res, [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/hazard.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | Box::from_raw(self.ptr as *const AtomicPtr as *mut AtomicPtr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 139 | let _ = Box::from_raw(self.ptr as *const AtomicPtr as *mut AtomicPtr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:25:49 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn add_garbage(garbage: Garbage) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | } else if let Ok(true) = STATE.try_with(|s| s.borrow_mut().add_garbage(garbage)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 43 | match STATE.try_with(|s| s.borrow_mut().get_hazard()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn free_hazard(hazard: hazard::Writer) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | STATE.with(|s| s.borrow_mut().free_hazard(hazard)) ; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:91:27 [INFO] [stdout] | [INFO] [stdout] 91 | if STATE.try_with(|s| s.borrow_mut().export_garbage()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 20 | let end = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | (Sender { [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | inner: end.clone(), [INFO] [stdout] 24 | | }, Receiver { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 20 | let end = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | }, Receiver { [INFO] [stdout] | ________^ [INFO] [stdout] 25 | | inner: end, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/stm.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(data: Option>) -> Stm { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Stm { [INFO] [stdout] 16 | inner: Atomic::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conc` (lib) due to 15 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/sync/treiber.rs:45:27 [INFO] [stdout] | [INFO] [stdout] 45 | self.head.compare_and_swap( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicPtr::::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/sync/treiber.rs:100:27 [INFO] [stdout] | [INFO] [stdout] 100 | self.head.compare_and_swap(next, node, atomic::Ordering::Release).as_ref() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/local.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/sync/treiber.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let mut node = Box::into_raw(Box::new(Node { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn swap(&self, new: Option>, ordering: atomic::Ordering) -> Option> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | / Guard::maybe_new(|| unsafe { [INFO] [stdout] 150 | | // Swap the atomic pointer with the new one. [INFO] [stdout] 151 | | self.inner.swap(new_ptr, ordering).as_ref() [INFO] [stdout] 152 | | }).map(|guard| { [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/atomic.rs:296:15 [INFO] [stdout] | [INFO] [stdout] 293 | pub fn compare_and_swap(&self, old: Option<*const T>, new: Option>, ordering: atomic::Ordering) [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | match unsafe { [INFO] [stdout] | _______________^ [INFO] [stdout] 297 | | self.compare_and_swap_raw( [INFO] [stdout] 298 | | // Convert the input to raw pointers. [INFO] [stdout] 299 | | old.unwrap_or(ptr::null()), [INFO] [stdout] ... | [INFO] [stdout] 302 | | ) [INFO] [stdout] 303 | | } { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/garbage.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | Box::from_raw(ptr as *mut u8 as *mut T); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = Box::from_raw(ptr as *mut u8 as *mut T); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/global.rs:87:20 [INFO] [stdout] | [INFO] [stdout] 82 | let (send, recv) = mpsc::channel(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | garbo: Mutex::new(Garbo { [INFO] [stdout] | ____________________^ [INFO] [stdout] 88 | | chan: recv, [INFO] [stdout] 89 | | garbage: Vec::new(), [INFO] [stdout] 90 | | hazards: Vec::new(), [INFO] [stdout] 91 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(ptr: F) -> Guard [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | where F: FnOnce() -> &'static T { [INFO] [stdout] 113 | Guard::try_new::<_, ()>(|| Ok(ptr())).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn maybe_new(ptr: F) -> Option> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | where F: FnOnce() -> Option<&'static T> { [INFO] [stdout] 121 | Guard::try_new(|| ptr().ok_or(())).ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn try_map(self, f: F) -> Result, E> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | where F: FnOnce(&T) -> Result<&U, E> { [INFO] [stdout] 143 | Ok(Guard { [INFO] [stdout] | ____________^ [INFO] [stdout] 144 | | hazard: self.hazard, [INFO] [stdout] 145 | | pointer: f(self.pointer)?, [INFO] [stdout] 146 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/guard.rs:155:29 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn maybe_map(self, f: F) -> Option> [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | where F: FnOnce(&T) -> Option<&U> { [INFO] [stdout] 154 | let hazard = self.hazard; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | f(self.pointer).map(|res| Guard { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 156 | | hazard: hazard, [INFO] [stdout] 157 | | pointer: res, [INFO] [stdout] 158 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::from_raw` that must be used [INFO] [stdout] --> src/hazard.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | Box::from_raw(self.ptr as *const AtomicPtr as *mut AtomicPtr); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 139 | let _ = Box::from_raw(self.ptr as *const AtomicPtr as *mut AtomicPtr); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:25:49 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn add_garbage(garbage: Garbage) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | } else if let Ok(true) = STATE.try_with(|s| s.borrow_mut().add_garbage(garbage)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 43 | match STATE.try_with(|s| s.borrow_mut().get_hazard()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:77:24 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn free_hazard(hazard: hazard::Writer) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | STATE.with(|s| s.borrow_mut().free_hazard(hazard)) ; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/local.rs:91:27 [INFO] [stdout] | [INFO] [stdout] 91 | if STATE.try_with(|s| s.borrow_mut().export_garbage()).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc.rs:22:6 [INFO] [stdout] | [INFO] [stdout] 20 | let end = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | (Sender { [INFO] [stdout] | ______^ [INFO] [stdout] 23 | | inner: end.clone(), [INFO] [stdout] 24 | | }, Receiver { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mpsc.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 20 | let end = Arc::new(Mutex::new(Vec::new())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | }, Receiver { [INFO] [stdout] | ________^ [INFO] [stdout] 25 | | inner: end, [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/stm.rs:16:20 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(data: Option>) -> Stm { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Stm { [INFO] [stdout] 16 | inner: Atomic::new(data), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/stm.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 60 | stm.update(|_| Some(Box::new(4))); [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/stm.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | stm.update(|x| Some(Box::new(*x.unwrap() + 1))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync/stm.rs:78:41 [INFO] [stdout] | [INFO] [stdout] 78 | stm.update(|x| Some(Box::new(*x.unwrap() + 1))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `conc` (lib test) due to 18 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5cf5af5741de09313ff3cd1d1542bcbf629c584091f2c5ef95b4420b624d34a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cf5af5741de09313ff3cd1d1542bcbf629c584091f2c5ef95b4420b624d34a2", kill_on_drop: false }` [INFO] [stdout] 5cf5af5741de09313ff3cd1d1542bcbf629c584091f2c5ef95b4420b624d34a2