[INFO] cloning repository https://github.com/dizda/file-trailer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dizda/file-trailer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdizda%2Ffile-trailer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdizda%2Ffile-trailer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4ee950d4f9b2bd54cabf38abb2531a5fe9b73842 [INFO] checking dizda/file-trailer/4ee950d4f9b2bd54cabf38abb2531a5fe9b73842 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdizda%2Ffile-trailer" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dizda/file-trailer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dizda/file-trailer [INFO] finished tweaking git repo https://github.com/dizda/file-trailer [INFO] tweaked toml for git repo https://github.com/dizda/file-trailer written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dizda/file-trailer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23b2cca72bfff644957560842af6532d7defa7fbe1306ba1cbef641cf287df83 [INFO] running `Command { std: "docker" "start" "-a" "23b2cca72bfff644957560842af6532d7defa7fbe1306ba1cbef641cf287df83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23b2cca72bfff644957560842af6532d7defa7fbe1306ba1cbef641cf287df83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23b2cca72bfff644957560842af6532d7defa7fbe1306ba1cbef641cf287df83", kill_on_drop: false }` [INFO] [stdout] 23b2cca72bfff644957560842af6532d7defa7fbe1306ba1cbef641cf287df83 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f01d4f5c5dce8d5a1ed3a95cf2159f21d76ef9289f04ae089baef4622c943be4 [INFO] running `Command { std: "docker" "start" "-a" "f01d4f5c5dce8d5a1ed3a95cf2159f21d76ef9289f04ae089baef4622c943be4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.118 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling cc v1.0.70 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling serde_derive v1.0.136 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Checking once_cell v1.9.0 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking tracing-core v0.1.22 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking tinyvec v1.3.1 [INFO] [stderr] Compiling openssl v0.10.36 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.6 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling serde_json v1.0.79 [INFO] [stderr] Compiling native-tls v0.2.8 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.1 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Checking lock_api v0.4.6 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking openssl-probe v0.1.4 [INFO] [stderr] Checking itoa v1.0.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling futures-core v0.3.17 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling amq-protocol v6.1.0 [INFO] [stderr] Checking cookie-factory v0.3.2 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Compiling lapin v1.10.0 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Compiling async-trait v0.1.52 [INFO] [stderr] Checking async-task v4.0.3 [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Checking fastrand v1.5.0 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.0 [INFO] [stderr] Compiling openssl-sys v0.9.66 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking parking v2.0.0 [INFO] [stderr] Checking futures-io v0.3.17 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking futures-lite v1.12.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tracing-log v0.1.2 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking os_str_bytes v3.1.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking crc-catalog v1.1.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking crc v2.1.0 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking pem v0.8.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking amq-protocol-uri v6.1.0 [INFO] [stderr] Checking tcp-stream v0.20.7 [INFO] [stderr] Compiling tracing-attributes v0.1.19 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.4 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing v0.1.31 [INFO] [stderr] Checking amq-protocol-tcp v6.1.0 [INFO] [stderr] Checking pinky-swear v4.5.0 [INFO] [stderr] Checking clap v3.0.0-beta.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking amq-protocol-types v6.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.9 [INFO] [stderr] Checking tokio-amqp v1.0.0 [INFO] [stderr] Checking amqp-lapin-helper v0.2.2 [INFO] [stderr] Checking log-bouncer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/reader.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SystemTime` [INFO] [stdout] --> src/rotator.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, SystemTime}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Algorithm` [INFO] [stdout] --> src/rotator.rs:218:11 [INFO] [stdout] | [INFO] [stdout] 218 | use crc::{Algorithm, Crc, CRC_32_ISCSI}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/rotator.rs:303:43 [INFO] [stdout] | [INFO] [stdout] 303 | use std::io::{BufRead, BufReader, Cursor}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PathBuf` and `Path` [INFO] [stdout] --> src/lib.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/reader.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SystemTime` [INFO] [stdout] --> src/rotator.rs:5:27 [INFO] [stdout] | [INFO] [stdout] 5 | use std::time::{Duration, SystemTime}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Algorithm` [INFO] [stdout] --> src/rotator.rs:218:11 [INFO] [stdout] | [INFO] [stdout] 218 | use crc::{Algorithm, Crc, CRC_32_ISCSI}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Cursor` [INFO] [stdout] --> src/rotator.rs:303:43 [INFO] [stdout] | [INFO] [stdout] 303 | use std::io::{BufRead, BufReader, Cursor}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PathBuf` and `Path` [INFO] [stdout] --> src/lib.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/tail.rs:27:35 [INFO] [stdout] | [INFO] [stdout] 27 | use std::io::{BufRead, BufReader, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/reader.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn work(mut self) -> Arc { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `filepath`, `date_format`, and `max_size` are never read [INFO] [stdout] --> src/rotator.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Rotator { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 31 | /// Log file that needs to be watched & rotated [INFO] [stdout] 32 | filepath: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | date_format: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 43 | /// Rotate after reaching this file size [INFO] [stdout] 44 | max_size: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `check_file_exists`, `can_be_rotated`, and `rotate` are never used [INFO] [stdout] --> src/rotator.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 49 | impl Rotator { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 115 | async fn check_file_exists(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | async fn can_be_rotated(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | async fn rotate(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reset` is never used [INFO] [stdout] --> src/rotator.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 232 | impl SavedState { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn reset(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(path: PathBuf, pos: u64, tx: Sender) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Self { path, pos, tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 54 | state_rx: watch::Receiver, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let _file = Rotator::touch_file(&filepath)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let mut saved_state = SavedState::new(&filepath)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | filepath: filepath.to_owned(), [INFO] [stdout] 69 | | date_format, [INFO] [stdout] 70 | | state_rx, [INFO] [stdout] ... | [INFO] [stdout] 75 | | pos, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn watch(mut self) -> JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | tokio::spawn(async move { self.work().await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:153:47 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn watch(mut self) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | tokio::spawn(async move { self.work().await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 255 | let state_file = std::fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 263 | | filepath: filepath.to_owned(), [INFO] [stdout] 264 | | state_file, [INFO] [stdout] 265 | | position: 0, [INFO] [stdout] 266 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/tail.rs:27:35 [INFO] [stdout] | [INFO] [stdout] 27 | use std::io::{BufRead, BufReader, Read, Seek, SeekFrom}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `log-bouncer` (lib test) due to 6 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/reader.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn work(mut self) -> Arc { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `filepath`, `date_format`, and `max_size` are never read [INFO] [stdout] --> src/rotator.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct Rotator { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 31 | /// Log file that needs to be watched & rotated [INFO] [stdout] 32 | filepath: PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | date_format: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 43 | /// Rotate after reaching this file size [INFO] [stdout] 44 | max_size: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `check_file_exists`, `can_be_rotated`, and `rotate` are never used [INFO] [stdout] --> src/rotator.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 49 | impl Rotator { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 115 | async fn check_file_exists(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 121 | async fn can_be_rotated(&self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | async fn rotate(&self) -> Result<()> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `reset` is never used [INFO] [stdout] --> src/rotator.rs:321:12 [INFO] [stdout] | [INFO] [stdout] 232 | impl SavedState { [INFO] [stdout] | --------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 321 | pub fn reset(&mut self) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(path: PathBuf, pos: u64, tx: Sender) -> Result> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | Ok(Self { path, pos, tx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 54 | state_rx: watch::Receiver, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let _file = Rotator::touch_file(&filepath)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | [INFO] [stdout] 63 | let mut saved_state = SavedState::new(&filepath)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 68 | | filepath: filepath.to_owned(), [INFO] [stdout] 69 | | date_format, [INFO] [stdout] 70 | | state_rx, [INFO] [stdout] ... | [INFO] [stdout] 75 | | pos, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn watch(mut self) -> JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | tokio::spawn(async move { self.work().await }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:153:47 [INFO] [stdout] | [INFO] [stdout] 152 | pub fn watch(mut self) -> JoinHandle<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | tokio::spawn(async move { self.work().await }) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rotator.rs:262:12 [INFO] [stdout] | [INFO] [stdout] 255 | let state_file = std::fs::OpenOptions::new() [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 263 | | filepath: filepath.to_owned(), [INFO] [stdout] 264 | | state_file, [INFO] [stdout] 265 | | position: 0, [INFO] [stdout] 266 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `log-bouncer` (lib) due to 6 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f01d4f5c5dce8d5a1ed3a95cf2159f21d76ef9289f04ae089baef4622c943be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f01d4f5c5dce8d5a1ed3a95cf2159f21d76ef9289f04ae089baef4622c943be4", kill_on_drop: false }` [INFO] [stdout] f01d4f5c5dce8d5a1ed3a95cf2159f21d76ef9289f04ae089baef4622c943be4