[INFO] cloning repository https://github.com/divykj/solve-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/divykj/solve-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdivykj%2Fsolve-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdivykj%2Fsolve-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0d77fc0ceba7c88f04f6c274eece49e760e10b5a [INFO] checking divykj/solve-rs/0d77fc0ceba7c88f04f6c274eece49e760e10b5a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdivykj%2Fsolve-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/divykj/solve-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/divykj/solve-rs [INFO] finished tweaking git repo https://github.com/divykj/solve-rs [INFO] tweaked toml for git repo https://github.com/divykj/solve-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/divykj/solve-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: /workspace/builds/worker-0-tc2/source/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `clap` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c037ed6fc666ce3c730a7f17ab435d818454ae79fe97c0e7c9ce1a04344fb92d [INFO] running `Command { std: "docker" "start" "-a" "c037ed6fc666ce3c730a7f17ab435d818454ae79fe97c0e7c9ce1a04344fb92d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c037ed6fc666ce3c730a7f17ab435d818454ae79fe97c0e7c9ce1a04344fb92d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c037ed6fc666ce3c730a7f17ab435d818454ae79fe97c0e7c9ce1a04344fb92d", kill_on_drop: false }` [INFO] [stdout] c037ed6fc666ce3c730a7f17ab435d818454ae79fe97c0e7c9ce1a04344fb92d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a7ab02cd13f7584436ab933522c9f77b3c641fd87ca5cd48c21e3a6e1baf5968 [INFO] running `Command { std: "docker" "start" "-a" "a7ab02cd13f7584436ab933522c9f77b3c641fd87ca5cd48c21e3a6e1baf5968", kill_on_drop: false }` [INFO] [stderr] warning: /opt/rustwide/workdir/Cargo.toml: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `clap` dependency) [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking os_str_bytes v3.1.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking fd-lock v3.0.0 [INFO] [stderr] Checking nix v0.22.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking solve_lib v0.0.1 (/opt/rustwide/workdir/lib) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 74 | let (i, term) = parse_factor(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (i, _) = space0(i)?; [INFO] [stdout] 76 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | i, [INFO] [stdout] 83 | | fold_binary_operator(term, expressions) [INFO] [stdout] 84 | | .expect("verified binary operators (multiply and divide)"), [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 89 | let (i, term) = parse_term(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (i, _) = space0(i)?; [INFO] [stdout] 91 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | i, [INFO] [stdout] 98 | | fold_binary_operator(term, expressions) [INFO] [stdout] 99 | | .expect("verified binary operators (add and subtract)"), [INFO] [stdout] 100 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn fold_binary_operator(left: Expr, right_ops: Vec<(&str, Expr)>) -> Result { [INFO] [stdout] | ---------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / right_ops [INFO] [stdout] 9 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn map_binary_operator(operator: &str, left: Expr, right: Expr) -> Result { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | ADD_OPERATOR => Expr::Add(Box::new(left), Box::new(right)), [INFO] [stdout] 18 | | SUBTRACT_OPERATOR => Expr::Sub(Box::new(left), Box::new(right)), [INFO] [stdout] 19 | | MULTIPLY_OPERATOR => Expr::Mul(Box::new(left), Box::new(right)), [INFO] [stdout] ... | [INFO] [stdout] 22 | | _ => return Err(()), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn map_unary_operator(operator: &str, value: Expr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | UNARY_MINUS_OPERATOR => Expr::Neg(Box::new(value)), [INFO] [stdout] 29 | | UNARY_PLUS_OPERATOR => Expr::Pos(Box::new(value)), [INFO] [stdout] 30 | | _ => return Err(()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solve_lib` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 74 | let (i, term) = parse_factor(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (i, _) = space0(i)?; [INFO] [stdout] 76 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 82 | | i, [INFO] [stdout] 83 | | fold_binary_operator(term, expressions) [INFO] [stdout] 84 | | .expect("verified binary operators (multiply and divide)"), [INFO] [stdout] 85 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser.rs:96:8 [INFO] [stdout] | [INFO] [stdout] 89 | let (i, term) = parse_term(i)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (i, _) = space0(i)?; [INFO] [stdout] 91 | let (i, expressions) = many0(pair( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 97 | | i, [INFO] [stdout] 98 | | fold_binary_operator(term, expressions) [INFO] [stdout] 99 | | .expect("verified binary operators (add and subtract)"), [INFO] [stdout] 100 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) fn fold_binary_operator(left: Expr, right_ops: Vec<(&str, Expr)>) -> Result { [INFO] [stdout] | ---------- ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | / right_ops [INFO] [stdout] 9 | | .into_iter() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn map_binary_operator(operator: &str, left: Expr, right: Expr) -> Result { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 17 | | ADD_OPERATOR => Expr::Add(Box::new(left), Box::new(right)), [INFO] [stdout] 18 | | SUBTRACT_OPERATOR => Expr::Sub(Box::new(left), Box::new(right)), [INFO] [stdout] 19 | | MULTIPLY_OPERATOR => Expr::Mul(Box::new(left), Box::new(right)), [INFO] [stdout] ... | [INFO] [stdout] 22 | | _ => return Err(()), [INFO] [stdout] 23 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> lib/src/parser/mappers.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 26 | pub(crate) fn map_unary_operator(operator: &str, value: Expr) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Ok(match operator { [INFO] [stdout] | ________^ [INFO] [stdout] 28 | | UNARY_MINUS_OPERATOR => Expr::Neg(Box::new(value)), [INFO] [stdout] 29 | | UNARY_PLUS_OPERATOR => Expr::Pos(Box::new(value)), [INFO] [stdout] 30 | | _ => return Err(()), [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solve_lib` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "a7ab02cd13f7584436ab933522c9f77b3c641fd87ca5cd48c21e3a6e1baf5968", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a7ab02cd13f7584436ab933522c9f77b3c641fd87ca5cd48c21e3a6e1baf5968", kill_on_drop: false }` [INFO] [stdout] a7ab02cd13f7584436ab933522c9f77b3c641fd87ca5cd48c21e3a6e1baf5968