[INFO] cloning repository https://github.com/diogoneiss/football-skill-rating [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/diogoneiss/football-skill-rating" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiogoneiss%2Ffootball-skill-rating", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiogoneiss%2Ffootball-skill-rating'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f3054fe13c68315c361f1b53ea4fc0b4cb8014ce [INFO] checking diogoneiss/football-skill-rating/f3054fe13c68315c361f1b53ea4fc0b4cb8014ce against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdiogoneiss%2Ffootball-skill-rating" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/diogoneiss/football-skill-rating on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/diogoneiss/football-skill-rating [INFO] finished tweaking git repo https://github.com/diogoneiss/football-skill-rating [INFO] tweaked toml for git repo https://github.com/diogoneiss/football-skill-rating written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/diogoneiss/football-skill-rating already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b87ce56171c45542397bc0028b17d576b85c7a2049074309229cbaa7b7477b66 [INFO] running `Command { std: "docker" "start" "-a" "b87ce56171c45542397bc0028b17d576b85c7a2049074309229cbaa7b7477b66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b87ce56171c45542397bc0028b17d576b85c7a2049074309229cbaa7b7477b66", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b87ce56171c45542397bc0028b17d576b85c7a2049074309229cbaa7b7477b66", kill_on_drop: false }` [INFO] [stdout] b87ce56171c45542397bc0028b17d576b85c7a2049074309229cbaa7b7477b66 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f1c49722d74643974d02beec366e69c035ca9dd4e9ca38e3fb34682aa86a7c5b [INFO] running `Command { std: "docker" "start" "-a" "f1c49722d74643974d02beec366e69c035ca9dd4e9ca38e3fb34682aa86a7c5b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling serde v1.0.164 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.3 [INFO] [stderr] Compiling serde_derive v1.0.164 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Checking clap v4.3.3 [INFO] [stderr] Checking skillratings v0.25.0 [INFO] [stderr] Checking csv v1.2.2 [INFO] [stderr] Checking poc_elo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `home_diff` [INFO] [stdout] --> src/experimentation/simulate_season.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let home_diff = new_player_home.rating - home_elo.rating; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_home_diff` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `away_diff` [INFO] [stdout] --> src/experimentation/simulate_season.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let away_diff = new_player_away.rating - away_elo.rating; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_away_diff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tabela` [INFO] [stdout] --> src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let tabela = LeagueTable::new(&temporada2009, "Brasileirão", &1); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_tabela` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elo_table_after_5_years` [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let elo_table_after_5_years = construct_elo_table_for_time_series(&partidas, None, 2003, 2008); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elo_table_after_5_years` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_final_table_with_elo` is never used [INFO] [stdout] --> src/elo/util/league.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl<'a> LeagueTable<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 135 | pub fn print_final_table_with_elo(&self, elo_ratings: &HashMap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `year`, `division`, and `league` are never read [INFO] [stdout] --> src/elo/util/season.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Season { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 7 | pub year: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 8 | pub division: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | pub league: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Season` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_all_teams_in_season_map` is never used [INFO] [stdout] --> src/elo/util/season.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn get_all_teams_in_season_map(seasons: &SeasonMap) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/game.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Serialize, Deserialize, Debug, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `poc_elo` (bin "poc_elo" test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `home_diff` [INFO] [stdout] --> src/experimentation/simulate_season.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | let home_diff = new_player_home.rating - home_elo.rating; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_home_diff` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `away_diff` [INFO] [stdout] --> src/experimentation/simulate_season.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let away_diff = new_player_away.rating - away_elo.rating; [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_away_diff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `tabela` [INFO] [stdout] --> src/main.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | let tabela = LeagueTable::new(&temporada2009, "Brasileirão", &1); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_tabela` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `elo_table_after_5_years` [INFO] [stdout] --> src/main.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | let elo_table_after_5_years = construct_elo_table_for_time_series(&partidas, None, 2003, 2008); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_elo_table_after_5_years` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `print_final_table_with_elo` is never used [INFO] [stdout] --> src/elo/util/league.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl<'a> LeagueTable<'a> { [INFO] [stdout] | ------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 135 | pub fn print_final_table_with_elo(&self, elo_ratings: &HashMap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `year`, `division`, and `league` are never read [INFO] [stdout] --> src/elo/util/season.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct Season { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 7 | pub year: u16, [INFO] [stdout] | ^^^^ [INFO] [stdout] 8 | pub division: u8, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 9 | pub league: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Season` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_all_teams_in_season_map` is never used [INFO] [stdout] --> src/elo/util/season.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn get_all_teams_in_season_map(seasons: &SeasonMap) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/game.rs:4:21 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Serialize, Deserialize, Debug, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `poc_elo` (bin "poc_elo") due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f1c49722d74643974d02beec366e69c035ca9dd4e9ca38e3fb34682aa86a7c5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f1c49722d74643974d02beec366e69c035ca9dd4e9ca38e3fb34682aa86a7c5b", kill_on_drop: false }` [INFO] [stdout] f1c49722d74643974d02beec366e69c035ca9dd4e9ca38e3fb34682aa86a7c5b