[INFO] cloning repository https://github.com/dingxiangfei2009/udarnik [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dingxiangfei2009/udarnik" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdingxiangfei2009%2Fudarnik", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdingxiangfei2009%2Fudarnik'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 10803628f875041ac3051116185eae0898556f14 [INFO] checking dingxiangfei2009/udarnik/10803628f875041ac3051116185eae0898556f14 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdingxiangfei2009%2Fudarnik" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dingxiangfei2009/udarnik on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dingxiangfei2009/udarnik [INFO] finished tweaking git repo https://github.com/dingxiangfei2009/udarnik [INFO] tweaked toml for git repo https://github.com/dingxiangfei2009/udarnik written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dingxiangfei2009/udarnik already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 998196ce59f7bc0356c1f7d937a70702ba859e84156fd936a828baa61b2bbec5 [INFO] running `Command { std: "docker" "start" "-a" "998196ce59f7bc0356c1f7d937a70702ba859e84156fd936a828baa61b2bbec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "998196ce59f7bc0356c1f7d937a70702ba859e84156fd936a828baa61b2bbec5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "998196ce59f7bc0356c1f7d937a70702ba859e84156fd936a828baa61b2bbec5", kill_on_drop: false }` [INFO] [stdout] 998196ce59f7bc0356c1f7d937a70702ba859e84156fd936a828baa61b2bbec5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a7a09b2b3801d9a6b038efbf8b111e1b66e81a4d81949e0c0fea4524a3d9a00 [INFO] running `Command { std: "docker" "start" "-a" "3a7a09b2b3801d9a6b038efbf8b111e1b66e81a4d81949e0c0fea4524a3d9a00", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Compiling cc v1.0.35 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling libc v0.2.51 [INFO] [stderr] Compiling syn v0.15.32 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling backtrace v0.3.15 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling subtle v2.0.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rustc-demangle v0.1.14 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking block-padding v0.1.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.3 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling clear_on_drop v0.2.3 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking sha3 v0.8.1 [INFO] [stderr] Compiling curve25519-dalek v1.1.3 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking udarnik v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `edwards::EdwardsPoint`, `scalar::Scalar`, and `traits::Identity` [INFO] [stdout] --> src/pvss/dleq.rs:58:45 [INFO] [stdout] | [INFO] [stdout] 58 | constants::ED25519_BASEPOINT_POINT, edwards::EdwardsPoint, scalar::Scalar, traits::Identity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pvss/mod.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | mut poll, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `ed25519_base_mul` is never used [INFO] [stdout] --> src/pvss/mod.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn ed25519_base_mul(s: &Scalar) -> EdwardsPoint { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pvss/mod.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | mut poll, [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `random_scalar` is never used [INFO] [stdout] --> src/pvss/mod.rs:15:4 [INFO] [stdout] | [INFO] [stdout] 15 | fn random_scalar(rng: &mut R) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `ZeroCustodianId` and `InvalidCustodianId` are never constructed [INFO] [stdout] --> src/pvss/mod.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub enum Error { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 34 | ZeroCustodianId, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 35 | #[fail(display = "custodian id is invalid")] [INFO] [stdout] 36 | InvalidCustodianId(u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Polynomial` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct Polynomial(Vec); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `eval` are never used [INFO] [stdout] --> src/pvss/mod.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 53 | impl Polynomial { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 54 | /// A polynomial with coefficients in Ed25519 [INFO] [stdout] 55 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 78 | fn eval(&self, x: &Scalar) -> Scalar { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Shard` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:119:12 [INFO] [stdout] | [INFO] [stdout] 119 | pub struct Shard { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:125:12 [INFO] [stdout] | [INFO] [stdout] 124 | impl Shard { [INFO] [stdout] | ---------- associated function in this implementation [INFO] [stdout] 125 | pub fn new(p: &Polynomial, id: u64, key: &EdwardsPoint) -> (Self, Scalar) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Seed` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub struct Seed(Scalar); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 134 | impl Seed { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 135 | fn new(rng: &mut R) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SignedSeed` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | pub struct SignedSeed(EdwardsPoint); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 142 | impl SignedSeed { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 143 | pub fn new(seed: &Seed, base: &EdwardsPoint) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:153:8 [INFO] [stdout] | [INFO] [stdout] 152 | impl Commits { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 153 | fn new(p: &Polynomial) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Challenge` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | pub struct Challenge(Scalar); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:161:8 [INFO] [stdout] | [INFO] [stdout] 160 | impl Challenge { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 161 | fn new(commits: &Commits, dealer_signed_seeds: &[SignedSeed], shards: &[Shard]) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Responses` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:179:12 [INFO] [stdout] | [INFO] [stdout] 179 | pub struct Responses(Vec); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:182:8 [INFO] [stdout] | [INFO] [stdout] 181 | impl Responses { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 182 | fn new(challenge: &Challenge, seeds: &[Seed], secret_shards: &[Scalar]) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ShardsWithProof` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | pub struct ShardsWithProof { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ShardsWithProof` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | impl ShardsWithProof { [INFO] [stdout] | -------------------- associated function in this implementation [INFO] [stdout] 217 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 317 | impl CustodianDecryption { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] 318 | pub fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/pvss/mod.rs:344:8 [INFO] [stdout] | [INFO] [stdout] 343 | impl CustodianProof { [INFO] [stdout] | ------------------- associated function in this implementation [INFO] [stdout] 344 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `recover_secret` is never used [INFO] [stdout] --> src/pvss/mod.rs:450:8 [INFO] [stdout] | [INFO] [stdout] 450 | pub fn recover_secret(poll: Verified) -> EdwardsPoint { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | fn verify_proof(self, proof: Self::Proof) -> Result, Self::Error> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Verified(self.verify(proof)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `InvalidCustodianId` is never constructed [INFO] [stdout] --> src/pvss/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub enum Error { [INFO] [stdout] | ----- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 36 | InvalidCustodianId(u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Error` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/common.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | fn verify_proof(self, proof: Self::Proof) -> Result, Self::Error> { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Ok(Verified(self.verify(proof)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 22 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `udarnik` (lib) due to 2 previous errors; 22 warnings emitted [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `udarnik` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3a7a09b2b3801d9a6b038efbf8b111e1b66e81a4d81949e0c0fea4524a3d9a00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a7a09b2b3801d9a6b038efbf8b111e1b66e81a4d81949e0c0fea4524a3d9a00", kill_on_drop: false }` [INFO] [stdout] 3a7a09b2b3801d9a6b038efbf8b111e1b66e81a4d81949e0c0fea4524a3d9a00