[INFO] cloning repository https://github.com/digitalsanctum/combos [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/digitalsanctum/combos" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdigitalsanctum%2Fcombos", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdigitalsanctum%2Fcombos'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c186afe87ff73f4d501b66b864747d130295dc56 [INFO] checking digitalsanctum/combos/c186afe87ff73f4d501b66b864747d130295dc56 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdigitalsanctum%2Fcombos" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/digitalsanctum/combos on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/digitalsanctum/combos [INFO] finished tweaking git repo https://github.com/digitalsanctum/combos [INFO] tweaked toml for git repo https://github.com/digitalsanctum/combos written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/digitalsanctum/combos already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 473cf6d79d63d0011e6971bf8453ad038b0a5971b99e96dbdd6855a174d16926 [INFO] running `Command { std: "docker" "start" "-a" "473cf6d79d63d0011e6971bf8453ad038b0a5971b99e96dbdd6855a174d16926", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "473cf6d79d63d0011e6971bf8453ad038b0a5971b99e96dbdd6855a174d16926", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "473cf6d79d63d0011e6971bf8453ad038b0a5971b99e96dbdd6855a174d16926", kill_on_drop: false }` [INFO] [stdout] 473cf6d79d63d0011e6971bf8453ad038b0a5971b99e96dbdd6855a174d16926 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 263867e5f1fa1d1f8b0d2acd89e71d626580bc8a140780224df2aeda6aa02dd1 [INFO] running `Command { std: "docker" "start" "-a" "263867e5f1fa1d1f8b0d2acd89e71d626580bc8a140780224df2aeda6aa02dd1", kill_on_drop: false }` [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking combos v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let f = File::open(filename).expect("No such file"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let br = BufReader::new(f); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / br.lines() [INFO] [stdout] 12 | | .map(|l| l.expect("Could not parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `combos` (bin "combos") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | fn lines_from_file(filename: impl AsRef) -> Vec { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let f = File::open(filename).expect("No such file"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let br = BufReader::new(f); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | / br.lines() [INFO] [stdout] 12 | | .map(|l| l.expect("Could not parse line")) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `combos` (bin "combos" test) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "263867e5f1fa1d1f8b0d2acd89e71d626580bc8a140780224df2aeda6aa02dd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "263867e5f1fa1d1f8b0d2acd89e71d626580bc8a140780224df2aeda6aa02dd1", kill_on_drop: false }` [INFO] [stdout] 263867e5f1fa1d1f8b0d2acd89e71d626580bc8a140780224df2aeda6aa02dd1