[INFO] cloning repository https://github.com/dgtony/tsrt [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dgtony/tsrt" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgtony%2Ftsrt", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgtony%2Ftsrt'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 691f891d5dbdb1d06bd2964c93e93870a7e656d8 [INFO] checking dgtony/tsrt/691f891d5dbdb1d06bd2964c93e93870a7e656d8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgtony%2Ftsrt" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dgtony/tsrt on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dgtony/tsrt [INFO] finished tweaking git repo https://github.com/dgtony/tsrt [INFO] tweaked toml for git repo https://github.com/dgtony/tsrt written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dgtony/tsrt already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 903da0496e55c767cdb6b9a4d048f0ce224226ff7ae8a92c0a8786f76ebbe7fd [INFO] running `Command { std: "docker" "start" "-a" "903da0496e55c767cdb6b9a4d048f0ce224226ff7ae8a92c0a8786f76ebbe7fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "903da0496e55c767cdb6b9a4d048f0ce224226ff7ae8a92c0a8786f76ebbe7fd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "903da0496e55c767cdb6b9a4d048f0ce224226ff7ae8a92c0a8786f76ebbe7fd", kill_on_drop: false }` [INFO] [stdout] 903da0496e55c767cdb6b9a4d048f0ce224226ff7ae8a92c0a8786f76ebbe7fd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 246088570bec81d3fc6f6a394934bf2322a704d49c6b7a06aa80d81a36c8579c [INFO] running `Command { std: "docker" "start" "-a" "246088570bec81d3fc6f6a394934bf2322a704d49c6b7a06aa80d81a36c8579c", kill_on_drop: false }` [INFO] [stderr] Checking tsrt v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sorting/graph.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn contains_cycles(&self, start: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | self.dfs(start) == Err(TSortErr::Cycle) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sorting/graph.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn contains_cycles(&self, start: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | self.dfs(start) == Err(TSortErr::Cycle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsrt` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sorting/graph.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn contains_cycles(&self, start: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | self.dfs(start) == Err(TSortErr::Cycle) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sorting/graph.rs:104:28 [INFO] [stdout] | [INFO] [stdout] 103 | pub fn contains_cycles(&self, start: T) -> bool { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | self.dfs(start) == Err(TSortErr::Cycle) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `a` should have an upper case name [INFO] [stdout] --> src/sorting/graph.rs:244:11 [INFO] [stdout] | [INFO] [stdout] 244 | const a: &'static str = "a"; [INFO] [stdout] | ^ help: convert the identifier to upper case: `A` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `b` should have an upper case name [INFO] [stdout] --> src/sorting/graph.rs:245:11 [INFO] [stdout] | [INFO] [stdout] 245 | const b: &'static str = "b"; [INFO] [stdout] | ^ help: convert the identifier to upper case: `B` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `c` should have an upper case name [INFO] [stdout] --> src/sorting/graph.rs:246:11 [INFO] [stdout] | [INFO] [stdout] 246 | const c: &'static str = "c"; [INFO] [stdout] | ^ help: convert the identifier to upper case (notice the capitalization): `C` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `d` should have an upper case name [INFO] [stdout] --> src/sorting/graph.rs:247:11 [INFO] [stdout] | [INFO] [stdout] 247 | const d: &'static str = "d"; [INFO] [stdout] | ^ help: convert the identifier to upper case: `D` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tsrt` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "246088570bec81d3fc6f6a394934bf2322a704d49c6b7a06aa80d81a36c8579c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "246088570bec81d3fc6f6a394934bf2322a704d49c6b7a06aa80d81a36c8579c", kill_on_drop: false }` [INFO] [stdout] 246088570bec81d3fc6f6a394934bf2322a704d49c6b7a06aa80d81a36c8579c