[INFO] cloning repository https://github.com/dgoetsch/rust-search [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dgoetsch/rust-search" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgoetsch%2Frust-search", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgoetsch%2Frust-search'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4f479b2acc3e6c029d0634f908074d99b971fb8a [INFO] checking dgoetsch/rust-search/4f479b2acc3e6c029d0634f908074d99b971fb8a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgoetsch%2Frust-search" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dgoetsch/rust-search on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dgoetsch/rust-search [INFO] finished tweaking git repo https://github.com/dgoetsch/rust-search [INFO] tweaked toml for git repo https://github.com/dgoetsch/rust-search written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dgoetsch/rust-search already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 491ad24d9bb917816273707ef110264bd9172a9bf1afdbeba0e0d9c7ceb39dde [INFO] running `Command { std: "docker" "start" "-a" "491ad24d9bb917816273707ef110264bd9172a9bf1afdbeba0e0d9c7ceb39dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "491ad24d9bb917816273707ef110264bd9172a9bf1afdbeba0e0d9c7ceb39dde", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "491ad24d9bb917816273707ef110264bd9172a9bf1afdbeba0e0d9c7ceb39dde", kill_on_drop: false }` [INFO] [stdout] 491ad24d9bb917816273707ef110264bd9172a9bf1afdbeba0e0d9c7ceb39dde [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 191ae7d341a19b60d269d994bf984045612a984dba2e01b900e5e8395529c431 [INFO] running `Command { std: "docker" "start" "-a" "191ae7d341a19b60d269d994bf984045612a984dba2e01b900e5e8395529c431", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling regex v1.0.6 [INFO] [stderr] Checking ucd-util v0.1.3 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Compiling syn v0.15.21 [INFO] [stderr] Checking regex-syntax v0.6.3 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking itertools v0.7.9 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] Checking search v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `SubCommand` [INFO] [stdout] --> src/main.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use clap::{Arg, App, SubCommand}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SubCommand` [INFO] [stdout] --> src/main.rs:5:22 [INFO] [stdout] | [INFO] [stdout] 5 | use clap::{Arg, App, SubCommand}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SendError` [INFO] [stdout] --> src/main.rs:7:41 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{Sender, Receiver, SendError}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration` and `SystemTime` [INFO] [stdout] --> src/main.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | use std::time::{Duration, SystemTime}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Stdout` [INFO] [stdout] --> src/main.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{Write, Stdout}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `SendError` [INFO] [stdout] --> src/main.rs:7:41 [INFO] [stdout] | [INFO] [stdout] 7 | use std::sync::mpsc::{Sender, Receiver, SendError}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io` [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::io; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::prelude::*` [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use std::io::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Duration` and `SystemTime` [INFO] [stdout] --> src/main.rs:15:17 [INFO] [stdout] | [INFO] [stdout] 15 | use std::time::{Duration, SystemTime}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Stdout` [INFO] [stdout] --> src/main.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{Write, Stdout}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:78:31 [INFO] [stdout] | [INFO] [stdout] 78 | let mut loggers: Vec> = vec![ WriteLogger::new(log_level, Config::default(), std::io::stderr())]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 78 | let mut loggers: Vec> = vec![ WriteLogger::new(log_level, Config::default(), std::io::stderr())]; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:78:31 [INFO] [stdout] | [INFO] [stdout] 78 | let mut loggers: Vec> = vec![ WriteLogger::new(log_level, Config::default(), std::io::stderr())]; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 78 | let mut loggers: Vec> = vec![ WriteLogger::new(log_level, Config::default(), std::io::stderr())]; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:83:27 [INFO] [stdout] | [INFO] [stdout] 83 | .or_else(|err| File::open(file_name)) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/main.rs:255:22 [INFO] [stdout] | [INFO] [stdout] 255 | .filter(|p| path.file_name().and_then(|os_str| os_str.to_str()).unwrap_or("").contains(query.as_str())) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | Startup(String), [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 94 | Startup(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | FileIO(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 95 | FileIO(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:96:10 [INFO] [stdout] | [INFO] [stdout] 96 | Send(String), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 96 | Send(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | Aggregate(Vec) [INFO] [stdout] | --------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 97 | Aggregate(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `File` is never constructed [INFO] [stdout] --> src/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 107 | enum SearchResult { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 108 | Contents(String, usize), [INFO] [stdout] 109 | File(String), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SearchResult` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 26 | let matches = App::new("search") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let (tx, rx): (Sender<(PathBuf, String)>, Receiver<(PathBuf, String)>) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (result_sender, result_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let search = Search::new(tx, result_sender, num_workers); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | .map(|()| Search::process_queries(search, rx, result_receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `err` [INFO] [stdout] --> src/main.rs:83:27 [INFO] [stdout] | [INFO] [stdout] 83 | .or_else(|err| File::open(file_name)) [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_err` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | init_logger(matches.value_of("log_level"), matches.value_of("debug_file")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 53 | let _ = init_logger(matches.value_of("log_level"), matches.value_of("debug_file")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | / File::create(file_name) [INFO] [stdout] 83 | | .or_else(|err| File::open(file_name)) [INFO] [stdout] 84 | | .map(|file| [INFO] [stdout] 85 | | loggers.push(WriteLogger::new(LevelFilter::Debug, Config::default(), file))); [INFO] [stdout] | |________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = File::create(file_name) [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:85:34 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|file| [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | loggers.push(WriteLogger::new(LevelFilter::Debug, Config::default(), file))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:132:26 [INFO] [stdout] | [INFO] [stdout] 128 | fn new(tx: Sender<(PathBuf, String)>, result_sender: Sender, num_workers: usize) -> Search { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | thread_pool: ThreadPool::new(num_workers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / next_query [INFO] [stdout] 141 | | .map(|(path, query)| search.search(path, query)); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = next_query [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | writer.flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 167 | let _ = writer.flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | query_thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 172 | let _ = query_thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | result_thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 174 | let _ = result_thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|entries| [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | / entries [INFO] [stdout] 200 | | .into_iter() [INFO] [stdout] 201 | | .map(|r| { r [INFO] [stdout] 202 | | .map_err(|e| AppError::FileIO(e.to_string())) [INFO] [stdout] 203 | | .and_then(|entry| { self.tx.send((entry.path(), query.clone())).map_err(|e| AppError::Send(e.to_string()) )}) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:201:32 [INFO] [stdout] | [INFO] [stdout] 201 | .map(|r| { r [INFO] [stdout] | ___________________________-____^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | | .map_err(|e| AppError::FileIO(e.to_string())) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `search` (bin "search") due to 6 previous errors; 20 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/main.rs:255:22 [INFO] [stdout] | [INFO] [stdout] 255 | .filter(|p| path.file_name().and_then(|os_str| os_str.to_str()).unwrap_or("").contains(query.as_str())) [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:94:13 [INFO] [stdout] | [INFO] [stdout] 94 | Startup(String), [INFO] [stdout] | ------- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 94 | Startup(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 95 | FileIO(String), [INFO] [stdout] | ------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 95 | FileIO(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:96:10 [INFO] [stdout] | [INFO] [stdout] 96 | Send(String), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 96 | Send(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:97:15 [INFO] [stdout] | [INFO] [stdout] 97 | Aggregate(Vec) [INFO] [stdout] | --------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `AppError` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 97 | Aggregate(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `File` is never constructed [INFO] [stdout] --> src/main.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 107 | enum SearchResult { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] 108 | Contents(String, usize), [INFO] [stdout] 109 | File(String), [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SearchResult` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:59:14 [INFO] [stdout] | [INFO] [stdout] 26 | let matches = App::new("search") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | let (tx, rx): (Sender<(PathBuf, String)>, Receiver<(PathBuf, String)>) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | let (result_sender, result_receiver): (Sender, Receiver) = mpsc::channel(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let search = Search::new(tx, result_sender, num_workers); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | .map(|()| Search::process_queries(search, rx, result_receiver)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | init_logger(matches.value_of("log_level"), matches.value_of("debug_file")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 53 | let _ = init_logger(matches.value_of("log_level"), matches.value_of("debug_file")); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | / File::create(file_name) [INFO] [stdout] 83 | | .or_else(|err| File::open(file_name)) [INFO] [stdout] 84 | | .map(|file| [INFO] [stdout] 85 | | loggers.push(WriteLogger::new(LevelFilter::Debug, Config::default(), file))); [INFO] [stdout] | |________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = File::create(file_name) [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:85:34 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|file| [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | loggers.push(WriteLogger::new(LevelFilter::Debug, Config::default(), file))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:132:26 [INFO] [stdout] | [INFO] [stdout] 128 | fn new(tx: Sender<(PathBuf, String)>, result_sender: Sender, num_workers: usize) -> Search { [INFO] [stdout] | ----------------------------- ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | thread_pool: ThreadPool::new(num_workers), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | / next_query [INFO] [stdout] 141 | | .map(|(path, query)| search.search(path, query)); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 140 | let _ = next_query [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:167:13 [INFO] [stdout] | [INFO] [stdout] 167 | writer.flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 167 | let _ = writer.flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 172 | query_thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 172 | let _ = query_thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | result_thread.join(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 174 | let _ = result_thread.join(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:199:17 [INFO] [stdout] | [INFO] [stdout] 198 | .map(|entries| [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | / entries [INFO] [stdout] 200 | | .into_iter() [INFO] [stdout] 201 | | .map(|r| { r [INFO] [stdout] 202 | | .map_err(|e| AppError::FileIO(e.to_string())) [INFO] [stdout] 203 | | .and_then(|entry| { self.tx.send((entry.path(), query.clone())).map_err(|e| AppError::Send(e.to_string()) )}) [INFO] [stdout] 204 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:201:32 [INFO] [stdout] | [INFO] [stdout] 201 | .map(|r| { r [INFO] [stdout] | ___________________________-____^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | | .map_err(|e| AppError::FileIO(e.to_string())) [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `search` (bin "search" test) due to 6 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "191ae7d341a19b60d269d994bf984045612a984dba2e01b900e5e8395529c431", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "191ae7d341a19b60d269d994bf984045612a984dba2e01b900e5e8395529c431", kill_on_drop: false }` [INFO] [stdout] 191ae7d341a19b60d269d994bf984045612a984dba2e01b900e5e8395529c431