[INFO] cloning repository https://github.com/devongovett/worker-experiment [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/devongovett/worker-experiment" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevongovett%2Fworker-experiment", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevongovett%2Fworker-experiment'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0c7832f338f7a0148a95892f057d71db35d01b4e [INFO] checking devongovett/worker-experiment/0c7832f338f7a0148a95892f057d71db35d01b4e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevongovett%2Fworker-experiment" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/devongovett/worker-experiment on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/devongovett/worker-experiment [INFO] finished tweaking git repo https://github.com/devongovett/worker-experiment [INFO] tweaked toml for git repo https://github.com/devongovett/worker-experiment written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/devongovett/worker-experiment already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 81d641210d9f07f6e4e8a7a7d072a86ee4486b98c2f56a5021a21941c1ffe650 [INFO] running `Command { std: "docker" "start" "-a" "81d641210d9f07f6e4e8a7a7d072a86ee4486b98c2f56a5021a21941c1ffe650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "81d641210d9f07f6e4e8a7a7d072a86ee4486b98c2f56a5021a21941c1ffe650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "81d641210d9f07f6e4e8a7a7d072a86ee4486b98c2f56a5021a21941c1ffe650", kill_on_drop: false }` [INFO] [stdout] 81d641210d9f07f6e4e8a7a7d072a86ee4486b98c2f56a5021a21941c1ffe650 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ba3052184ecab9448a5de0f3eedeb3d46afb22768291acc4af0509c210b7876 [INFO] running `Command { std: "docker" "start" "-a" "9ba3052184ecab9448a5de0f3eedeb3d46afb22768291acc4af0509c210b7876", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking once_cell v1.12.0 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling regex-syntax v0.6.26 [INFO] [stderr] Compiling napi-build v2.0.1 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.9 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling convert_case v0.5.0 [INFO] [stderr] Compiling worker-experiment v0.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking napi-sys v2.2.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling regex v1.5.6 [INFO] [stderr] Compiling napi-derive-backend v1.0.33 [INFO] [stderr] Compiling ctor v0.1.22 [INFO] [stderr] Compiling napi-derive v2.5.0 [INFO] [stderr] Checking napi v2.5.0 [INFO] [stdout] warning: unused variable: `ret` [INFO] [stdout] --> src/threadsafe_function.rs:283:7 [INFO] [stdout] | [INFO] [stdout] 283 | let ret = val.and_then(|v| { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ret` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `aborted`, `abort`, and `raw` are never used [INFO] [stdout] --> src/threadsafe_function.rs:168:10 [INFO] [stdout] | [INFO] [stdout] 118 | impl ThreadsafeFunction { [INFO] [stdout] | ---------------------------------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn aborted(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | pub fn abort(self) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn raw(&self) -> sys::napi_threadsafe_function { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `call` is never used [INFO] [stdout] --> src/threadsafe_function.rs:210:10 [INFO] [stdout] | [INFO] [stdout] 207 | impl ThreadsafeFunction { [INFO] [stdout] | ------------------------------------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 210 | pub fn call(&self, value: T, mode: ThreadsafeFunctionCallMode) -> Status { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 127 | callback: R, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let s = CString::new(s)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let aborted = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(ThreadsafeFunction { [INFO] [stdout] | ________^ [INFO] [stdout] 161 | | raw_tsfn, [INFO] [stdout] 162 | | aborted, [INFO] [stdout] 163 | | ref_count: Arc::new(AtomicUsize::new(initial_thread_count)), [INFO] [stdout] 164 | | _phantom: PhantomData, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:284:11 [INFO] [stdout] | [INFO] [stdout] 283 | let ret = val.and_then(|v| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | (ctx)(ThreadSafeCallContext { [INFO] [stdout] | ___________^ [INFO] [stdout] 285 | | env: unsafe { Env::from_raw(raw_env) }, [INFO] [stdout] 286 | | value: v, [INFO] [stdout] 287 | | callback: JsFunction::from_raw( [INFO] [stdout] ... | [INFO] [stdout] 290 | | ).unwrap() // TODO: unwrap [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ret` [INFO] [stdout] --> src/threadsafe_function.rs:283:7 [INFO] [stdout] | [INFO] [stdout] 283 | let ret = val.and_then(|v| { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ret` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `worker-experiment` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: methods `aborted`, `abort`, and `raw` are never used [INFO] [stdout] --> src/threadsafe_function.rs:168:10 [INFO] [stdout] | [INFO] [stdout] 118 | impl ThreadsafeFunction { [INFO] [stdout] | ---------------------------------------------------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 168 | pub fn aborted(&self) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | pub fn abort(self) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 184 | pub fn raw(&self) -> sys::napi_threadsafe_function { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `call` is never used [INFO] [stdout] --> src/threadsafe_function.rs:210:10 [INFO] [stdout] | [INFO] [stdout] 207 | impl ThreadsafeFunction { [INFO] [stdout] | ------------------------------------------------------------ method in this implementation [INFO] [stdout] ... [INFO] [stdout] 210 | pub fn call(&self, value: T, mode: ThreadsafeFunctionCallMode) -> Status { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 127 | callback: R, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | let s = CString::new(s)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let aborted = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | Ok(ThreadsafeFunction { [INFO] [stdout] | ________^ [INFO] [stdout] 161 | | raw_tsfn, [INFO] [stdout] 162 | | aborted, [INFO] [stdout] 163 | | ref_count: Arc::new(AtomicUsize::new(initial_thread_count)), [INFO] [stdout] 164 | | _phantom: PhantomData, [INFO] [stdout] 165 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadsafe_function.rs:284:11 [INFO] [stdout] | [INFO] [stdout] 283 | let ret = val.and_then(|v| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | (ctx)(ThreadSafeCallContext { [INFO] [stdout] | ___________^ [INFO] [stdout] 285 | | env: unsafe { Env::from_raw(raw_env) }, [INFO] [stdout] 286 | | value: v, [INFO] [stdout] 287 | | callback: JsFunction::from_raw( [INFO] [stdout] ... | [INFO] [stdout] 290 | | ).unwrap() // TODO: unwrap [INFO] [stdout] 291 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `worker-experiment` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9ba3052184ecab9448a5de0f3eedeb3d46afb22768291acc4af0509c210b7876", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ba3052184ecab9448a5de0f3eedeb3d46afb22768291acc4af0509c210b7876", kill_on_drop: false }` [INFO] [stdout] 9ba3052184ecab9448a5de0f3eedeb3d46afb22768291acc4af0509c210b7876