[INFO] cloning repository https://github.com/detailyang/promql-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/detailyang/promql-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdetailyang%2Fpromql-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdetailyang%2Fpromql-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b39022ff54f0e20b414798552add25249b11df3f [INFO] checking detailyang/promql-rs/b39022ff54f0e20b414798552add25249b11df3f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdetailyang%2Fpromql-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/detailyang/promql-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/detailyang/promql-rs [INFO] finished tweaking git repo https://github.com/detailyang/promql-rs [INFO] tweaked toml for git repo https://github.com/detailyang/promql-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/detailyang/promql-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 17f9032f6ad1fb63df9d3dadfa5e29336b84a427b3ff9b8562846c730430e3a2 [INFO] running `Command { std: "docker" "start" "-a" "17f9032f6ad1fb63df9d3dadfa5e29336b84a427b3ff9b8562846c730430e3a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "17f9032f6ad1fb63df9d3dadfa5e29336b84a427b3ff9b8562846c730430e3a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17f9032f6ad1fb63df9d3dadfa5e29336b84a427b3ff9b8562846c730430e3a2", kill_on_drop: false }` [INFO] [stdout] 17f9032f6ad1fb63df9d3dadfa5e29336b84a427b3ff9b8562846c730430e3a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22aaf2003d21b5e159001ba29de0937d0b35023003c0ea9998dfc08e981c399f [INFO] running `Command { std: "docker" "start" "-a" "22aaf2003d21b5e159001ba29de0937d0b35023003c0ea9998dfc08e981c399f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling syn v1.0.63 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling lexical-core v0.7.5 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking bitvec v0.19.5 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking promql v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn subquery_expr(expr: Expr, range: Option, resolution: Option) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Expr::SubQueryExpr(Box::new(SubqueryExpr { [INFO] [stdout] | ________________________^ [INFO] [stdout] 49 | | expr, [INFO] [stdout] 50 | | range, [INFO] [stdout] 51 | | resolution, [INFO] [stdout] 52 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn fun_call_expr(func: FunCall) -> Expr { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Expr::FunCallExpr(Box::new(func)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn binary_expr(op: BinaryOp, lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Expr::BinaryExpr(Box::new(BinaryExpr { op, lhs, rhs })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/funcall.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn fun_call(name: &str, args: Vec) -> FunCall { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:55:66 [INFO] [stdout] | [INFO] [stdout] 55 | ws(parse_number_literal).map(|e| Expr::NumberLiteralExpr(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 57 | map(preceded(tag("-"), parse_atom), |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Expr::NegationExpr(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:60:55 [INFO] [stdout] | [INFO] [stdout] 60 | parse_function_call.map(|e| Expr::FunCallExpr(Box::new(e))), [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | parse_vector.map(|e| Expr::VectorExpr(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/func.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(input, (name, (args, aggregation)))| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | / FunCall { [INFO] [stdout] 36 | | name: name.to_owned(), [INFO] [stdout] 37 | | args, [INFO] [stdout] 38 | | aggregation, [INFO] [stdout] 39 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/func.rs:79:66 [INFO] [stdout] | [INFO] [stdout] 79 | parse_string_literal.map(|s| Expr::StringLiteralExpr(Box::new(s))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `promql` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:48:24 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn subquery_expr(expr: Expr, range: Option, resolution: Option) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Expr::SubQueryExpr(Box::new(SubqueryExpr { [INFO] [stdout] | ________________________^ [INFO] [stdout] 49 | | expr, [INFO] [stdout] 50 | | range, [INFO] [stdout] 51 | | resolution, [INFO] [stdout] 52 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn fun_call_expr(func: FunCall) -> Expr { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | Expr::FunCallExpr(Box::new(func)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/mod.rs:60:22 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn binary_expr(op: BinaryOp, lhs: Expr, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Expr::BinaryExpr(Box::new(BinaryExpr { op, lhs, rhs })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ast/funcall.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 12 | pub(crate) fn fun_call(name: &str, args: Vec) -> FunCall { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 16 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:55:66 [INFO] [stdout] | [INFO] [stdout] 55 | ws(parse_number_literal).map(|e| Expr::NumberLiteralExpr(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 57 | map(preceded(tag("-"), parse_atom), |e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | Expr::NegationExpr(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:60:55 [INFO] [stdout] | [INFO] [stdout] 60 | parse_function_call.map(|e| Expr::FunCallExpr(Box::new(e))), [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:61:47 [INFO] [stdout] | [INFO] [stdout] 61 | parse_vector.map(|e| Expr::VectorExpr(Box::new(e))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/func.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(input, (name, (args, aggregation)))| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | / FunCall { [INFO] [stdout] 36 | | name: name.to_owned(), [INFO] [stdout] 37 | | args, [INFO] [stdout] 38 | | aggregation, [INFO] [stdout] 39 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/func.rs:79:66 [INFO] [stdout] | [INFO] [stdout] 79 | parse_string_literal.map(|s| Expr::StringLiteralExpr(Box::new(s))), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `promql` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "22aaf2003d21b5e159001ba29de0937d0b35023003c0ea9998dfc08e981c399f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22aaf2003d21b5e159001ba29de0937d0b35023003c0ea9998dfc08e981c399f", kill_on_drop: false }` [INFO] [stdout] 22aaf2003d21b5e159001ba29de0937d0b35023003c0ea9998dfc08e981c399f