[INFO] cloning repository https://github.com/desbma/shh [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/desbma/shh" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 57fbeb52b4ddc0f41a3b6bd44357135c68367e10 [INFO] checking desbma/shh/57fbeb52b4ddc0f41a3b6bd44357135c68367e10 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdesbma%2Fshh" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/desbma/shh on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/desbma/shh [INFO] finished tweaking git repo https://github.com/desbma/shh [INFO] tweaked toml for git repo https://github.com/desbma/shh written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/desbma/shh already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5bfcc5903a480e87caddd22c1010de770b553b88472a7ec4b730bdc602b8bf7e [INFO] running `Command { std: "docker" "start" "-a" "5bfcc5903a480e87caddd22c1010de770b553b88472a7ec4b730bdc602b8bf7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5bfcc5903a480e87caddd22c1010de770b553b88472a7ec4b730bdc602b8bf7e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5bfcc5903a480e87caddd22c1010de770b553b88472a7ec4b730bdc602b8bf7e", kill_on_drop: false }` [INFO] [stdout] 5bfcc5903a480e87caddd22c1010de770b553b88472a7ec4b730bdc602b8bf7e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24cc9ffbfa1edace2a1c4a993433ee077501dec1ed256f0f748a2d994be85743 [INFO] running `Command { std: "docker" "start" "-a" "24cc9ffbfa1edace2a1c4a993433ee077501dec1ed256f0f748a2d994be85743", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling function_name-proc-macro v0.3.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking simple_logger v4.3.3 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking function_name v0.3.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.35.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling backtrace v0.3.72 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking shh v2024.6.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(reader: Box, log_path: Option<&Path>) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let log = log_path [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | reader, [INFO] [stdout] 40 | | log, [INFO] [stdout] 41 | | buf: String::new(), [INFO] [stdout] 42 | | unfinished_syscalls: Vec::new(), [INFO] [stdout] 43 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 34 | let file = File::options().create(true).append(true).open(p)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(BufWriter::with_capacity(64 * 1024, file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:156:14 [INFO] [stdout] | [INFO] [stdout] 99 | let sc = loop { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Err(e) => return Some(Err(anyhow::Error::new(e).context("Failed to read line"))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | if let Err(e) = writeln!(log, "{line}") { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ParseResult::Syscall(sc)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(ParseResult::SyscallStart(sc)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let sc_start = self.unfinished_syscalls.swap_remove(unfinished_index); // I fucking love Rust <3 [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Some(Ok(sc)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:55:38 [INFO] [stdout] | [INFO] [stdout] 54 | |(pid, rel_ts, name, args, ret_val)| { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ParseResult::Syscall(Syscall { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 56 | | pid, [INFO] [stdout] 57 | | rel_ts, [INFO] [stdout] 58 | | name: name.to_owned(), [INFO] [stdout] 59 | | args, [INFO] [stdout] 60 | | ret_val, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 67 | |(pid, rel_ts, name, args)| { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ParseResult::SyscallStart(SyscallStart { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 69 | | pid, [INFO] [stdout] 70 | | rel_ts, [INFO] [stdout] 71 | | name: name.to_owned(), [INFO] [stdout] 72 | | args, [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:276:32 [INFO] [stdout] | [INFO] [stdout] 276 | |m| Expression::Struct(m.into_iter().collect()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 298 | |(neg, values)| Expression::Collection { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | complement: neg.is_some(), [INFO] [stdout] 300 | values: values.into_iter().map(Expression::Integer).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 344 | |(f, r)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | value: IntegerExpressionValue::BinaryOr( [INFO] [stdout] | ____________________^ [INFO] [stdout] 346 | | iter::once(f.value) [INFO] [stdout] 347 | | .chain(r.into_iter().map(|r| r.value).flat_map(|e| { [INFO] [stdout] 348 | | // Flatten child expressions [INFO] [stdout] ... | [INFO] [stdout] 355 | | .collect(), [INFO] [stdout] 356 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 371 | |(f, r)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | value: IntegerExpressionValue::Multiplication( [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | iter::once(f.value) [INFO] [stdout] 374 | | .chain(r.into_iter().map(|r| r.value).flat_map(|e| { [INFO] [stdout] 375 | | // Flatten child expressions [INFO] [stdout] ... | [INFO] [stdout] 382 | | .collect(), [INFO] [stdout] 383 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:402:20 [INFO] [stdout] | [INFO] [stdout] 402 | value: IntegerExpressionValue::Literal(v), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 413 | |(b, s)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | value: IntegerExpressionValue::LeftBitShift { [INFO] [stdout] | ____________________^ [INFO] [stdout] 415 | | bits: Box::new(b.value), [INFO] [stdout] 416 | | shift: Box::new(s.value), [INFO] [stdout] 417 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:429:20 [INFO] [stdout] | [INFO] [stdout] 429 | value: IntegerExpressionValue::NamedConst(e.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/run.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 26 | let pipe_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let child = Command::new("strace") [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | process: child, [INFO] [stdout] 63 | | pipe_dir, [INFO] [stdout] 64 | | log_path, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/run.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 74 | let reader = BufReader::new(File::open(pipe_path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | LogParser::new(Box::new(reader), self.log_path.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shh` (bin "shh") due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(reader: Box, log_path: Option<&Path>) -> anyhow::Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let log = log_path [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | reader, [INFO] [stdout] 40 | | log, [INFO] [stdout] 41 | | buf: String::new(), [INFO] [stdout] 42 | | unfinished_syscalls: Vec::new(), [INFO] [stdout] 43 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 34 | let file = File::options().create(true).append(true).open(p)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(BufWriter::with_capacity(64 * 1024, file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/mod.rs:156:14 [INFO] [stdout] | [INFO] [stdout] 99 | let sc = loop { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | Err(e) => return Some(Err(anyhow::Error::new(e).context("Failed to read line"))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | if let Err(e) = writeln!(log, "{line}") { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | Ok(ParseResult::Syscall(sc)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(ParseResult::SyscallStart(sc)) => { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | let sc_start = self.unfinished_syscalls.swap_remove(unfinished_index); // I fucking love Rust <3 [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | Some(Ok(sc)) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:55:38 [INFO] [stdout] | [INFO] [stdout] 54 | |(pid, rel_ts, name, args, ret_val)| { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | ParseResult::Syscall(Syscall { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 56 | | pid, [INFO] [stdout] 57 | | rel_ts, [INFO] [stdout] 58 | | name: name.to_owned(), [INFO] [stdout] 59 | | args, [INFO] [stdout] 60 | | ret_val, [INFO] [stdout] 61 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:68:43 [INFO] [stdout] | [INFO] [stdout] 67 | |(pid, rel_ts, name, args)| { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | ParseResult::SyscallStart(SyscallStart { [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 69 | | pid, [INFO] [stdout] 70 | | rel_ts, [INFO] [stdout] 71 | | name: name.to_owned(), [INFO] [stdout] 72 | | args, [INFO] [stdout] 73 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:276:32 [INFO] [stdout] | [INFO] [stdout] 276 | |m| Expression::Struct(m.into_iter().collect()), [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:300:21 [INFO] [stdout] | [INFO] [stdout] 298 | |(neg, values)| Expression::Collection { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 299 | complement: neg.is_some(), [INFO] [stdout] 300 | values: values.into_iter().map(Expression::Integer).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 344 | |(f, r)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | value: IntegerExpressionValue::BinaryOr( [INFO] [stdout] | ____________________^ [INFO] [stdout] 346 | | iter::once(f.value) [INFO] [stdout] 347 | | .chain(r.into_iter().map(|r| r.value).flat_map(|e| { [INFO] [stdout] 348 | | // Flatten child expressions [INFO] [stdout] ... | [INFO] [stdout] 355 | | .collect(), [INFO] [stdout] 356 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:372:20 [INFO] [stdout] | [INFO] [stdout] 371 | |(f, r)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 372 | value: IntegerExpressionValue::Multiplication( [INFO] [stdout] | ____________________^ [INFO] [stdout] 373 | | iter::once(f.value) [INFO] [stdout] 374 | | .chain(r.into_iter().map(|r| r.value).flat_map(|e| { [INFO] [stdout] 375 | | // Flatten child expressions [INFO] [stdout] ... | [INFO] [stdout] 382 | | .collect(), [INFO] [stdout] 383 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:402:20 [INFO] [stdout] | [INFO] [stdout] 402 | value: IntegerExpressionValue::Literal(v), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:414:20 [INFO] [stdout] | [INFO] [stdout] 413 | |(b, s)| IntegerExpression { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 414 | value: IntegerExpressionValue::LeftBitShift { [INFO] [stdout] | ____________________^ [INFO] [stdout] 415 | | bits: Box::new(b.value), [INFO] [stdout] 416 | | shift: Box::new(s.value), [INFO] [stdout] 417 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/parser/combinator.rs:429:20 [INFO] [stdout] | [INFO] [stdout] 429 | value: IntegerExpressionValue::NamedConst(e.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/run.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 26 | let pipe_dir = tempfile::tempdir()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let child = Command::new("strace") [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | process: child, [INFO] [stdout] 63 | | pipe_dir, [INFO] [stdout] 64 | | log_path, [INFO] [stdout] 65 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/strace/run.rs:75:24 [INFO] [stdout] | [INFO] [stdout] 74 | let reader = BufReader::new(File::open(pipe_path)?); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | LogParser::new(Box::new(reader), self.log_path.as_deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shh` (bin "shh" test) due to 15 previous errors [INFO] running `Command { std: "docker" "inspect" "24cc9ffbfa1edace2a1c4a993433ee077501dec1ed256f0f748a2d994be85743", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24cc9ffbfa1edace2a1c4a993433ee077501dec1ed256f0f748a2d994be85743", kill_on_drop: false }` [INFO] [stdout] 24cc9ffbfa1edace2a1c4a993433ee077501dec1ed256f0f748a2d994be85743