[INFO] cloning repository https://github.com/denis-papin/ava-home [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/denis-papin/ava-home" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenis-papin%2Fava-home", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenis-papin%2Fava-home'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fce2b08bd6894ee5fc278caaad00005e537f6d60 [INFO] checking denis-papin/ava-home/fce2b08bd6894ee5fc278caaad00005e537f6d60 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenis-papin%2Fava-home" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/denis-papin/ava-home on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/denis-papin/ava-home [INFO] finished tweaking git repo https://github.com/denis-papin/ava-home [INFO] tweaked toml for git repo https://github.com/denis-papin/ava-home written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/denis-papin/ava-home already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 49 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding adler v1.0.2 [INFO] [stderr] Adding anstream v0.6.15 [INFO] [stderr] Adding anstyle v1.0.8 [INFO] [stderr] Adding anstyle-parse v0.2.5 [INFO] [stderr] Adding anstyle-query v1.1.1 [INFO] [stderr] Adding anstyle-wincon v3.0.4 [INFO] [stderr] Updating ava v0.3.0 (/workspace/builds/worker-4-tc2/source) -> v0.3.1 [INFO] [stderr] Adding backtrace v0.3.73 [INFO] [stderr] Updating byteorder v1.4.3 -> v1.5.0 [INFO] [stderr] Updating bytes v1.2.1 -> v1.7.1 [INFO] [stderr] Adding cc v1.1.15 [INFO] [stderr] Updating clap v2.34.0 -> v4.5.16 [INFO] [stderr] Adding clap_builder v4.5.15 [INFO] [stderr] Adding clap_lex v0.7.2 [INFO] [stderr] Adding colorchoice v1.0.2 [INFO] [stderr] Updating env_logger v0.8.4 -> v0.10.2 (latest: v0.11.5) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.4.0 [INFO] [stderr] Adding is-terminal v0.4.13 [INFO] [stderr] Adding is_terminal_polyfill v1.70.1 [INFO] [stderr] Updating libc v0.2.134 -> v0.2.158 [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Updating mio v0.8.4 -> v1.0.2 [INFO] [stderr] Adding object v0.36.4 [INFO] [stderr] Updating pin-project-lite v0.2.9 -> v0.2.14 [INFO] [stderr] Updating proc-macro2 v1.0.46 -> v1.0.86 [INFO] [stderr] Updating quote v1.0.21 -> v1.0.37 [INFO] [stderr] Adding rustc-demangle v0.1.24 [INFO] [stderr] Adding shlex v1.3.0 [INFO] [stderr] Updating socket2 v0.4.7 -> v0.5.7 [INFO] [stderr] Updating strsim v0.8.0 -> v0.11.1 [INFO] [stderr] Adding syn v2.0.77 [INFO] [stderr] Updating tokio v1.21.2 -> v1.40.0 [INFO] [stderr] Updating tokio-macros v1.8.0 -> v2.4.0 [INFO] [stderr] Updating tokio-util v0.6.10 -> v0.7.11 [INFO] [stderr] Adding utf8parse v0.2.2 [INFO] [stderr] Updating uuid v0.8.2 -> v1.10.0 [INFO] [stderr] Updating windows-sys v0.36.1 -> v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.52.6 [INFO] [stderr] Adding windows_aarch64_gnullvm v0.52.6 [INFO] [stderr] Updating windows_aarch64_msvc v0.36.1 -> v0.52.6 [INFO] [stderr] Updating windows_i686_gnu v0.36.1 -> v0.52.6 [INFO] [stderr] Adding windows_i686_gnullvm v0.52.6 [INFO] [stderr] Updating windows_i686_msvc v0.36.1 -> v0.52.6 [INFO] [stderr] Updating windows_x86_64_gnu v0.36.1 -> v0.52.6 [INFO] [stderr] Adding windows_x86_64_gnullvm v0.52.6 [INFO] [stderr] Updating windows_x86_64_msvc v0.36.1 -> v0.52.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c381a3f7a4b5aae7123ae58b40b3cb1c17f70f0d96d0094204bf89f67f5a25c [INFO] running `Command { std: "docker" "start" "-a" "3c381a3f7a4b5aae7123ae58b40b3cb1c17f70f0d96d0094204bf89f67f5a25c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c381a3f7a4b5aae7123ae58b40b3cb1c17f70f0d96d0094204bf89f67f5a25c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c381a3f7a4b5aae7123ae58b40b3cb1c17f70f0d96d0094204bf89f67f5a25c", kill_on_drop: false }` [INFO] [stdout] 3c381a3f7a4b5aae7123ae58b40b3cb1c17f70f0d96d0094204bf89f67f5a25c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa9e95809dfab4d99222c6ddca4bc4aad2e5672795c1d0e992a96b3e6ccfb618 [INFO] running `Command { std: "docker" "start" "-a" "fa9e95809dfab4d99222c6ddca4bc4aad2e5672795c1d0e992a96b3e6ccfb618", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.101 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Compiling serde v1.0.145 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Compiling serde_derive v1.0.145 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking mqtt-protocol v0.11.2 [INFO] [stderr] Checking ava v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `delay` [INFO] [stdout] --> src/main.rs:511:9 [INFO] [stdout] | [INFO] [stdout] 511 | let delay = time::Duration::from_millis(10); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_delay` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `receive` is never used [INFO] [stdout] --> src/main.rs:278:8 [INFO] [stdout] | [INFO] [stdout] 118 | pub (crate) trait DynDevice { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 278 | fn receive(&self, mut pub_stream: &mut TcpStream, object_message : Box) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `DynLoop` is never used [INFO] [stdout] --> src/main.rs:369:19 [INFO] [stdout] | [INFO] [stdout] 369 | pub (crate) trait DynLoop { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `as_inter_switch`, `as_inter_dim`, `as_temp_sensor`, and `to_inter_switch` are never used [INFO] [stdout] --> src/messages.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub (crate) trait DeviceMessage { [INFO] [stdout] | ------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 16 | fn as_inter_switch(&self) -> &'_ InterSwitch{ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 19 | fn as_inter_dim(&self) -> &'_ InterDim{ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | fn as_temp_sensor(&self) -> &'_ TempSensor{ [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | fn to_inter_switch(&self) -> /*InterSwitch*/ Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/messages.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 53 | impl LampRGB { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] 54 | pub (crate) fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `new` and `from_json` are never used [INFO] [stdout] --> src/messages.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 115 | impl InterSwitch { [INFO] [stdout] | ---------------- associated functions in this implementation [INFO] [stdout] 116 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 122 | pub (crate) fn from_json(msg: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/messages.rs:156:20 [INFO] [stdout] | [INFO] [stdout] 155 | impl TempSensor { [INFO] [stdout] | --------------- associated function in this implementation [INFO] [stdout] 156 | pub (crate) fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/messages.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 190 | impl InterDim { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 191 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `KITCHEN_SWITCH` is never used [INFO] [stdout] --> src/kitchen_switch.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | pub (crate) const KITCHEN_SWITCH : &str = "kitchen_switch"; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KitchenSwitchDevice` is never constructed [INFO] [stdout] --> src/kitchen_switch.rs:10:20 [INFO] [stdout] | [INFO] [stdout] 10 | pub (crate) struct KitchenSwitchDevice { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_name` is never used [INFO] [stdout] --> src/kitchen_switch.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl KitchenSwitchDevice { [INFO] [stdout] | ------------------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 19 | pub fn get_name() -> &'static str { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:279:15 [INFO] [stdout] | [INFO] [stdout] 278 | fn receive(&self, mut pub_stream: &mut TcpStream, object_message : Box) { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | match object_message.to_json() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:446:34 [INFO] [stdout] | [INFO] [stdout] 446 | let dd = borr.deref().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn DynDevice` does not implement `Clone`, so calling `clone` on `&dyn DynDevice` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:486:46 [INFO] [stdout] | [INFO] [stdout] 486 | let dd = borr.deref().clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `dyn DynDevice` does not implement `Clone`, so calling `clone` on `&dyn DynDevice` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ava` (bin "ava") due to 2 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "fa9e95809dfab4d99222c6ddca4bc4aad2e5672795c1d0e992a96b3e6ccfb618", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa9e95809dfab4d99222c6ddca4bc4aad2e5672795c1d0e992a96b3e6ccfb618", kill_on_drop: false }` [INFO] [stdout] fa9e95809dfab4d99222c6ddca4bc4aad2e5672795c1d0e992a96b3e6ccfb618