[INFO] cloning repository https://github.com/denfren/cco [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/denfren/cco" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenfren%2Fcco", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenfren%2Fcco'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 551c9f67637bbcedce4756b06c6c86e9ecd65d40 [INFO] checking denfren/cco/551c9f67637bbcedce4756b06c6c86e9ecd65d40 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdenfren%2Fcco" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/denfren/cco on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/denfren/cco [INFO] finished tweaking git repo https://github.com/denfren/cco [INFO] tweaked toml for git repo https://github.com/denfren/cco written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/denfren/cco already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0d2c028b75129b763ec1a065e298216208eb88d051b62af9c50fe168a2112e73 [INFO] running `Command { std: "docker" "start" "-a" "0d2c028b75129b763ec1a065e298216208eb88d051b62af9c50fe168a2112e73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0d2c028b75129b763ec1a065e298216208eb88d051b62af9c50fe168a2112e73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d2c028b75129b763ec1a065e298216208eb88d051b62af9c50fe168a2112e73", kill_on_drop: false }` [INFO] [stdout] 0d2c028b75129b763ec1a065e298216208eb88d051b62af9c50fe168a2112e73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6a30b74bb66379f5ca74e1c8746c5c79cea916ab3b0f4bbc84fdf33e1f231b2 [INFO] running `Command { std: "docker" "start" "-a" "a6a30b74bb66379f5ca74e1c8746c5c79cea916ab3b0f4bbc84fdf33e1f231b2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking winnow v0.5.32 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.10 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking anstream v0.6.5 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking similar v2.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking bstr v1.9.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking clap_builder v4.4.12 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking globset v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling derive-new v0.6.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.4.13 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking indexmap v2.1.0 [INFO] [stderr] Checking vecmap-rs v0.1.15 [INFO] [stderr] Checking hcl-primitives v0.1.2 [INFO] [stderr] Checking insta v1.34.0 [INFO] [stderr] Checking hcl-edit v0.7.5 [INFO] [stderr] Checking serde_yaml v0.9.30 [INFO] [stderr] Checking hcl-rs v0.16.7 [INFO] [stderr] Checking cco v0.1.1 (/opt/rustwide/workdir/crates/cco) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 47 | fn from(value: hcl::Body) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Value::Object( [INFO] [stdout] 49 | / value [INFO] [stdout] 50 | | .into_attributes() [INFO] [stdout] 51 | | .map(|next| (next.key.to_string(), next.expr.into())) [INFO] [stdout] 52 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|next| (next.key.to_string(), next.expr.into())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 98 | fn from(value: hcl::value::Map) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Value::Object( [INFO] [stdout] 100 | / value [INFO] [stdout] 101 | | .into_iter() [INFO] [stdout] 102 | | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] 103 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:102:47 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:124:22 [INFO] [stdout] | [INFO] [stdout] 123 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Value::Array(value.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 129 | fn from(value: hcl::Object) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Value::Object( [INFO] [stdout] 131 | / value [INFO] [stdout] 132 | | .into_iter() [INFO] [stdout] 133 | | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] 134 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:133:47 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/cco_document.rs:518:9 [INFO] [stdout] | [INFO] [stdout] 517 | fn cco_parse_errors_for(doc: HclDocuments) -> CcoParseErrors { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 518 | CcoDocument::new(&doc).expect_err("must error") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 47 | fn from(value: hcl::Body) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Value::Object( [INFO] [stdout] 49 | / value [INFO] [stdout] 50 | | .into_attributes() [INFO] [stdout] 51 | | .map(|next| (next.key.to_string(), next.expr.into())) [INFO] [stdout] 52 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | .map(|next| (next.key.to_string(), next.expr.into())) [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 98 | fn from(value: hcl::value::Map) -> Self { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | Value::Object( [INFO] [stdout] 100 | / value [INFO] [stdout] 101 | | .into_iter() [INFO] [stdout] 102 | | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] 103 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:102:47 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:124:22 [INFO] [stdout] | [INFO] [stdout] 123 | fn from(value: Vec) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | Value::Array(value.into_iter().map(Into::into).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 129 | fn from(value: hcl::Object) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | Value::Object( [INFO] [stdout] 131 | / value [INFO] [stdout] 132 | | .into_iter() [INFO] [stdout] 133 | | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] 134 | | .collect(), [INFO] [stdout] | |__________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/cco/src/value.rs:133:47 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|(k, v)| (k.to_string(), v.into())) [INFO] [stdout] | ------ ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cco` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cco` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "a6a30b74bb66379f5ca74e1c8746c5c79cea916ab3b0f4bbc84fdf33e1f231b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6a30b74bb66379f5ca74e1c8746c5c79cea916ab3b0f4bbc84fdf33e1f231b2", kill_on_drop: false }` [INFO] [stdout] a6a30b74bb66379f5ca74e1c8746c5c79cea916ab3b0f4bbc84fdf33e1f231b2