[INFO] cloning repository https://github.com/demostf/sync-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/demostf/sync-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdemostf%2Fsync-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdemostf%2Fsync-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 82e79ef01d4f011320906061b7acb3ca06179b2c [INFO] checking demostf/sync-rs/82e79ef01d4f011320906061b7acb3ca06179b2c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdemostf%2Fsync-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/demostf/sync-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/demostf/sync-rs [INFO] finished tweaking git repo https://github.com/demostf/sync-rs [INFO] tweaked toml for git repo https://github.com/demostf/sync-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/demostf/sync-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9da931828b461cce9efa89f230d885a9de693145e74c8b3bc0ddbf491daeb796 [INFO] running `Command { std: "docker" "start" "-a" "9da931828b461cce9efa89f230d885a9de693145e74c8b3bc0ddbf491daeb796", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9da931828b461cce9efa89f230d885a9de693145e74c8b3bc0ddbf491daeb796", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9da931828b461cce9efa89f230d885a9de693145e74c8b3bc0ddbf491daeb796", kill_on_drop: false }` [INFO] [stdout] 9da931828b461cce9efa89f230d885a9de693145e74c8b3bc0ddbf491daeb796 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bff5541eef74a754ccda67a63f6da583211a7fbba49d116ff3258e12499f520f [INFO] running `Command { std: "docker" "start" "-a" "bff5541eef74a754ccda67a63f6da583211a7fbba49d116ff3258e12499f520f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking block-padding v0.1.5 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking generic-array v0.12.4 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking sha-1 v0.8.2 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking portpicker v0.1.1 [INFO] [stderr] Checking parity-ws v0.11.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling enum_dispatch v0.3.12 [INFO] [stderr] Checking better-panic v0.3.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking websocket-codec v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking websocket-lite v0.5.2 [INFO] [stderr] Checking sync v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:150:11 [INFO] [stdout] | [INFO] [stdout] 145 | mut update_fn: F, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | match sessions.borrow_mut().get_mut(session_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 225 | let sessions: Rc>> = Rc::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | / listen(listen_address, |out| Server { [INFO] [stdout] 228 | | out: out.into(), [INFO] [stdout] 229 | | sessions: sessions.clone(), [INFO] [stdout] 230 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 227 | listen(listen_address, |out| Server { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | out: out.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:229:19 [INFO] [stdout] | [INFO] [stdout] 227 | listen(listen_address, |out| Server { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | out: out.into(), [INFO] [stdout] 229 | sessions: sessions.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 116 | fn from(sender: Sender) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Client::Sender(sender.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sync` (bin "sync") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:150:11 [INFO] [stdout] | [INFO] [stdout] 145 | mut update_fn: F, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | match sessions.borrow_mut().get_mut(session_name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 199 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | rx.recv().unwrap() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:205:18 [INFO] [stdout] | [INFO] [stdout] 204 | let ws = WebSocket::new(|out: parity_ws::Sender| Server { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | out: out.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 204 | let ws = WebSocket::new(|out: parity_ws::Sender| Server { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 205 | out: out.into(), [INFO] [stdout] 206 | sessions: sessions.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 225 | let sessions: Rc>> = Rc::default(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | [INFO] [stdout] 227 | / listen(listen_address, |out| Server { [INFO] [stdout] 228 | | out: out.into(), [INFO] [stdout] 229 | | sessions: sessions.clone(), [INFO] [stdout] 230 | | }) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 227 | listen(listen_address, |out| Server { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | out: out.into(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:229:19 [INFO] [stdout] | [INFO] [stdout] 227 | listen(listen_address, |out| Server { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | out: out.into(), [INFO] [stdout] 229 | sessions: sessions.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:117:24 [INFO] [stdout] | [INFO] [stdout] 116 | fn from(sender: Sender) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | Client::Sender(sender.into()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:78:28 [INFO] [stdout] | [INFO] [stdout] 78 | .map(|msg| serde_json::from_str::(msg).expect("invalid message")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sync` (bin "sync" test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "bff5541eef74a754ccda67a63f6da583211a7fbba49d116ff3258e12499f520f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bff5541eef74a754ccda67a63f6da583211a7fbba49d116ff3258e12499f520f", kill_on_drop: false }` [INFO] [stdout] bff5541eef74a754ccda67a63f6da583211a7fbba49d116ff3258e12499f520f