[INFO] cloning repository https://github.com/delta1024/git-home [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/delta1024/git-home" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdelta1024%2Fgit-home", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdelta1024%2Fgit-home'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 56b60282a8b0a4495ca014776aa937018dc0203d [INFO] checking delta1024/git-home/56b60282a8b0a4495ca014776aa937018dc0203d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdelta1024%2Fgit-home" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/delta1024/git-home on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/delta1024/git-home [INFO] finished tweaking git repo https://github.com/delta1024/git-home [INFO] tweaked toml for git repo https://github.com/delta1024/git-home written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/delta1024/git-home already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 465a63517a3e16054e4e1e94f7c5ab8dce1a4fe7070b72d210eef83b6130a178 [INFO] running `Command { std: "docker" "start" "-a" "465a63517a3e16054e4e1e94f7c5ab8dce1a4fe7070b72d210eef83b6130a178", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "465a63517a3e16054e4e1e94f7c5ab8dce1a4fe7070b72d210eef83b6130a178", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "465a63517a3e16054e4e1e94f7c5ab8dce1a4fe7070b72d210eef83b6130a178", kill_on_drop: false }` [INFO] [stdout] 465a63517a3e16054e4e1e94f7c5ab8dce1a4fe7070b72d210eef83b6130a178 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87dcd0f9cc674b9fc6d70fc660888e528f76e53ca0f7ae2216aec15a8d4bd48e [INFO] running `Command { std: "docker" "start" "-a" "87dcd0f9cc674b9fc6d70fc660888e528f76e53ca0f7ae2216aec15a8d4bd48e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking which v4.2.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking edit v0.1.4 [INFO] [stderr] Compiling openssl-sys v0.9.74 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling libssh2-sys v0.2.23 [INFO] [stderr] Compiling libgit2-sys v0.13.4+1.4.2 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking git2 v0.14.4 [INFO] [stderr] Checking git-home v0.1.1-alpha.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::env::Args` [INFO] [stdout] --> src/args/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use std::env::Args; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `print_add_help` and `print_commit_usage` [INFO] [stdout] --> src/args/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | use usage::{print_add_help, print_commit_usage}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env::Args` [INFO] [stdout] --> src/args/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | use std::env::Args; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `print_add_help` and `print_commit_usage` [INFO] [stdout] --> src/args/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | use usage::{print_add_help, print_commit_usage}; [INFO] [stdout] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/run.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | use std::{env, io::{self, Write, Read}, path::Path, process::{exit, Command, Stdio}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/run.rs:22:34 [INFO] [stdout] | [INFO] [stdout] 22 | use std::{env, io::{self, Write, Read}, path::Path, process::{exit, Command, Stdio}}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/run.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | use std::{env, io::{self, Write, Read}, path::Path, process::{exit, Command, Stdio}}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/run.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | use std::{env, io::{self, Write, Read}, path::Path, process::{exit, Command, Stdio}}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_commit_usage` is never used [INFO] [stdout] --> src/args/usage.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn print_commit_usage() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_add_help` is never used [INFO] [stdout] --> src/args/usage.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn print_add_help() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:213:8 [INFO] [stdout] | [INFO] [stdout] 182 | let sig = match repo.signature() { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(sig) => sig, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let mut index = match repo.index() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(index) => index, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let tree = match repo.find_tree(tree_id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Ok(id) => id, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok((sig, tree)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:224:8 [INFO] [stdout] | [INFO] [stdout] 217 | let (parent, _refrence) = match repo.revparse_ext("HEAD") { [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let (sig, tree) = gen_init_comimt_args(repo)?; [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok((parent, sig, tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:246:11 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn run_passthrough(prefix_args: Option>, args: Vec) -> io::Result<()> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut git = Command::new("git") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | match git.wait() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_commit_usage` is never used [INFO] [stdout] --> src/args/usage.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn print_commit_usage() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `print_add_help` is never used [INFO] [stdout] --> src/args/usage.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn print_add_help() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:213:8 [INFO] [stdout] | [INFO] [stdout] 182 | let sig = match repo.signature() { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Ok(sig) => sig, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let mut index = match repo.index() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | Ok(index) => index, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let tree = match repo.find_tree(tree_id) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Ok(id) => id, [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok((sig, tree)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:224:8 [INFO] [stdout] | [INFO] [stdout] 217 | let (parent, _refrence) = match repo.revparse_ext("HEAD") { [INFO] [stdout] | ------ --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | Ok(result) => result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let (sig, tree) = gen_init_comimt_args(repo)?; [INFO] [stdout] | --- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 223 | [INFO] [stdout] 224 | Ok((parent, sig, tree)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/run.rs:246:11 [INFO] [stdout] | [INFO] [stdout] 211 | pub fn run_passthrough(prefix_args: Option>, args: Vec) -> io::Result<()> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let mut git = Command::new("git") [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | match git.wait() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `git-home` (bin "git-home") due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `git-home` (bin "git-home" test) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "87dcd0f9cc674b9fc6d70fc660888e528f76e53ca0f7ae2216aec15a8d4bd48e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87dcd0f9cc674b9fc6d70fc660888e528f76e53ca0f7ae2216aec15a8d4bd48e", kill_on_drop: false }` [INFO] [stdout] 87dcd0f9cc674b9fc6d70fc660888e528f76e53ca0f7ae2216aec15a8d4bd48e