[INFO] cloning repository https://github.com/defstryker/rusic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/defstryker/rusic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdefstryker%2Frusic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdefstryker%2Frusic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5f53a512a85e760787515a1dcefb05823d8918d6 [INFO] checking defstryker/rusic/5f53a512a85e760787515a1dcefb05823d8918d6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdefstryker%2Frusic" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/defstryker/rusic on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/defstryker/rusic [INFO] finished tweaking git repo https://github.com/defstryker/rusic [INFO] tweaked toml for git repo https://github.com/defstryker/rusic written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/defstryker/rusic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cac90ecc7f2902281154ef4a39d15c2b4c92e0c18e9ef9d51bb5810b4a2b4c5c [INFO] running `Command { std: "docker" "start" "-a" "cac90ecc7f2902281154ef4a39d15c2b4c92e0c18e9ef9d51bb5810b4a2b4c5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cac90ecc7f2902281154ef4a39d15c2b4c92e0c18e9ef9d51bb5810b4a2b4c5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cac90ecc7f2902281154ef4a39d15c2b4c92e0c18e9ef9d51bb5810b4a2b4c5c", kill_on_drop: false }` [INFO] [stdout] cac90ecc7f2902281154ef4a39d15c2b4c92e0c18e9ef9d51bb5810b4a2b4c5c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ede3e6ee1711277299dde79ca5fc42a1be0d1e9c1d7ec1065e01727dfbce3b0 [INFO] running `Command { std: "docker" "start" "-a" "2ede3e6ee1711277299dde79ca5fc42a1be0d1e9c1d7ec1065e01727dfbce3b0", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling libc v0.2.59 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling strsim v0.7.0 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling gio v0.7.0 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling gdk-pixbuf v0.7.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling cairo-rs v0.7.1 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Compiling pango v0.7.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling atk v0.7.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling derive_builder v0.7.2 [INFO] [stderr] Compiling gdk v0.11.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling glib-sys v0.9.0 [INFO] [stderr] Compiling gobject-sys v0.9.0 [INFO] [stderr] Compiling gio-sys v0.9.0 [INFO] [stderr] Compiling pango-sys v0.9.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.9.0 [INFO] [stderr] Compiling cairo-sys-rs v0.9.0 [INFO] [stderr] Compiling atk-sys v0.9.0 [INFO] [stderr] Compiling gdk-sys v0.9.0 [INFO] [stderr] Compiling libpulse-sys v1.9.1 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling gtk-sys v0.9.0 [INFO] [stderr] Compiling libpulse-simple-sys v1.9.1 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking libc v0.1.12 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Compiling gtk v0.7.0 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Compiling simplemad_sys v0.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking libpulse-binding v2.11.1 [INFO] [stderr] Compiling miniz-sys v0.1.12 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking glib v0.8.1 [INFO] [stderr] Checking crossbeam v0.7.2 [INFO] [stderr] Checking flate2 v1.0.11 [INFO] [stderr] Checking libpulse-simple-binding v2.11.1 [INFO] [stderr] Checking simplemad v0.9.0 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Compiling darling_core v0.9.0 [INFO] [stderr] Compiling darling_macro v0.9.0 [INFO] [stderr] Compiling darling v0.9.0 [INFO] [stderr] Compiling derive_builder_core v0.5.0 [INFO] [stderr] Checking id3 v0.3.0 [INFO] [stderr] Checking rustic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/player.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Condvar` [INFO] [stdout] --> src/player.rs:4:22 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{Arc, Condvar, Mutex}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/toolbar.rs:45:57 [INFO] [stdout] | [INFO] [stdout] 45 | let next_button = make_button("gtk-media-next");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Path` [INFO] [stdout] --> src/player.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | use std::path::{Path, PathBuf}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Condvar` [INFO] [stdout] --> src/player.rs:4:22 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{Arc, Condvar, Mutex}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/toolbar.rs:45:57 [INFO] [stdout] | [INFO] [stdout] 45 | let next_button = make_button("gtk-media-next");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `gtk::prelude` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use gtk::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rate` [INFO] [stdout] --> src/player.rs:80:37 [INFO] [stdout] | [INFO] [stdout] 80 | ... let rate = source [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `gtk::prelude` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use gtk::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rate` [INFO] [stdout] --> src/player.rs:80:37 [INFO] [stdout] | [INFO] [stdout] 80 | ... let rate = source [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rate` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(mut data: R) -> Result, R> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut reader = simplemad::Decoder::decode(data).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(MP3Decoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | reader, [INFO] [stdout] 30 | | current_frame, [INFO] [stdout] 31 | | current_frame_channel: 0, [INFO] [stdout] 32 | | current_frame_sample_pos: 0, [INFO] [stdout] 33 | | current_time, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn compute_duration(mut data: R) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let decoder = simplemad::Decoder::decode_headers(data).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Some( [INFO] [stdout] 51 | / decoder [INFO] [stdout] 52 | | .filter_map(|frame| match frame { [INFO] [stdout] 53 | | Ok(frame) => Some(frame.duration), [INFO] [stdout] 54 | | Err(_) => None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn new(state: Arc>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let model = ListStore::new(&[ [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let treeview = TreeView::new_with_model(&model); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | player: Player::new(state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(mut data: R) -> Result, R> { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let mut reader = simplemad::Decoder::decode(data).unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok(MP3Decoder { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | reader, [INFO] [stdout] 30 | | current_frame, [INFO] [stdout] 31 | | current_frame_channel: 0, [INFO] [stdout] 32 | | current_frame_sample_pos: 0, [INFO] [stdout] 33 | | current_time, [INFO] [stdout] 34 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mp3.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn compute_duration(mut data: R) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let decoder = simplemad::Decoder::decode_headers(data).unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Some( [INFO] [stdout] 51 | / decoder [INFO] [stdout] 52 | | .filter_map(|frame| match frame { [INFO] [stdout] 53 | | Ok(frame) => Some(frame.duration), [INFO] [stdout] 54 | | Err(_) => None, [INFO] [stdout] 55 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playlist.rs:66:21 [INFO] [stdout] | [INFO] [stdout] 45 | pub(crate) fn new(state: Arc>) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let model = ListStore::new(&[ [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let treeview = TreeView::new_with_model(&model); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | player: Player::new(state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustic` (bin "rustic") due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustic` (bin "rustic" test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2ede3e6ee1711277299dde79ca5fc42a1be0d1e9c1d7ec1065e01727dfbce3b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ede3e6ee1711277299dde79ca5fc42a1be0d1e9c1d7ec1065e01727dfbce3b0", kill_on_drop: false }` [INFO] [stdout] 2ede3e6ee1711277299dde79ca5fc42a1be0d1e9c1d7ec1065e01727dfbce3b0