[INFO] updating cached repository https://github.com/decentninja/Cheatstrument [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 044ef2a5ff53f0dc71eca891365f7c6109dec5b5 [INFO] checking decentninja/Cheatstrument/044ef2a5ff53f0dc71eca891365f7c6109dec5b5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdecentninja%2FCheatstrument" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/decentninja/Cheatstrument on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/decentninja/Cheatstrument [INFO] finished tweaking git repo https://github.com/decentninja/Cheatstrument [INFO] tweaked toml for git repo https://github.com/decentninja/Cheatstrument written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/decentninja/Cheatstrument already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c281e2c80a27f581104cf1755b6517a2956b3b5762b090cf9e687c205fd7d73 [INFO] running `Command { std: "docker" "start" "-a" "0c281e2c80a27f581104cf1755b6517a2956b3b5762b090cf9e687c205fd7d73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c281e2c80a27f581104cf1755b6517a2956b3b5762b090cf9e687c205fd7d73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c281e2c80a27f581104cf1755b6517a2956b3b5762b090cf9e687c205fd7d73", kill_on_drop: false }` [INFO] [stdout] 0c281e2c80a27f581104cf1755b6517a2956b3b5762b090cf9e687c205fd7d73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20bb2f1025bd6095d307809c7720064cdec4158434166d01a4eaf537a3002352 [INFO] running `Command { std: "docker" "start" "-a" "20bb2f1025bd6095d307809c7720064cdec4158434166d01a4eaf537a3002352", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking portmidi v0.2.2 [INFO] [stderr] Checking cheatstrument v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::thread` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::thread; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | let context = try!(pm::PortMidi::new()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | let device = try!(context.device(1)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let output_port = try!(context.output_port(device, 1024)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:74:11 [INFO] [stdout] | [INFO] [stdout] 74 | midi: MidiWrapper [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 74 | midi: dyn MidiWrapper [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:25:23 [INFO] [stdout] | [INFO] [stdout] 25 | let context = try!(pm::PortMidi::new()); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:26:22 [INFO] [stdout] | [INFO] [stdout] 26 | let device = try!(context.device(1)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/main.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 27 | let output_port = try!(context.output_port(device, 1024)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:74:11 [INFO] [stdout] | [INFO] [stdout] 74 | midi: MidiWrapper [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 74 | midi: dyn MidiWrapper [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `MidiError` is never used [INFO] [stdout] --> src/main.rs:7:6 [INFO] [stdout] | [INFO] [stdout] 7 | enum MidiError { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `down`, `up`, and `get_down` are never used [INFO] [stdout] --> src/main.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 11 | trait MidiWrapper { [INFO] [stdout] | ----------- methods in this trait [INFO] [stdout] 12 | fn down(&mut self, note: u8, velocity: u8) -> Result<(), MidiError>; [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | fn up(&mut self, note: u8) -> Result<(), MidiError>; [INFO] [stdout] | ^^ [INFO] [stdout] 14 | fn get_down(&self) -> &HashSet; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PortMidiWrapper` is never constructed [INFO] [stdout] --> src/main.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | struct PortMidiWrapper { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `send` are never used [INFO] [stdout] --> src/main.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 23 | impl PortMidiWrapper { [INFO] [stdout] | -------------------- associated items in this implementation [INFO] [stdout] 24 | pub fn new() -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | fn send(&mut self, note: u8, velocity: u8, isdown: bool) -> Result<(), MidiError> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `midi` is never read [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct Cheatstrument { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 74 | midi: MidiWrapper [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 25 | let context = try!(pm::PortMidi::new()); [INFO] [stdout] | ------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let device = try!(context.device(1)); [INFO] [stdout] 27 | let output_port = try!(context.output_port(device, 1024)); [INFO] [stdout] | ----------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Ok(PortMidiWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | output_port: output_port, [INFO] [stdout] 30 | | channel: 1, [INFO] [stdout] 31 | | down: HashSet::new() [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cheatstrument` (bin "cheatstrument") due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/main.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | SendError(pm::Error) [INFO] [stdout] | --------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `MidiError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | SendError(()) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_down` is never used [INFO] [stdout] --> src/main.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 11 | trait MidiWrapper { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 14 | fn get_down(&self) -> &HashSet; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `midi` is never read [INFO] [stdout] --> src/main.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct Cheatstrument { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 74 | midi: MidiWrapper [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 25 | let context = try!(pm::PortMidi::new()); [INFO] [stdout] | ------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let device = try!(context.device(1)); [INFO] [stdout] 27 | let output_port = try!(context.output_port(device, 1024)); [INFO] [stdout] | ----------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Ok(PortMidiWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 29 | | output_port: output_port, [INFO] [stdout] 30 | | channel: 1, [INFO] [stdout] 31 | | down: HashSet::new() [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `cheatstrument` (bin "cheatstrument" test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "20bb2f1025bd6095d307809c7720064cdec4158434166d01a4eaf537a3002352", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20bb2f1025bd6095d307809c7720064cdec4158434166d01a4eaf537a3002352", kill_on_drop: false }` [INFO] [stdout] 20bb2f1025bd6095d307809c7720064cdec4158434166d01a4eaf537a3002352