[INFO] cloning repository https://github.com/ddimaria/rust-http-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ddimaria/rust-http-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddimaria%2Frust-http-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddimaria%2Frust-http-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5020ba7b2f8acaca7c45f2a0dddf03cc4cce582a [INFO] checking ddimaria/rust-http-server/5020ba7b2f8acaca7c45f2a0dddf03cc4cce582a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fddimaria%2Frust-http-server" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ddimaria/rust-http-server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ddimaria/rust-http-server [INFO] finished tweaking git repo https://github.com/ddimaria/rust-http-server [INFO] tweaked toml for git repo https://github.com/ddimaria/rust-http-server written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ddimaria/rust-http-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c0137f04faa0ba8ece5d3efef8eeec54c135cd7032f113f43e745263a8e31aa [INFO] running `Command { std: "docker" "start" "-a" "8c0137f04faa0ba8ece5d3efef8eeec54c135cd7032f113f43e745263a8e31aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c0137f04faa0ba8ece5d3efef8eeec54c135cd7032f113f43e745263a8e31aa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c0137f04faa0ba8ece5d3efef8eeec54c135cd7032f113f43e745263a8e31aa", kill_on_drop: false }` [INFO] [stdout] 8c0137f04faa0ba8ece5d3efef8eeec54c135cd7032f113f43e745263a8e31aa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24bed29a40890cae8a0f0d566b683f80fefaa2dfc33500def5cc91c6f44118fa [INFO] running `Command { std: "docker" "start" "-a" "24bed29a40890cae8a0f0d566b683f80fefaa2dfc33500def5cc91c6f44118fa", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling libc v0.2.66 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling memchr v2.3.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking regex-syntax v0.6.14 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Checking aho-corasick v0.7.8 [INFO] [stderr] Compiling backtrace-sys v0.1.32 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking flate2 v1.0.13 [INFO] [stderr] Checking backtrace v0.3.43 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Checking envy v0.4.1 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking dotenv v0.14.1 [INFO] [stderr] Checking rust-http-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/data.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn get(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn post(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:20:36 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn delete(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `items` [INFO] [stdout] --> src/request.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let items = query.to_string().split("&").for_each(|x| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_items` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn get(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:14:34 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn post(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/handlers.rs:20:36 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn delete(request: Request, data: Arc>>) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `uri`, `query`, `headers`, and `body` are never read [INFO] [stdout] --> src/request.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct Request { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 28 | pub method: Method, [INFO] [stdout] 29 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 30 | pub query: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 31 | pub headers: Headers, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 32 | pub body: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NotFound` is never constructed [INFO] [stdout] --> src/response.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum HttpStatusCode { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 13 | OK, [INFO] [stdout] 14 | NotFound, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpStatusCode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(mut stream: TcpStream) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | method, [INFO] [stdout] 71 | | uri, [INFO] [stdout] 72 | | query, [INFO] [stdout] ... | [INFO] [stdout] 75 | | stream: stream, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn new(receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | // Spawn the threads [INFO] [stdout] 79 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `items` [INFO] [stdout] --> src/request.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 127 | let items = query.to_string().split("&").for_each(|x| { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_items` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-http-server` (bin "rust-http-server") due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `uri`, `query`, `headers`, and `body` are never read [INFO] [stdout] --> src/request.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub struct Request { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 28 | pub method: Method, [INFO] [stdout] 29 | pub uri: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 30 | pub query: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 31 | pub headers: Headers, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 32 | pub body: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NotFound` is never constructed [INFO] [stdout] --> src/response.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub enum HttpStatusCode { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 13 | OK, [INFO] [stdout] 14 | NotFound, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpStatusCode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(mut stream: TcpStream) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(Request { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | method, [INFO] [stdout] 71 | | uri, [INFO] [stdout] 72 | | query, [INFO] [stdout] ... | [INFO] [stdout] 75 | | stream: stream, [INFO] [stdout] 76 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threadpool.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 77 | fn new(receiver: Arc>>) -> Worker { [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | // Spawn the threads [INFO] [stdout] 79 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-http-server` (bin "rust-http-server" test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "24bed29a40890cae8a0f0d566b683f80fefaa2dfc33500def5cc91c6f44118fa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24bed29a40890cae8a0f0d566b683f80fefaa2dfc33500def5cc91c6f44118fa", kill_on_drop: false }` [INFO] [stdout] 24bed29a40890cae8a0f0d566b683f80fefaa2dfc33500def5cc91c6f44118fa