[INFO] cloning repository https://github.com/dclamage/SudokuSolverRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dclamage/SudokuSolverRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdclamage%2FSudokuSolverRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdclamage%2FSudokuSolverRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 83984fe841dbe95147f248a1760b3e69e7470408 [INFO] checking dclamage/SudokuSolverRust/83984fe841dbe95147f248a1760b3e69e7470408 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdclamage%2FSudokuSolverRust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dclamage/SudokuSolverRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dclamage/SudokuSolverRust [INFO] finished tweaking git repo https://github.com/dclamage/SudokuSolverRust [INFO] tweaked toml for git repo https://github.com/dclamage/SudokuSolverRust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dclamage/SudokuSolverRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cb21d215b7c8901dde5a0c6c01ca4684ea07182f68a2c496ebb6c00c9367d662 [INFO] running `Command { std: "docker" "start" "-a" "cb21d215b7c8901dde5a0c6c01ca4684ea07182f68a2c496ebb6c00c9367d662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cb21d215b7c8901dde5a0c6c01ca4684ea07182f68a2c496ebb6c00c9367d662", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cb21d215b7c8901dde5a0c6c01ca4684ea07182f68a2c496ebb6c00c9367d662", kill_on_drop: false }` [INFO] [stdout] cb21d215b7c8901dde5a0c6c01ca4684ea07182f68a2c496ebb6c00c9367d662 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d6a5f082d1b4fa1908462b8a2e8a601960f581c8c2a844322035344d8541259 [INFO] running `Command { std: "docker" "start" "-a" "9d6a5f082d1b4fa1908462b8a2e8a601960f581c8c2a844322035344d8541259", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.83 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling tokio v1.21.1 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Compiling bumpalo v3.11.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.83 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking lz-str v0.1.0 (https://github.com/dclamage/lz-str-rs#ddd7a9ae) [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking unicode-normalization v0.1.21 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.32 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking sha1 v0.10.4 [INFO] [stderr] Checking headers v0.3.8 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking sudoku-solver-lib v0.1.0 (/opt/rustwide/workdir/sudoku-solver-lib) [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> sudoku-solver-lib/src/prelude.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use crate::logical_step::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the name `prelude` in the type namespace is first re-exported here [INFO] [stdout] ... [INFO] [stdout] 13 | pub use crate::solver::*; [INFO] [stdout] | ---------------- but the name `prelude` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous glob re-exports [INFO] [stdout] --> sudoku-solver-lib/src/prelude.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use crate::logical_step::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ the name `prelude` in the type namespace is first re-exported here [INFO] [stdout] ... [INFO] [stdout] 13 | pub use crate::solver::*; [INFO] [stdout] | ---------------- but the name `prelude` in the type namespace is also re-exported here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/elimination_list.rs:206:39 [INFO] [stdout] | [INFO] [stdout] 202 | fn from_iter(iter: I) -> EliminationList [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | EliminationList { candidates: iter.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/math.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | group: impl Iterator + Clone, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> Vec<(CandidateIndex, CandidateIndex)> { [INFO] [stdout] 105 | / group [INFO] [stdout] 106 | | .tuple_combinations() [INFO] [stdout] 107 | | .flat_map(move |(cell1, cell2)| { [INFO] [stdout] 108 | | (1..=cell1.size()).map(move |value| (cell1.candidate(value), cell2.candidate(value))) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/math.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | group: impl Iterator + Clone, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ) -> Vec<(CandidateIndex, CandidateIndex)> { [INFO] [stdout] 118 | / group [INFO] [stdout] 119 | | .tuple_combinations() [INFO] [stdout] 120 | | .flat_map(move |(cell1, cell2)| { [INFO] [stdout] 121 | | (1..=cell1.size()).flat_map(move |value1| { [INFO] [stdout] ... | [INFO] [stdout] 125 | | }) [INFO] [stdout] 126 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sudoku-solver-lib` (lib) due to 4 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/elimination_list.rs:206:39 [INFO] [stdout] | [INFO] [stdout] 202 | fn from_iter(iter: I) -> EliminationList [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | EliminationList { candidates: iter.into_iter().collect() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/math.rs:105:5 [INFO] [stdout] | [INFO] [stdout] 103 | group: impl Iterator + Clone, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | ) -> Vec<(CandidateIndex, CandidateIndex)> { [INFO] [stdout] 105 | / group [INFO] [stdout] 106 | | .tuple_combinations() [INFO] [stdout] 107 | | .flat_map(move |(cell1, cell2)| { [INFO] [stdout] 108 | | (1..=cell1.size()).map(move |value| (cell1.candidate(value), cell2.candidate(value))) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> sudoku-solver-lib/src/math.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 116 | group: impl Iterator + Clone, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ) -> Vec<(CandidateIndex, CandidateIndex)> { [INFO] [stdout] 118 | / group [INFO] [stdout] 119 | | .tuple_combinations() [INFO] [stdout] 120 | | .flat_map(move |(cell1, cell2)| { [INFO] [stdout] 121 | | (1..=cell1.size()).flat_map(move |value1| { [INFO] [stdout] ... | [INFO] [stdout] 125 | | }) [INFO] [stdout] 126 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sudoku-solver-lib` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9d6a5f082d1b4fa1908462b8a2e8a601960f581c8c2a844322035344d8541259", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d6a5f082d1b4fa1908462b8a2e8a601960f581c8c2a844322035344d8541259", kill_on_drop: false }` [INFO] [stdout] 9d6a5f082d1b4fa1908462b8a2e8a601960f581c8c2a844322035344d8541259