[INFO] cloning repository https://github.com/dcerjan/rusty-pokemon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dcerjan/rusty-pokemon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdcerjan%2Frusty-pokemon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdcerjan%2Frusty-pokemon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1529d043e512b11765490762c48133855783f17e [INFO] checking dcerjan/rusty-pokemon/1529d043e512b11765490762c48133855783f17e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdcerjan%2Frusty-pokemon" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dcerjan/rusty-pokemon on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dcerjan/rusty-pokemon [INFO] finished tweaking git repo https://github.com/dcerjan/rusty-pokemon [INFO] tweaked toml for git repo https://github.com/dcerjan/rusty-pokemon written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dcerjan/rusty-pokemon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 72fa9a5395226e2818143b2f002e772856d47e83d0935e99efb63d76c6c38430 [INFO] running `Command { std: "docker" "start" "-a" "72fa9a5395226e2818143b2f002e772856d47e83d0935e99efb63d76c6c38430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "72fa9a5395226e2818143b2f002e772856d47e83d0935e99efb63d76c6c38430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72fa9a5395226e2818143b2f002e772856d47e83d0935e99efb63d76c6c38430", kill_on_drop: false }` [INFO] [stdout] 72fa9a5395226e2818143b2f002e772856d47e83d0935e99efb63d76c6c38430 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 41c36e09d9fc5f166504a10db14a88b76fd2e56e00c632619943ec5570b82306 [INFO] running `Command { std: "docker" "start" "-a" "41c36e09d9fc5f166504a10db14a88b76fd2e56e00c632619943ec5570b82306", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.83 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling bumpalo v3.11.0 [INFO] [stderr] Compiling once_cell v1.14.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling wasm-bindgen v0.2.83 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Checking scoped-tls-hkt v0.1.2 [INFO] [stderr] Checking anymap2 v0.13.0 [INFO] [stderr] Checking route-recognizer v0.3.1 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.83 [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling pin-project-internal v1.0.12 [INFO] [stderr] Compiling yew-macro v0.19.3 [INFO] [stderr] Compiling yew-router-macro v0.16.0 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.83 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.83 [INFO] [stderr] Checking pin-project v1.0.12 [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking js-sys v0.3.60 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking web-sys v0.3.60 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.33 [INFO] [stderr] Checking gloo-timers v0.2.4 [INFO] [stderr] Checking serde-wasm-bindgen v0.3.1 [INFO] [stderr] Checking gloo-utils v0.1.5 [INFO] [stderr] Checking gloo-events v0.1.2 [INFO] [stderr] Checking gloo-dialogs v0.1.1 [INFO] [stderr] Checking gloo-render v0.1.1 [INFO] [stderr] Checking gloo-console v0.2.3 [INFO] [stderr] Checking gloo-storage v0.2.2 [INFO] [stderr] Checking gloo-net v0.2.4 [INFO] [stderr] Checking gloo-file v0.2.3 [INFO] [stderr] Checking gloo-history v0.1.0 [INFO] [stderr] Checking gloo-worker v0.2.1 [INFO] [stderr] Checking gloo v0.4.2 [INFO] [stderr] Checking yew v0.19.3 [INFO] [stderr] Checking gloo v0.8.0 [INFO] [stderr] Checking yew-router v0.16.0 [INFO] [stderr] Checking webthing-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `error` and `page` are never read [INFO] [stdout] --> src/hooks/pokemon.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct UsePaginatedPokemonHandle { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 8 | pub loading: UseStateHandle, [INFO] [stdout] 9 | pub error: UseStateHandle>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 10 | pub pokemon: UseStateHandle>, [INFO] [stdout] 11 | pub page: UseStateHandle, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsePaginatedPokemonHandle` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `error` is never read [INFO] [stdout] --> src/hooks/pokemon.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 69 | pub struct UsePokemonHandle { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 70 | pub loading: UseStateHandle, [INFO] [stdout] 71 | pub error: UseStateHandle>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsePokemonHandle` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/storage.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn write(key: String, value: T) -> Result<(), String> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let ls = gloo::storage::LocalStorage::raw(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | match ls.set_item( [INFO] [stdout] | _______________^ [INFO] [stdout] 11 | | key.as_str(), [INFO] [stdout] 12 | | serde_json::to_string(&value).unwrap().as_str(), [INFO] [stdout] 13 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hooks/pokemon.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 34 | let loading = loading.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let error = error.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let pokemon = pokemon.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let page_clone = page.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | use_effect_with_deps( [INFO] [stdout] 39 | / move |_| { [INFO] [stdout] 40 | | loading.set(true); [INFO] [stdout] 41 | | wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 42 | | let fetched = [INFO] [stdout] ... | [INFO] [stdout] 52 | | || () [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hooks/pokemon.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 81 | let loading = loading.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let error = error.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let pokemon = pokemon.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / move |_| { [INFO] [stdout] 89 | | loading.set(true); [INFO] [stdout] 90 | | wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 91 | | let fetched = PokeApi::fetch_pokemon_by_name(name_for_fetch).await; [INFO] [stdout] ... | [INFO] [stdout] 107 | | || () [INFO] [stdout] 108 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webthing-client` (bin "webthing-client" test) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `error` and `page` are never read [INFO] [stdout] --> src/hooks/pokemon.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct UsePaginatedPokemonHandle { [INFO] [stdout] | ------------------------- fields in this struct [INFO] [stdout] 8 | pub loading: UseStateHandle, [INFO] [stdout] 9 | pub error: UseStateHandle>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 10 | pub pokemon: UseStateHandle>, [INFO] [stdout] 11 | pub page: UseStateHandle, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsePaginatedPokemonHandle` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `error` is never read [INFO] [stdout] --> src/hooks/pokemon.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 69 | pub struct UsePokemonHandle { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] 70 | pub loading: UseStateHandle, [INFO] [stdout] 71 | pub error: UseStateHandle>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `UsePokemonHandle` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/storage.rs:10:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn write(key: String, value: T) -> Result<(), String> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 8 | let ls = gloo::storage::LocalStorage::raw(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | [INFO] [stdout] 10 | match ls.set_item( [INFO] [stdout] | _______________^ [INFO] [stdout] 11 | | key.as_str(), [INFO] [stdout] 12 | | serde_json::to_string(&value).unwrap().as_str(), [INFO] [stdout] 13 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hooks/pokemon.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 34 | let loading = loading.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let error = error.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let pokemon = pokemon.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let page_clone = page.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | use_effect_with_deps( [INFO] [stdout] 39 | / move |_| { [INFO] [stdout] 40 | | loading.set(true); [INFO] [stdout] 41 | | wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 42 | | let fetched = [INFO] [stdout] ... | [INFO] [stdout] 52 | | || () [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hooks/pokemon.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 81 | let loading = loading.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let error = error.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let pokemon = pokemon.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / move |_| { [INFO] [stdout] 89 | | loading.set(true); [INFO] [stdout] 90 | | wasm_bindgen_futures::spawn_local(async move { [INFO] [stdout] 91 | | let fetched = PokeApi::fetch_pokemon_by_name(name_for_fetch).await; [INFO] [stdout] ... | [INFO] [stdout] 107 | | || () [INFO] [stdout] 108 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `webthing-client` (bin "webthing-client") due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "41c36e09d9fc5f166504a10db14a88b76fd2e56e00c632619943ec5570b82306", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41c36e09d9fc5f166504a10db14a88b76fd2e56e00c632619943ec5570b82306", kill_on_drop: false }` [INFO] [stdout] 41c36e09d9fc5f166504a10db14a88b76fd2e56e00c632619943ec5570b82306