[INFO] cloning repository https://github.com/dbidwell94/parse_logs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dbidwell94/parse_logs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbidwell94%2Fparse_logs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbidwell94%2Fparse_logs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a25b66d3fc193a76dd981eb70c3ba5bb9d940776 [INFO] checking dbidwell94/parse_logs/a25b66d3fc193a76dd981eb70c3ba5bb9d940776 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdbidwell94%2Fparse_logs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dbidwell94/parse_logs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dbidwell94/parse_logs [INFO] finished tweaking git repo https://github.com/dbidwell94/parse_logs [INFO] tweaked toml for git repo https://github.com/dbidwell94/parse_logs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dbidwell94/parse_logs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 251bcfe3d530fc7eefe8c9d40d6fcf36727ec81cbeedaea34964681f0171dfa7 [INFO] running `Command { std: "docker" "start" "-a" "251bcfe3d530fc7eefe8c9d40d6fcf36727ec81cbeedaea34964681f0171dfa7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "251bcfe3d530fc7eefe8c9d40d6fcf36727ec81cbeedaea34964681f0171dfa7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "251bcfe3d530fc7eefe8c9d40d6fcf36727ec81cbeedaea34964681f0171dfa7", kill_on_drop: false }` [INFO] [stdout] 251bcfe3d530fc7eefe8c9d40d6fcf36727ec81cbeedaea34964681f0171dfa7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0b3724d45b5419367ef99a4e06ef6a6e492167327959bb6ce1bc57947808c800 [INFO] running `Command { std: "docker" "start" "-a" "0b3724d45b5419367ef99a4e06ef6a6e492167327959bb6ce1bc57947808c800", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling tokio v1.20.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling anyhow v1.0.63 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking iana-time-zone v0.1.47 [INFO] [stderr] Checking libloading v0.7.3 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking filetime v0.2.17 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking notify v5.0.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling thiserror-impl v1.0.33 [INFO] [stderr] Checking thiserror v1.0.33 [INFO] [stderr] Checking serde_yaml v0.9.10 [INFO] [stderr] Checking parse_logs_v2 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constant `NGINX_ACCESS_DATABASE_LOCATION` is never used [INFO] [stdout] --> src/nginx_plugin/lib.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const NGINX_ACCESS_DATABASE_LOCATION: &'static str = ""; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/nginx_plugin/nginx.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct NginxLog { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | ip_address: IpAddr, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 23 | date_time: DateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 24 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | status: StatusCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 26 | http_method: Method, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 27 | bytes_sent: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 28 | user_agent: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 29 | http_version: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NginxLog` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nginx_plugin/nginx.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 42 | let http_method: Method; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | bytes_sent, [INFO] [stdout] 94 | | status, [INFO] [stdout] 95 | | http_version, [INFO] [stdout] ... | [INFO] [stdout] 100 | | user_agent, [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse_logs_v2` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `NGINX_ACCESS_DATABASE_LOCATION` is never used [INFO] [stdout] --> src/nginx_plugin/lib.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const NGINX_ACCESS_DATABASE_LOCATION: &'static str = ""; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/nginx_plugin/nginx.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct NginxLog { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | ip_address: IpAddr, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 23 | date_time: DateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 24 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | status: StatusCode, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 26 | http_method: Method, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 27 | bytes_sent: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 28 | user_agent: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 29 | http_version: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NginxLog` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nginx_plugin/nginx.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 42 | let http_method: Method; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | bytes_sent, [INFO] [stdout] 94 | | status, [INFO] [stdout] 95 | | http_version, [INFO] [stdout] ... | [INFO] [stdout] 100 | | user_agent, [INFO] [stdout] 101 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse_logs_v2` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/main.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 152 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let watcher = RecommendedWatcher::new(tx, notify::Config::default())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | Ok((rx, watcher)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/plugin.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 33 | let lib: Library; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | plugin_name, [INFO] [stdout] 49 | | plugin_library: lib, [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse_logs_v2` (bin "parse_engine" test) due to 3 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/main.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 152 | let (tx, rx) = std::sync::mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | [INFO] [stdout] 154 | let watcher = RecommendedWatcher::new(tx, notify::Config::default())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | Ok((rx, watcher)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engine/plugin.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 33 | let lib: Library; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | plugin_name, [INFO] [stdout] 49 | | plugin_library: lib, [INFO] [stdout] 50 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `parse_logs_v2` (bin "parse_engine") due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "0b3724d45b5419367ef99a4e06ef6a6e492167327959bb6ce1bc57947808c800", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0b3724d45b5419367ef99a4e06ef6a6e492167327959bb6ce1bc57947808c800", kill_on_drop: false }` [INFO] [stdout] 0b3724d45b5419367ef99a4e06ef6a6e492167327959bb6ce1bc57947808c800