[INFO] cloning repository https://github.com/daylightwarbler/vcg-auction [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daylightwarbler/vcg-auction" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaylightwarbler%2Fvcg-auction", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaylightwarbler%2Fvcg-auction'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff53a80f26f19c4fde7d82fca39b0ff058cd647c [INFO] checking daylightwarbler/vcg-auction/ff53a80f26f19c4fde7d82fca39b0ff058cd647c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaylightwarbler%2Fvcg-auction" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/daylightwarbler/vcg-auction on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/daylightwarbler/vcg-auction [INFO] finished tweaking git repo https://github.com/daylightwarbler/vcg-auction [INFO] tweaked toml for git repo https://github.com/daylightwarbler/vcg-auction written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/daylightwarbler/vcg-auction already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69feb6d0c7ea8a7b11d315e8e7f2db6f0b164aa1d2ee8ea4cf6d94dbc764c077 [INFO] running `Command { std: "docker" "start" "-a" "69feb6d0c7ea8a7b11d315e8e7f2db6f0b164aa1d2ee8ea4cf6d94dbc764c077", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69feb6d0c7ea8a7b11d315e8e7f2db6f0b164aa1d2ee8ea4cf6d94dbc764c077", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69feb6d0c7ea8a7b11d315e8e7f2db6f0b164aa1d2ee8ea4cf6d94dbc764c077", kill_on_drop: false }` [INFO] [stdout] 69feb6d0c7ea8a7b11d315e8e7f2db6f0b164aa1d2ee8ea4cf6d94dbc764c077 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b500619cb9d34bc74ec726e0bc1a43ae0a010f4a73ef39a289a28d058f9f824 [INFO] running `Command { std: "docker" "start" "-a" "4b500619cb9d34bc74ec726e0bc1a43ae0a010f4a73ef39a289a28d058f9f824", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking vcg-auction v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:68:10 [INFO] [stdout] | [INFO] [stdout] 55 | tiebreaker: impl FnOnce(&[&Vec<&B>]) -> usize, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let scored_bid_sets = score_bid_sets(valid_bid_sets); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let payments = calculate_payments(winning_bid_set, &scored_bid_sets); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Some(AuctionResult { [INFO] [stdout] | __________^ [INFO] [stdout] 69 | | winning_bids: winning_bid_set.1.clone(), [INFO] [stdout] 70 | | payments, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:111:40 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|item| (&item.0, &item.1, B::Quantity::zero())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | .any(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:167:50 [INFO] [stdout] | [INFO] [stdout] 167 | .any(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:179:25 [INFO] [stdout] | [INFO] [stdout] 179 | .filter(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:179:45 [INFO] [stdout] | [INFO] [stdout] 179 | .filter(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcg-auction` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:68:10 [INFO] [stdout] | [INFO] [stdout] 55 | tiebreaker: impl FnOnce(&[&Vec<&B>]) -> usize, [INFO] [stdout] | --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let scored_bid_sets = score_bid_sets(valid_bid_sets); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let payments = calculate_payments(winning_bid_set, &scored_bid_sets); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Some(AuctionResult { [INFO] [stdout] | __________^ [INFO] [stdout] 69 | | winning_bids: winning_bid_set.1.clone(), [INFO] [stdout] 70 | | payments, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:111:40 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|item| (&item.0, &item.1, B::Quantity::zero())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:167:30 [INFO] [stdout] | [INFO] [stdout] 167 | .any(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:167:50 [INFO] [stdout] | [INFO] [stdout] 167 | .any(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:179:25 [INFO] [stdout] | [INFO] [stdout] 179 | .filter(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vcg.rs:179:45 [INFO] [stdout] | [INFO] [stdout] 179 | .filter(|b| *b.bidder_name() == *winning_bid.bidder_name()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vcg-auction` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "4b500619cb9d34bc74ec726e0bc1a43ae0a010f4a73ef39a289a28d058f9f824", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b500619cb9d34bc74ec726e0bc1a43ae0a010f4a73ef39a289a28d058f9f824", kill_on_drop: false }` [INFO] [stdout] 4b500619cb9d34bc74ec726e0bc1a43ae0a010f4a73ef39a289a28d058f9f824