[INFO] cloning repository https://github.com/davidneumann/rust-glyph-recog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/davidneumann/rust-glyph-recog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidneumann%2Frust-glyph-recog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidneumann%2Frust-glyph-recog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] deb8adf86c26494330af38b4e02a11d7495ed88b [INFO] checking davidneumann/rust-glyph-recog/deb8adf86c26494330af38b4e02a11d7495ed88b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidneumann%2Frust-glyph-recog" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/davidneumann/rust-glyph-recog on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/davidneumann/rust-glyph-recog [INFO] finished tweaking git repo https://github.com/davidneumann/rust-glyph-recog [INFO] tweaked toml for git repo https://github.com/davidneumann/rust-glyph-recog written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/davidneumann/rust-glyph-recog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53562bf1088182f139cf3dfe380434f39cc68a13757221a9b3bdab97f6ffb7b5 [INFO] running `Command { std: "docker" "start" "-a" "53562bf1088182f139cf3dfe380434f39cc68a13757221a9b3bdab97f6ffb7b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53562bf1088182f139cf3dfe380434f39cc68a13757221a9b3bdab97f6ffb7b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53562bf1088182f139cf3dfe380434f39cc68a13757221a9b3bdab97f6ffb7b5", kill_on_drop: false }` [INFO] [stdout] 53562bf1088182f139cf3dfe380434f39cc68a13757221a9b3bdab97f6ffb7b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6cc8c3c6006773917d0e4c9a8107eafef605637eeff63b2679f16e216dced0d [INFO] running `Command { std: "docker" "start" "-a" "e6cc8c3c6006773917d0e4c9a8107eafef605637eeff63b2679f16e216dced0d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking trees v0.4.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking rust-glyph-recog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] 144 + ray.l2r[y as usize] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:144:61 [INFO] [stdout] | [INFO] [stdout] 144 | ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] 144 + ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[y as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] 145 + ray.r2l[y as usize] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:145:73 [INFO] [stdout] | [INFO] [stdout] 145 | ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] 145 + ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[y as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] 146 + ray.t2b[x as usize] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:146:61 [INFO] [stdout] | [INFO] [stdout] 146 | ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] 146 + ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[x as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] 147 + ray.b2t[x as usize] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:147:74 [INFO] [stdout] | [INFO] [stdout] 147 | ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] 147 + ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[x as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] 148 + if x < width / 2 { ray.m2l[y as usize] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:148:94 [INFO] [stdout] | [INFO] [stdout] 148 | if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] 148 + if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[y as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:149:47 [INFO] [stdout] | [INFO] [stdout] 149 | if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 - if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] 149 + if x >= width / 2 { ray.m2r[y as usize] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:149:95 [INFO] [stdout] | [INFO] [stdout] 149 | if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 - if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] 149 + if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[y as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:150:46 [INFO] [stdout] | [INFO] [stdout] 150 | if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] 150 + if y < height / 2 { ray.m2t[x as usize] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:150:95 [INFO] [stdout] | [INFO] [stdout] 150 | if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] 150 + if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[x as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:151:47 [INFO] [stdout] | [INFO] [stdout] 151 | if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] 151 + if y >= height / 2 { ray.m2b[x as usize] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:151:96 [INFO] [stdout] | [INFO] [stdout] 151 | if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] 151 + if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[x as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:269:52 [INFO] [stdout] | [INFO] [stdout] 269 | if x < self.width - 1 && self.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 269 - if x < self.width - 1 && self.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] 269 + if x < self.width - 1 && self.l2r[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:270:97 [INFO] [stdout] | [INFO] [stdout] 270 | else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 270 + else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:271:52 [INFO] [stdout] | [INFO] [stdout] 271 | else if y < height - 1 && self.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - else if y < height - 1 && self.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] 271 + else if y < height - 1 && self.t2b[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:272:43 [INFO] [stdout] | [INFO] [stdout] 272 | else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 272 + else if y > 0 && self.b2t[x as usize] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:272:91 [INFO] [stdout] | [INFO] [stdout] 272 | else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 272 + else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:273:60 [INFO] [stdout] | [INFO] [stdout] 273 | else if x > 0 && self.width / 2 - self.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - else if x > 0 && self.width / 2 - self.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 273 + else if x > 0 && self.width / 2 - self.m2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:274:43 [INFO] [stdout] | [INFO] [stdout] 274 | else if x > 0 && self.m2r[(y as usize)] + self.width / 2 == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 274 - else if x > 0 && self.m2r[(y as usize)] + self.width / 2 == x { print!("X"); } [INFO] [stdout] 274 + else if x > 0 && self.m2r[y as usize] + self.width / 2 == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:275:56 [INFO] [stdout] | [INFO] [stdout] 275 | else if y > 0 && height / 2 - self.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 275 - else if y > 0 && height / 2 - self.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 275 + else if y > 0 && height / 2 - self.m2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:276:52 [INFO] [stdout] | [INFO] [stdout] 276 | else if y < height - 1 && self.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 276 - else if y < height - 1 && self.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] 276 + else if y < height - 1 && self.m2b[x as usize] + height / 2 == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | if x < rays.width - 1 && rays.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 18 - if x < rays.width - 1 && rays.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] 18 + if x < rays.width - 1 && rays.l2r[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:19:93 [INFO] [stdout] | [INFO] [stdout] 19 | else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 19 + else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:20:48 [INFO] [stdout] | [INFO] [stdout] 20 | else if y < height - 1 && rays.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - else if y < height - 1 && rays.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] 20 + else if y < height - 1 && rays.t2b[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:21:39 [INFO] [stdout] | [INFO] [stdout] 21 | else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 21 + else if y > 0 && rays.b2t[x as usize] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:21:87 [INFO] [stdout] | [INFO] [stdout] 21 | else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 21 + else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:22:56 [INFO] [stdout] | [INFO] [stdout] 22 | else if x > 0 && rays.width / 2 - rays.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - else if x > 0 && rays.width / 2 - rays.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 22 + else if x > 0 && rays.width / 2 - rays.m2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | else if x > 0 && rays.m2r[(y as usize)] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - else if x > 0 && rays.m2r[(y as usize)] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] 23 + else if x > 0 && rays.m2r[y as usize] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:24:52 [INFO] [stdout] | [INFO] [stdout] 24 | else if y > 0 && height / 2 - rays.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - else if y > 0 && height / 2 - rays.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 24 + else if y > 0 && height / 2 - rays.m2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:25:48 [INFO] [stdout] | [INFO] [stdout] 25 | else if y < height - 1 && rays.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - else if y < height - 1 && rays.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] 25 + else if y < height - 1 && rays.m2b[x as usize] + height / 2 == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:144:25 [INFO] [stdout] | [INFO] [stdout] 144 | ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] 144 + ray.l2r[y as usize] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:144:61 [INFO] [stdout] | [INFO] [stdout] 144 | ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 144 - ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[(y as usize)]); [INFO] [stdout] 144 + ray.l2r[(y as usize)] = cmp::min(x, ray.l2r[y as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] 145 + ray.r2l[y as usize] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:145:73 [INFO] [stdout] | [INFO] [stdout] 145 | ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[(y as usize)]); [INFO] [stdout] 145 + ray.r2l[(y as usize)] = cmp::min(width - x - 1, ray.r2l[y as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:146:25 [INFO] [stdout] | [INFO] [stdout] 146 | ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] 146 + ray.t2b[x as usize] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:146:61 [INFO] [stdout] | [INFO] [stdout] 146 | ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 146 - ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[(x as usize)]); [INFO] [stdout] 146 + ray.t2b[(x as usize)] = cmp::min(y, ray.t2b[x as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] 147 + ray.b2t[x as usize] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:147:74 [INFO] [stdout] | [INFO] [stdout] 147 | ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[(x as usize)]); [INFO] [stdout] 147 + ray.b2t[(x as usize)] = cmp::min(height - y - 1, ray.b2t[x as usize]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:148:46 [INFO] [stdout] | [INFO] [stdout] 148 | if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] 148 + if x < width / 2 { ray.m2l[y as usize] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:148:94 [INFO] [stdout] | [INFO] [stdout] 148 | if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 148 - if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[(y as usize)]); } [INFO] [stdout] 148 + if x < width / 2 { ray.m2l[(y as usize)] = cmp::min(width / 2 - x, ray.m2l[y as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:149:47 [INFO] [stdout] | [INFO] [stdout] 149 | if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 - if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] 149 + if x >= width / 2 { ray.m2r[y as usize] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:149:95 [INFO] [stdout] | [INFO] [stdout] 149 | if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 149 - if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[(y as usize)]); } [INFO] [stdout] 149 + if x >= width / 2 { ray.m2r[(y as usize)] = cmp::min(x - width / 2, ray.m2r[y as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:150:46 [INFO] [stdout] | [INFO] [stdout] 150 | if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] 150 + if y < height / 2 { ray.m2t[x as usize] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:150:95 [INFO] [stdout] | [INFO] [stdout] 150 | if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 150 - if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[(x as usize)]); } [INFO] [stdout] 150 + if y < height / 2 { ray.m2t[(x as usize)] = cmp::min(height / 2 - y, ray.m2t[x as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:151:47 [INFO] [stdout] | [INFO] [stdout] 151 | if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] 151 + if y >= height / 2 { ray.m2b[x as usize] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:151:96 [INFO] [stdout] | [INFO] [stdout] 151 | if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 151 - if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[(x as usize)]); } [INFO] [stdout] 151 + if y >= height / 2 { ray.m2b[(x as usize)] = cmp::min(y - height / 2, ray.m2b[x as usize]); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:269:52 [INFO] [stdout] | [INFO] [stdout] 269 | if x < self.width - 1 && self.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 269 - if x < self.width - 1 && self.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] 269 + if x < self.width - 1 && self.l2r[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:270:97 [INFO] [stdout] | [INFO] [stdout] 270 | else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 270 - else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 270 + else if x > 0 && self.r2l[y as usize] < self.width && self.width - 1 - self.r2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:271:52 [INFO] [stdout] | [INFO] [stdout] 271 | else if y < height - 1 && self.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 271 - else if y < height - 1 && self.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] 271 + else if y < height - 1 && self.t2b[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:272:43 [INFO] [stdout] | [INFO] [stdout] 272 | else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 272 + else if y > 0 && self.b2t[x as usize] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:272:91 [INFO] [stdout] | [INFO] [stdout] 272 | else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 272 - else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 272 + else if y > 0 && self.b2t[(x as usize)] < height && height - 1 - self.b2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:273:60 [INFO] [stdout] | [INFO] [stdout] 273 | else if x > 0 && self.width / 2 - self.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 273 - else if x > 0 && self.width / 2 - self.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 273 + else if x > 0 && self.width / 2 - self.m2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:274:43 [INFO] [stdout] | [INFO] [stdout] 274 | else if x > 0 && self.m2r[(y as usize)] + self.width / 2 == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 274 - else if x > 0 && self.m2r[(y as usize)] + self.width / 2 == x { print!("X"); } [INFO] [stdout] 274 + else if x > 0 && self.m2r[y as usize] + self.width / 2 == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:275:56 [INFO] [stdout] | [INFO] [stdout] 275 | else if y > 0 && height / 2 - self.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 275 - else if y > 0 && height / 2 - self.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 275 + else if y > 0 && height / 2 - self.m2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/glyph_rays.rs:276:52 [INFO] [stdout] | [INFO] [stdout] 276 | else if y < height - 1 && self.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 276 - else if y < height - 1 && self.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] 276 + else if y < height - 1 && self.m2b[x as usize] + height / 2 == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:18:48 [INFO] [stdout] | [INFO] [stdout] 18 | if x < rays.width - 1 && rays.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 18 - if x < rays.width - 1 && rays.l2r[(y as usize)] == x { print!("X"); } [INFO] [stdout] 18 + if x < rays.width - 1 && rays.l2r[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:19:93 [INFO] [stdout] | [INFO] [stdout] 19 | else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 19 - else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 19 + else if x > 0 && rays.r2l[y as usize] < rays.width && rays.width - 1 - rays.r2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:20:48 [INFO] [stdout] | [INFO] [stdout] 20 | else if y < height - 1 && rays.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 20 - else if y < height - 1 && rays.t2b[(x as usize)] == y { print!("X"); } [INFO] [stdout] 20 + else if y < height - 1 && rays.t2b[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:21:39 [INFO] [stdout] | [INFO] [stdout] 21 | else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 21 + else if y > 0 && rays.b2t[x as usize] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:21:87 [INFO] [stdout] | [INFO] [stdout] 21 | else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 21 - else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 21 + else if y > 0 && rays.b2t[(x as usize)] < height && height - 1 - rays.b2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:22:56 [INFO] [stdout] | [INFO] [stdout] 22 | else if x > 0 && rays.width / 2 - rays.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 22 - else if x > 0 && rays.width / 2 - rays.m2l[(y as usize)] == x { print!("X"); } [INFO] [stdout] 22 + else if x > 0 && rays.width / 2 - rays.m2l[y as usize] == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | else if x > 0 && rays.m2r[(y as usize)] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 23 - else if x > 0 && rays.m2r[(y as usize)] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] 23 + else if x > 0 && rays.m2r[y as usize] + rays.width / 2 == x { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:24:52 [INFO] [stdout] | [INFO] [stdout] 24 | else if y > 0 && height / 2 - rays.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 24 - else if y > 0 && height / 2 - rays.m2t[(x as usize)] == y { print!("X"); } [INFO] [stdout] 24 + else if y > 0 && height / 2 - rays.m2t[x as usize] == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/diagnostics.rs:25:48 [INFO] [stdout] | [INFO] [stdout] 25 | else if y < height - 1 && rays.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 25 - else if y < height - 1 && rays.m2b[(x as usize)] + height / 2 == y { print!("X"); } [INFO] [stdout] 25 + else if y < height - 1 && rays.m2b[x as usize] + height / 2 == y { print!("X"); } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 34 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:125:22 [INFO] [stdout] | [INFO] [stdout] 125 | .map(|x| x.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 34 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-glyph-recog` (lib test) due to 2 previous errors; 34 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e6cc8c3c6006773917d0e4c9a8107eafef605637eeff63b2679f16e216dced0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6cc8c3c6006773917d0e4c9a8107eafef605637eeff63b2679f16e216dced0d", kill_on_drop: false }` [INFO] [stdout] e6cc8c3c6006773917d0e4c9a8107eafef605637eeff63b2679f16e216dced0d