[INFO] cloning repository https://github.com/davidko/stk500-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/davidko/stk500-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidko%2Fstk500-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidko%2Fstk500-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dce56fa4ab7a7ce71a050d800355b2d63342daaf [INFO] checking davidko/stk500-rs/dce56fa4ab7a7ce71a050d800355b2d63342daaf against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavidko%2Fstk500-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/davidko/stk500-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/davidko/stk500-rs [INFO] finished tweaking git repo https://github.com/davidko/stk500-rs [INFO] tweaked toml for git repo https://github.com/davidko/stk500-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/davidko/stk500-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating stk500 v0.1.1 (/workspace/builds/worker-1-tc2/source) -> v0.1.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5724ca15b0e2eb1d013ba04869cc8765d025192de87adb57f53fd891b334998 [INFO] running `Command { std: "docker" "start" "-a" "b5724ca15b0e2eb1d013ba04869cc8765d025192de87adb57f53fd891b334998", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5724ca15b0e2eb1d013ba04869cc8765d025192de87adb57f53fd891b334998", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5724ca15b0e2eb1d013ba04869cc8765d025192de87adb57f53fd891b334998", kill_on_drop: false }` [INFO] [stdout] b5724ca15b0e2eb1d013ba04869cc8765d025192de87adb57f53fd891b334998 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 89bd73fdaf594ae747160715c8340251588bc55a031f72bb880cbe951ce321e9 [INFO] running `Command { std: "docker" "start" "-a" "89bd73fdaf594ae747160715c8340251588bc55a031f72bb880cbe951ce321e9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking futures v0.1.21 [INFO] [stderr] Checking byteorder v1.2.2 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Checking slab v0.4.0 [INFO] [stderr] Checking nodrop v0.1.12 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling pkg-config v0.3.9 [INFO] [stderr] Checking scoped-tls v0.1.1 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking smallvec v0.2.1 [INFO] [stderr] Checking take v0.1.0 [INFO] [stderr] Checking arrayvec v0.4.7 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking crossbeam-utils v0.3.2 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.3.0 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking rand v0.4.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking time v0.1.39 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking libudev v0.2.0 [INFO] [stderr] Checking serialport v1.0.1 [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking futures-timer v0.1.1 [INFO] [stderr] Checking mio-serial v0.6.0 [INFO] [stderr] Checking tokio-threadpool v0.1.2 [INFO] [stderr] Checking tokio-timer v0.2.1 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-serial v0.6.0 [INFO] [stderr] Checking stk500 v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Response = Box, Error=oneshot::Canceled>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub type Response = Box, Error=oneshot::Canceled>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:255:27 [INFO] [stdout] | [INFO] [stdout] 255 | write_cb: Option< Box)> >, // Function which writes to the microcontroller being programmed [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 255 | write_cb: Option< Box)> >, // Function which writes to the microcontroller being programmed [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:20:25 [INFO] [stdout] | [INFO] [stdout] 20 | pub type Response = Box, Error=oneshot::Canceled>>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub type Response = Box, Error=oneshot::Canceled>>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:255:27 [INFO] [stdout] | [INFO] [stdout] 255 | write_cb: Option< Box)> >, // Function which writes to the microcontroller being programmed [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 255 | write_cb: Option< Box)> >, // Function which writes to the microcontroller being programmed [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | Box< Future, Error=oneshot::Canceled> > [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 181 | Box< dyn Future, Error=oneshot::Canceled> > [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/codec.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | pub type ResponseFuture = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub type ResponseFuture = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/codec.rs:385:23 [INFO] [stdout] | [INFO] [stdout] 385 | type Future = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 385 | type Future = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:181:14 [INFO] [stdout] | [INFO] [stdout] 181 | Box< Future, Error=oneshot::Canceled> > [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 181 | Box< dyn Future, Error=oneshot::Canceled> > [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/codec.rs:16:31 [INFO] [stdout] | [INFO] [stdout] 16 | pub type ResponseFuture = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub type ResponseFuture = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/codec.rs:385:23 [INFO] [stdout] | [INFO] [stdout] 385 | type Future = Box>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 385 | type Future = Box>; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `port` [INFO] [stdout] --> src/lib.rs:513:13 [INFO] [stdout] | [INFO] [stdout] 513 | let port = tokio_serial::Serial::from_path("/dev/ttyACM0", &settings, &handle).unwrap(); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_port` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn set_write_cb(&mut self, callback: F) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | self.inner.lock().unwrap().set_write_cb(callback) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:33 [INFO] [stdout] | [INFO] [stdout] 188 | let p6 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let p7 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | loop_fn(0 as usize, move |mut index| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 211 | | let mut end = index + page_size; [INFO] [stdout] 212 | | if end >= data.len() { [INFO] [stdout] 213 | | end = data.len(); [INFO] [stdout] ... | [INFO] [stdout] 244 | | }) [INFO] [stdout] 245 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 134 | pub fn set_write_cb(&mut self, callback: F) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | self.inner.lock().unwrap().set_write_cb(callback) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 188 | let p6 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let p7 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let p6 = p6.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let p7 = p7.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | / futures_timer::Delay::new(Duration::from_millis(50)).map_err(|_|{oneshot::Canceled}).and_then( move |_| { [INFO] [stdout] 232 | | let mut inner = p6.lock().unwrap(); [INFO] [stdout] 233 | | inner.load_address((index / word_size) as u16) [INFO] [stdout] 234 | | }).and_then(move |_| { [INFO] [stdout] ... | [INFO] [stdout] 237 | | inner.prog_page(mem_type, &page.to_vec()) [INFO] [stdout] 238 | | }).and_then(move |_| { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(handle: &Handle, io_transport: T) -> Client { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Client{ [INFO] [stdout] 43 | inner: Arc::new( Inner::new(handle, io_transport) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 102 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let step5 = move |_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | loop_fn(0 as usize, move |mut index| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 111 | | let mut end = index + page_size; [INFO] [stdout] 112 | | if end >= data.len() { [INFO] [stdout] 113 | | end = data.len(); [INFO] [stdout] ... | [INFO] [stdout] 144 | | }) [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 102 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let _inner = inner.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let __inner = inner.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | / futures_timer::Delay::new(Duration::from_millis(50)) [INFO] [stdout] 132 | | .map_err(|_|{io::Error::new(io::ErrorKind::Other, "Timeout")}) [INFO] [stdout] 133 | | .and_then( move |_| { [INFO] [stdout] 134 | | _inner.load_address((index / word_size) as u16) [INFO] [stdout] ... | [INFO] [stdout] 137 | | __inner.prog_page(mem_type, &page.to_vec()) [INFO] [stdout] 138 | | }).and_then(move |_| { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | fn bind_transport(&self, io: T) -> Self::BindTransport { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(io.framed(Stk500Codec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:370:21 [INFO] [stdout] | [INFO] [stdout] 366 | fn new(upstream: T, delay: Duration, handle: &Handle) -> Timeout { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | handle: handle.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:210:33 [INFO] [stdout] | [INFO] [stdout] 188 | let p6 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let p7 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | loop_fn(0 as usize, move |mut index| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 211 | | let mut end = index + page_size; [INFO] [stdout] 212 | | if end >= data.len() { [INFO] [stdout] 213 | | end = data.len(); [INFO] [stdout] ... | [INFO] [stdout] 244 | | }) [INFO] [stdout] 245 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:231:17 [INFO] [stdout] | [INFO] [stdout] 188 | let p6 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | let p7 = self.inner.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let p6 = p6.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let p7 = p7.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | / futures_timer::Delay::new(Duration::from_millis(50)).map_err(|_|{oneshot::Canceled}).and_then( move |_| { [INFO] [stdout] 232 | | let mut inner = p6.lock().unwrap(); [INFO] [stdout] 233 | | inner.load_address((index / word_size) as u16) [INFO] [stdout] 234 | | }).and_then(move |_| { [INFO] [stdout] ... | [INFO] [stdout] 237 | | inner.prog_page(mem_type, &page.to_vec()) [INFO] [stdout] 238 | | }).and_then(move |_| { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn new(handle: &Handle, io_transport: T) -> Client { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | Client{ [INFO] [stdout] 43 | inner: Arc::new( Inner::new(handle, io_transport) ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:110:33 [INFO] [stdout] | [INFO] [stdout] 102 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let step5 = move |_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | loop_fn(0 as usize, move |mut index| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 111 | | let mut end = index + page_size; [INFO] [stdout] 112 | | if end >= data.len() { [INFO] [stdout] 113 | | end = data.len(); [INFO] [stdout] ... | [INFO] [stdout] 144 | | }) [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:131:17 [INFO] [stdout] | [INFO] [stdout] 102 | let inner = self.inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | let _inner = inner.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | let __inner = inner.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 131 | / futures_timer::Delay::new(Duration::from_millis(50)) [INFO] [stdout] 132 | | .map_err(|_|{io::Error::new(io::ErrorKind::Other, "Timeout")}) [INFO] [stdout] 133 | | .and_then( move |_| { [INFO] [stdout] 134 | | _inner.load_address((index / word_size) as u16) [INFO] [stdout] ... | [INFO] [stdout] 137 | | __inner.prog_page(mem_type, &page.to_vec()) [INFO] [stdout] 138 | | }).and_then(move |_| { [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | fn bind_transport(&self, io: T) -> Self::BindTransport { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(io.framed(Stk500Codec::new())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/codec.rs:370:21 [INFO] [stdout] | [INFO] [stdout] 366 | fn new(upstream: T, delay: Duration, handle: &Handle) -> Timeout { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 370 | handle: handle.clone() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stk500` (lib test) due to 9 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `stk500` (lib) due to 9 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "89bd73fdaf594ae747160715c8340251588bc55a031f72bb880cbe951ce321e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89bd73fdaf594ae747160715c8340251588bc55a031f72bb880cbe951ce321e9", kill_on_drop: false }` [INFO] [stdout] 89bd73fdaf594ae747160715c8340251588bc55a031f72bb880cbe951ce321e9