[INFO] cloning repository https://github.com/daviddenhaan/simple [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daviddenhaan/simple" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaviddenhaan%2Fsimple", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaviddenhaan%2Fsimple'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5834f6f58a1fb30ebc742e3974ae0678a354ee4d [INFO] checking daviddenhaan/simple/5834f6f58a1fb30ebc742e3974ae0678a354ee4d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaviddenhaan%2Fsimple" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/daviddenhaan/simple on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/daviddenhaan/simple [INFO] finished tweaking git repo https://github.com/daviddenhaan/simple [INFO] tweaked toml for git repo https://github.com/daviddenhaan/simple written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/daviddenhaan/simple already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bf3f255c22191e411a8fd0496e2ac98d0cfd07caa8bb5edea150d2b3ce19000 [INFO] running `Command { std: "docker" "start" "-a" "3bf3f255c22191e411a8fd0496e2ac98d0cfd07caa8bb5edea150d2b3ce19000", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bf3f255c22191e411a8fd0496e2ac98d0cfd07caa8bb5edea150d2b3ce19000", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bf3f255c22191e411a8fd0496e2ac98d0cfd07caa8bb5edea150d2b3ce19000", kill_on_drop: false }` [INFO] [stdout] 3bf3f255c22191e411a8fd0496e2ac98d0cfd07caa8bb5edea150d2b3ce19000 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7d660b971bedfdccbc76b99a455592c7e209bbfd309c5c09386f28fb92adbd50 [INFO] running `Command { std: "docker" "start" "-a" "7d660b971bedfdccbc76b99a455592c7e209bbfd309c5c09386f28fb92adbd50", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking const-str v0.5.6 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.50 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking simple v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `parse` is never used [INFO] [stdout] --> src/args.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) fn parse() -> Args { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `State` is never constructed [INFO] [stdout] --> src/state.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct State; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run` is never used [INFO] [stdout] --> src/state.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) fn run(_state: &mut State) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse` is never used [INFO] [stdout] --> src/parser/mod.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) fn parse(input: &str) -> ast::Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `at` is never used [INFO] [stdout] --> src/parser/mod.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 56 | / impl<'input, I> Parser<'input, I> [INFO] [stdout] 57 | | where I: Iterator, [INFO] [stdout] | |__________________________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 67 | fn at(&mut self, kind: TokenKind) -> bool { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn binop(lhs: Expr, op: TokenKind, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Expr::Binary { op, [INFO] [stdout] 21 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn binop(lhs: Expr, op: TokenKind, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) fn unary(op: TokenKind, expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Expr::Unary { op, [INFO] [stdout] 29 | expr: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse` is never used [INFO] [stdout] --> src/args.rs:9:15 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) fn parse() -> Args { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `State` is never constructed [INFO] [stdout] --> src/state.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) struct State; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `State` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `run` is never used [INFO] [stdout] --> src/state.rs:8:15 [INFO] [stdout] | [INFO] [stdout] 8 | pub(crate) fn run(_state: &mut State) -> Result { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parse` is never used [INFO] [stdout] --> src/parser/mod.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 52 | pub(crate) fn parse(input: &str) -> ast::Expr { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `at` is never used [INFO] [stdout] --> src/parser/mod.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 56 | / impl<'input, I> Parser<'input, I> [INFO] [stdout] 57 | | where I: Iterator, [INFO] [stdout] | |__________________________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 67 | fn at(&mut self, kind: TokenKind) -> bool { [INFO] [stdout] | ^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/expressions.rs:133:26 [INFO] [stdout] | [INFO] [stdout] 131 | let expr = parse("\"hello\""); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | [INFO] [stdout] 133 | assert_eq!(expr, string("hello")) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:21:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn binop(lhs: Expr, op: TokenKind, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Expr::Binary { op, [INFO] [stdout] 21 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn binop(lhs: Expr, op: TokenKind, rhs: Expr) -> Expr { [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/ast.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 27 | pub(crate) fn unary(op: TokenKind, expr: Expr) -> Expr { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Expr::Unary { op, [INFO] [stdout] 29 | expr: Box::new(expr), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple` (bin "simple") due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple` (bin "simple" test) due to 5 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7d660b971bedfdccbc76b99a455592c7e209bbfd309c5c09386f28fb92adbd50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d660b971bedfdccbc76b99a455592c7e209bbfd309c5c09386f28fb92adbd50", kill_on_drop: false }` [INFO] [stdout] 7d660b971bedfdccbc76b99a455592c7e209bbfd309c5c09386f28fb92adbd50