[INFO] cloning repository https://github.com/davidMcneil/unified-dynamic-rust-app-config [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/davidMcneil/unified-dynamic-rust-app-config" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidMcneil%2Funified-dynamic-rust-app-config", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidMcneil%2Funified-dynamic-rust-app-config'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8f08f3ec6a6a5c12fbd1e3cdbcaf8db7139bba48 [INFO] checking davidMcneil/unified-dynamic-rust-app-config/8f08f3ec6a6a5c12fbd1e3cdbcaf8db7139bba48 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidMcneil%2Funified-dynamic-rust-app-config" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/davidMcneil/unified-dynamic-rust-app-config on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/davidMcneil/unified-dynamic-rust-app-config [INFO] finished tweaking git repo https://github.com/davidMcneil/unified-dynamic-rust-app-config [INFO] tweaked toml for git repo https://github.com/davidMcneil/unified-dynamic-rust-app-config written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/davidMcneil/unified-dynamic-rust-app-config already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b57ad063e9be9b009dbc11463a1c3244467fd46c399428f8f16b45e5230de190 [INFO] running `Command { std: "docker" "start" "-a" "b57ad063e9be9b009dbc11463a1c3244467fd46c399428f8f16b45e5230de190", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b57ad063e9be9b009dbc11463a1c3244467fd46c399428f8f16b45e5230de190", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b57ad063e9be9b009dbc11463a1c3244467fd46c399428f8f16b45e5230de190", kill_on_drop: false }` [INFO] [stdout] b57ad063e9be9b009dbc11463a1c3244467fd46c399428f8f16b45e5230de190 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f04acf6837a1a78d4e2701624f6d15f4df15463aced79f27b5e7007a1a204489 [INFO] running `Command { std: "docker" "start" "-a" "f04acf6837a1a78d4e2701624f6d15f4df15463aced79f27b5e7007a1a204489", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.8 [INFO] [stderr] Compiling syn v1.0.14 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling serde v1.0.104 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking colosseum v0.2.2 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking unicode-xid v0.2.0 [INFO] [stderr] Checking clap v2.33.0 (https://github.com/habitat-sh/clap.git?branch=v2-master#88208fba) [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking quote v1.0.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking proc_macro_roids v0.7.0 [INFO] [stderr] Checking configopt-derive v0.1.0 (/opt/rustwide/workdir/configopt-derive) [INFO] [stdout] warning: unused import: `try_from_error::generate as try_from_error` [INFO] [stdout] --> configopt-derive/src/configopt_type/generate.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use try_from_error::generate as try_from_error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `try_from_error::generate as try_from_error` [INFO] [stdout] --> configopt-derive/src/configopt_type/generate.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use try_from_error::generate as try_from_error; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse.rs:198:27 [INFO] [stdout] | [INFO] [stdout] 113 | let configopt_attrs = configopt_parser::parse_attrs(&field.attrs); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | to_os_string: configopt_attrs.into_iter().find_map(|a| match a { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 199 | | ConfigOptAttr::ToOsString(expr) => Some(expr), [INFO] [stdout] 200 | | _ => None, [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/configopt_fields_attr_parser.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn parse(token_stream: TokenStream) -> Vec { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / Parser::parse( [INFO] [stdout] 55 | | >::parse_terminated, [INFO] [stdout] 56 | | token_stream, [INFO] [stdout] 57 | | ) [INFO] [stdout] 58 | | .expect("`configopt_fields` failed to parse attrs") [INFO] [stdout] 59 | | .into_iter() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 174 | fn subty_if(ty: &syn::Type, f: F) -> Option<&syn::Type> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | .filter(|segment| f(segment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 215 | fn only_one(mut iter: I) -> Option [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | iter.next().filter(|_| iter.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:219:28 [INFO] [stdout] | [INFO] [stdout] 219 | iter.next().filter(|_| iter.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `configopt-derive` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse.rs:198:27 [INFO] [stdout] | [INFO] [stdout] 113 | let configopt_attrs = configopt_parser::parse_attrs(&field.attrs); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | to_os_string: configopt_attrs.into_iter().find_map(|a| match a { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 199 | | ConfigOptAttr::ToOsString(expr) => Some(expr), [INFO] [stdout] 200 | | _ => None, [INFO] [stdout] 201 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/configopt_fields_attr_parser.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn parse(token_stream: TokenStream) -> Vec { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | / Parser::parse( [INFO] [stdout] 55 | | >::parse_terminated, [INFO] [stdout] 56 | | token_stream, [INFO] [stdout] 57 | | ) [INFO] [stdout] 58 | | .expect("`configopt_fields` failed to parse attrs") [INFO] [stdout] 59 | | .into_iter() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 174 | fn subty_if(ty: &syn::Type, f: F) -> Option<&syn::Type> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | .filter(|segment| f(segment)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 215 | fn only_one(mut iter: I) -> Option [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | iter.next().filter(|_| iter.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> configopt-derive/src/configopt_type/parse/structopt_parser.rs:219:28 [INFO] [stdout] | [INFO] [stdout] 219 | iter.next().filter(|_| iter.next().is_none()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `configopt-derive` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f04acf6837a1a78d4e2701624f6d15f4df15463aced79f27b5e7007a1a204489", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f04acf6837a1a78d4e2701624f6d15f4df15463aced79f27b5e7007a1a204489", kill_on_drop: false }` [INFO] [stdout] f04acf6837a1a78d4e2701624f6d15f4df15463aced79f27b5e7007a1a204489