[INFO] cloning repository https://github.com/david47k/tree_example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/david47k/tree_example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid47k%2Ftree_example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid47k%2Ftree_example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] be70a311ed8438a0400a6b4e23e8639720163ebc [INFO] checking david47k/tree_example/be70a311ed8438a0400a6b4e23e8639720163ebc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid47k%2Ftree_example" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/david47k/tree_example on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/david47k/tree_example [INFO] finished tweaking git repo https://github.com/david47k/tree_example [INFO] tweaked toml for git repo https://github.com/david47k/tree_example written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/david47k/tree_example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 67859799365a9186ba2a5a735f237c53c2392ccd144e6e43f5d7b3f844ce4797 [INFO] running `Command { std: "docker" "start" "-a" "67859799365a9186ba2a5a735f237c53c2392ccd144e6e43f5d7b3f844ce4797", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "67859799365a9186ba2a5a735f237c53c2392ccd144e6e43f5d7b3f844ce4797", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "67859799365a9186ba2a5a735f237c53c2392ccd144e6e43f5d7b3f844ce4797", kill_on_drop: false }` [INFO] [stdout] 67859799365a9186ba2a5a735f237c53c2392ccd144e6e43f5d7b3f844ce4797 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a073ca8f136ea757b88979d6cd223dd077dff6569bd4ff1f896ca9d343a7f4f [INFO] running `Command { std: "docker" "start" "-a" "5a073ca8f136ea757b88979d6cd223dd077dff6569bd4ff1f896ca9d343a7f4f", kill_on_drop: false }` [INFO] [stderr] Checking tree_example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:13:54 [INFO] [stdout] | [INFO] [stdout] 13 | n.children().iter().for_each(|n| print_tree(&n.clone(), depth+1)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(v: T) -> Self { // create a new root node [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Self { [INFO] [stdout] 93 | inner: Arc::new(RwLock::new(TreeNode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 94 | | parent: None, [INFO] [stdout] 95 | | children: Vec::>::new(), [INFO] [stdout] 96 | | val: v, [INFO] [stdout] 97 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn downgrade(self) -> TreeNodeWeak:: { // downgrade this ref to a weak form (weak form doesn't affect reference count) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | TreeNodeWeak:: { [INFO] [stdout] 156 | inner: Arc::downgrade(&self.inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:161:43 [INFO] [stdout] | [INFO] [stdout] 161 | let r = inner.children.iter().find(|&n| n.val()==val); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:177:11 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn upgrade(self) -> TreeNodeRef { // upgrade this weak ref into a strong one [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | TreeNodeRef { [INFO] [stdout] 177 | inner: self.inner.upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:13:54 [INFO] [stdout] | [INFO] [stdout] 13 | n.children().iter().for_each(|n| print_tree(&n.clone(), depth+1)); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn new(v: T) -> Self { // create a new root node [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | Self { [INFO] [stdout] 93 | inner: Arc::new(RwLock::new(TreeNode { [INFO] [stdout] | ____________________^ [INFO] [stdout] 94 | | parent: None, [INFO] [stdout] 95 | | children: Vec::>::new(), [INFO] [stdout] 96 | | val: v, [INFO] [stdout] 97 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:156:11 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn downgrade(self) -> TreeNodeWeak:: { // downgrade this ref to a weak form (weak form doesn't affect reference count) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | TreeNodeWeak:: { [INFO] [stdout] 156 | inner: Arc::downgrade(&self.inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:161:43 [INFO] [stdout] | [INFO] [stdout] 161 | let r = inner.children.iter().find(|&n| n.val()==val); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tree.rs:177:11 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn upgrade(self) -> TreeNodeRef { // upgrade this weak ref into a strong one [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | TreeNodeRef { [INFO] [stdout] 177 | inner: self.inner.upgrade().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree_example` (bin "tree_example" test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tree_example` (bin "tree_example") due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "5a073ca8f136ea757b88979d6cd223dd077dff6569bd4ff1f896ca9d343a7f4f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a073ca8f136ea757b88979d6cd223dd077dff6569bd4ff1f896ca9d343a7f4f", kill_on_drop: false }` [INFO] [stdout] 5a073ca8f136ea757b88979d6cd223dd077dff6569bd4ff1f896ca9d343a7f4f