[INFO] cloning repository https://github.com/david-wallace-croft/com-croftsoft-app-life [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/david-wallace-croft/com-croftsoft-app-life" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid-wallace-croft%2Fcom-croftsoft-app-life", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid-wallace-croft%2Fcom-croftsoft-app-life'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 48fd5db81ed43cd43df86014bf10b98722f23576 [INFO] checking david-wallace-croft/com-croftsoft-app-life/48fd5db81ed43cd43df86014bf10b98722f23576 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavid-wallace-croft%2Fcom-croftsoft-app-life" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/david-wallace-croft/com-croftsoft-app-life on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/david-wallace-croft/com-croftsoft-app-life [INFO] finished tweaking git repo https://github.com/david-wallace-croft/com-croftsoft-app-life [INFO] tweaked toml for git repo https://github.com/david-wallace-croft/com-croftsoft-app-life written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/david-wallace-croft/com-croftsoft-app-life already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5df47550a2d8614c0c530f8754c33ee865c47064b6fda4ac12981b08674faf1a [INFO] running `Command { std: "docker" "start" "-a" "5df47550a2d8614c0c530f8754c33ee865c47064b6fda4ac12981b08674faf1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5df47550a2d8614c0c530f8754c33ee865c47064b6fda4ac12981b08674faf1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5df47550a2d8614c0c530f8754c33ee865c47064b6fda4ac12981b08674faf1a", kill_on_drop: false }` [INFO] [stdout] 5df47550a2d8614c0c530f8754c33ee865c47064b6fda4ac12981b08674faf1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a91b7181ca32751a96b5cd1f6a9eebd0221dff8cd2d0b486bd5a56711d547fdc [INFO] running `Command { std: "docker" "start" "-a" "a91b7181ca32751a96b5cd1f6a9eebd0221dff8cd2d0b486bd5a56711d547fdc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.91 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling once_cell v1.17.0 [INFO] [stderr] Compiling bumpalo v3.11.1 [INFO] [stderr] Compiling wasm-bindgen v0.2.91 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking com-croftsoft-lib-role v0.5.1 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling syn v2.0.22 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.91 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.41 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.91 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.91 [INFO] [stderr] Checking js-sys v0.3.68 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.41 [INFO] [stderr] Checking web-sys v0.3.68 [INFO] [stderr] Checking wasm-bindgen-test v0.3.41 [INFO] [stderr] Checking com-croftsoft-lib-animation v0.0.8 [INFO] [stderr] Checking com-croftsoft-app-life v0.4.2-SNAPSHOT (/opt/rustwide/workdir) [INFO] [stdout] warning: methods `get_reset_requested`, `get_time_to_update`, `get_update_period_millis_changed`, and `get_update_time_millis` are never used [INFO] [stdout] --> src/updaters/options/mod.rs:23:6 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait OptionsUpdaterInputs { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn get_reset_requested(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 24 | // TODO: clippy says this is never used [INFO] [stdout] 25 | fn get_time_to_update(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 26 | // TODO: clippy says this is never used [INFO] [stdout] 27 | fn get_update_period_millis_changed(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | // TODO: clippy says this is never used [INFO] [stdout] 29 | fn get_update_time_millis(&self) -> f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_updated` is never used [INFO] [stdout] --> src/updaters/root/mod.rs:44:6 [INFO] [stdout] | [INFO] [stdout] 43 | pub trait RootUpdaterEvents { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] 44 | fn get_updated(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/canvas/mod.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 54 | root_model: Rc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | root_painter_option: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/canvas/mod.rs:62:34 [INFO] [stdout] | [INFO] [stdout] 54 | root_model: Rc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | unbounded_receiver_option: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/root/mod.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 120 | .for_each(|component| component.borrow_mut().initialize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/root/mod.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | .for_each(|component| component.borrow_mut().update()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `get_reset_requested`, `get_time_to_update`, `get_update_period_millis_changed`, and `get_update_time_millis` are never used [INFO] [stdout] --> src/updaters/options/mod.rs:23:6 [INFO] [stdout] | [INFO] [stdout] 19 | pub trait OptionsUpdaterInputs { [INFO] [stdout] | -------------------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 23 | fn get_reset_requested(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 24 | // TODO: clippy says this is never used [INFO] [stdout] 25 | fn get_time_to_update(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 26 | // TODO: clippy says this is never used [INFO] [stdout] 27 | fn get_update_period_millis_changed(&self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 28 | // TODO: clippy says this is never used [INFO] [stdout] 29 | fn get_update_time_millis(&self) -> f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_updated` is never used [INFO] [stdout] --> src/updaters/root/mod.rs:44:6 [INFO] [stdout] | [INFO] [stdout] 43 | pub trait RootUpdaterEvents { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] 44 | fn get_updated(&self) -> bool; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/canvas/mod.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 54 | root_model: Rc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | root_painter_option: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/canvas/mod.rs:62:34 [INFO] [stdout] | [INFO] [stdout] 54 | root_model: Rc>, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | unbounded_receiver_option: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/root/mod.rs:120:29 [INFO] [stdout] | [INFO] [stdout] 120 | .for_each(|component| component.borrow_mut().initialize()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/components/root/mod.rs:138:29 [INFO] [stdout] | [INFO] [stdout] 138 | .for_each(|component| component.borrow_mut().update()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `com-croftsoft-app-life` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `com-croftsoft-app-life` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a91b7181ca32751a96b5cd1f6a9eebd0221dff8cd2d0b486bd5a56711d547fdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a91b7181ca32751a96b5cd1f6a9eebd0221dff8cd2d0b486bd5a56711d547fdc", kill_on_drop: false }` [INFO] [stdout] a91b7181ca32751a96b5cd1f6a9eebd0221dff8cd2d0b486bd5a56711d547fdc