[INFO] cloning repository https://github.com/dat2/csv-aggregator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dat2/csv-aggregator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdat2%2Fcsv-aggregator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdat2%2Fcsv-aggregator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ff00876adf350ccbd5bf04b02e558347a7f0971f [INFO] checking dat2/csv-aggregator/ff00876adf350ccbd5bf04b02e558347a7f0971f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdat2%2Fcsv-aggregator" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dat2/csv-aggregator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dat2/csv-aggregator [INFO] finished tweaking git repo https://github.com/dat2/csv-aggregator [INFO] tweaked toml for git repo https://github.com/dat2/csv-aggregator written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dat2/csv-aggregator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4318855bf1804c6122e0af858fd23cad19920c2ca77636c929ecb5a5e95532e0 [INFO] running `Command { std: "docker" "start" "-a" "4318855bf1804c6122e0af858fd23cad19920c2ca77636c929ecb5a5e95532e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4318855bf1804c6122e0af858fd23cad19920c2ca77636c929ecb5a5e95532e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4318855bf1804c6122e0af858fd23cad19920c2ca77636c929ecb5a5e95532e0", kill_on_drop: false }` [INFO] [stdout] 4318855bf1804c6122e0af858fd23cad19920c2ca77636c929ecb5a5e95532e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 404007699acbd5ee6e969fe0beb479c69345f14b271266f4c1e452b5a68e84f4 [INFO] running `Command { std: "docker" "start" "-a" "404007699acbd5ee6e969fe0beb479c69345f14b271266f4c1e452b5a68e84f4", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.34 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Compiling cc v1.0.3 [INFO] [stderr] Checking serde v1.0.24 [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking rustc-demangle v0.1.5 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking ascii v0.7.1 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking glob v0.2.11 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking float-cmp v0.2.5 [INFO] [stderr] Checking combine v3.0.0-alpha.4 [INFO] [stderr] Compiling synstructure v0.6.1 [INFO] [stderr] Compiling serde_derive_internals v0.18.0 [INFO] [stderr] Compiling failure_derive v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.24 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking backtrace v0.3.4 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking csv-aggregator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/args.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(path) = env::home_dir() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/args.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | if let Some(path) = env::home_dir() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 90 | let mut expression = Expression::Empty; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Filter::new(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | .map(|t| Expression::Not(Box::new(t.1))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | ).map(|t| Expression::Not(Box::new(t.1))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:45 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:60 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-aggregator` (bin "csv-aggregator" test) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:95:6 [INFO] [stdout] | [INFO] [stdout] 90 | let mut expression = Expression::Empty; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | Ok(Filter::new(expression)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | .map(|t| Expression::Not(Box::new(t.1))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:40:31 [INFO] [stdout] | [INFO] [stdout] 40 | ).map(|t| Expression::Not(Box::new(t.1))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:30 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:45 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:74:60 [INFO] [stdout] | [INFO] [stdout] 74 | ).map(|t| Expression::If(Box::new(t.1), Box::new(t.3), Box::new(Expression::Empty))); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csv-aggregator` (bin "csv-aggregator") due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "404007699acbd5ee6e969fe0beb479c69345f14b271266f4c1e452b5a68e84f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "404007699acbd5ee6e969fe0beb479c69345f14b271266f4c1e452b5a68e84f4", kill_on_drop: false }` [INFO] [stdout] 404007699acbd5ee6e969fe0beb479c69345f14b271266f4c1e452b5a68e84f4