[INFO] cloning repository https://github.com/dashaw92/rainworld_level [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dashaw92/rainworld_level" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdashaw92%2Frainworld_level", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdashaw92%2Frainworld_level'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4b92c6f3145fd765eede64a4ddb2a8e6042d079f [INFO] checking dashaw92/rainworld_level/4b92c6f3145fd765eede64a4ddb2a8e6042d079f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdashaw92%2Frainworld_level" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dashaw92/rainworld_level on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dashaw92/rainworld_level [INFO] finished tweaking git repo https://github.com/dashaw92/rainworld_level [INFO] tweaked toml for git repo https://github.com/dashaw92/rainworld_level written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dashaw92/rainworld_level already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21800fa8855651a2f5ca35c01a8b858083cbde6376956f1c34139ccb5de84a79 [INFO] running `Command { std: "docker" "start" "-a" "21800fa8855651a2f5ca35c01a8b858083cbde6376956f1c34139ccb5de84a79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21800fa8855651a2f5ca35c01a8b858083cbde6376956f1c34139ccb5de84a79", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21800fa8855651a2f5ca35c01a8b858083cbde6376956f1c34139ccb5de84a79", kill_on_drop: false }` [INFO] [stdout] 21800fa8855651a2f5ca35c01a8b858083cbde6376956f1c34139ccb5de84a79 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4f48b65e1bb4f9db82a0e7cbb2509572810512630ffb0cfc9663ba884998f05 [INFO] running `Command { std: "docker" "start" "-a" "f4f48b65e1bb4f9db82a0e7cbb2509572810512630ffb0cfc9663ba884998f05", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking rainworld_level v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `red`, `green`, and `blue` are never read [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) struct Color { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 11 | pub(crate) red: u8, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | pub(crate) green: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | pub(crate) blue: u8, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Color` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `top`, `left`, `bottom`, and `right` are never read [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct Rect { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 18 | pub(crate) top: isize, [INFO] [stdout] | ^^^ [INFO] [stdout] 19 | pub(crate) left: isize, [INFO] [stdout] | ^^^^ [INFO] [stdout] 20 | pub(crate) bottom: isize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | pub(crate) right: isize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Rect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_features`, `remove_features`, and `features` are never used [INFO] [stdout] --> src/tile.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Tile { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 80 | pub fn add_features(&mut self, features: &[Feature]) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | pub fn remove_features(&mut self, features: &[Feature]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn features(&self) -> &[Feature] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_tile` is never used [INFO] [stdout] --> src/tile.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 97 | impl Geometry { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 98 | pub fn to_tile(&self) -> Tile { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `matrix`, and `options` are never read [INFO] [stdout] --> src/effect.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Effect { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 5 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | pub(crate) matrix: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 7 | pub(crate) options: Value, //TODO [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Effect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_to_json.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | .filter_map(|line| serde_json::from_str(&line).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 25 | let vals: Vec> = s.strip_prefix(prefix)? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | vals.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|val| val.trim().parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rainworld_level` (lib) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `red`, `green`, and `blue` are never read [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:11:16 [INFO] [stdout] | [INFO] [stdout] 10 | pub(crate) struct Color { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 11 | pub(crate) red: u8, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | pub(crate) green: u8, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 13 | pub(crate) blue: u8, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Color` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `top`, `left`, `bottom`, and `right` are never read [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) struct Rect { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 18 | pub(crate) top: isize, [INFO] [stdout] | ^^^ [INFO] [stdout] 19 | pub(crate) left: isize, [INFO] [stdout] | ^^^^ [INFO] [stdout] 20 | pub(crate) bottom: isize, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 21 | pub(crate) right: isize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Rect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `add_features`, `remove_features`, and `features` are never used [INFO] [stdout] --> src/tile.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 79 | impl Tile { [INFO] [stdout] | --------- methods in this implementation [INFO] [stdout] 80 | pub fn add_features(&mut self, features: &[Feature]) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 88 | pub fn remove_features(&mut self, features: &[Feature]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub fn features(&self) -> &[Feature] { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `to_tile` is never used [INFO] [stdout] --> src/tile.rs:98:12 [INFO] [stdout] | [INFO] [stdout] 97 | impl Geometry { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] 98 | pub fn to_tile(&self) -> Tile { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name`, `matrix`, and `options` are never read [INFO] [stdout] --> src/effect.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct Effect { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 5 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 6 | pub(crate) matrix: Vec>, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 7 | pub(crate) options: Value, //TODO [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Effect` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_to_json.rs:30:32 [INFO] [stdout] | [INFO] [stdout] 30 | .filter_map(|line| serde_json::from_str(&line).ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 25 | let vals: Vec> = s.strip_prefix(prefix)? [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | vals.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rwlevel/lingo_dsl.rs:28:20 [INFO] [stdout] | [INFO] [stdout] 28 | .map(|val| val.trim().parse::().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rainworld_level` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f4f48b65e1bb4f9db82a0e7cbb2509572810512630ffb0cfc9663ba884998f05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4f48b65e1bb4f9db82a0e7cbb2509572810512630ffb0cfc9663ba884998f05", kill_on_drop: false }` [INFO] [stdout] f4f48b65e1bb4f9db82a0e7cbb2509572810512630ffb0cfc9663ba884998f05