[INFO] cloning repository https://github.com/danvk/rusty-boggle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/danvk/rusty-boggle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanvk%2Frusty-boggle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanvk%2Frusty-boggle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 47f91bf1d06ff9abf743daac1a7dcebd4bdd226e [INFO] checking danvk/rusty-boggle/47f91bf1d06ff9abf743daac1a7dcebd4bdd226e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanvk%2Frusty-boggle" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/danvk/rusty-boggle on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/danvk/rusty-boggle [INFO] finished tweaking git repo https://github.com/danvk/rusty-boggle [INFO] tweaked toml for git repo https://github.com/danvk/rusty-boggle written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/danvk/rusty-boggle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b650ebdf20b0ee4595900229620fe10dfe2a16e774ae6720fed6932c49c7b64d [INFO] running `Command { std: "docker" "start" "-a" "b650ebdf20b0ee4595900229620fe10dfe2a16e774ae6720fed6932c49c7b64d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b650ebdf20b0ee4595900229620fe10dfe2a16e774ae6720fed6932c49c7b64d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b650ebdf20b0ee4595900229620fe10dfe2a16e774ae6720fed6932c49c7b64d", kill_on_drop: false }` [INFO] [stdout] b650ebdf20b0ee4595900229620fe10dfe2a16e774ae6720fed6932c49c7b64d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3534184bd082b3a459db13c9dfaed63ccfcde5d0f6b039dcb4a7a3d16d9a6549 [INFO] running `Command { std: "docker" "start" "-a" "3534184bd082b3a459db13c9dfaed63ccfcde5d0f6b039dcb4a7a3d16d9a6549", kill_on_drop: false }` [INFO] [stderr] Checking rusty-boggle v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/trie.rs:73:45 [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("Invalid letter: {i}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("Invalid letter: {i}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("{}", "Invalid letter: {i}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/trie.rs:85:45 [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("Invalid letter: {i}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("Invalid letter: {i}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("{}", "Invalid letter: {i}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-boggle` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/trie.rs:73:45 [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("Invalid letter: {i}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("Invalid letter: {i}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 73 | None => panic!("{}", "Invalid letter: {i}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message contains an unused formatting placeholder [INFO] [stdout] --> src/trie.rs:85:45 [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("Invalid letter: {i}"), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this message is not used as a format string when given without arguments, but will be in Rust 2021 [INFO] [stdout] help: add the missing argument [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("Invalid letter: {i}", ...), [INFO] [stdout] | +++++ [INFO] [stdout] help: or add a "{}" format string to use the message literally [INFO] [stdout] | [INFO] [stdout] 85 | None => panic!("{}", "Invalid letter: {i}"), [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn read_lines

(filename: P) -> io::Result>> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | where P: AsRef, { [INFO] [stdout] 8 | let file = File::open(filename)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | Ok(io::BufReader::new(file).lines()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-boggle` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3534184bd082b3a459db13c9dfaed63ccfcde5d0f6b039dcb4a7a3d16d9a6549", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3534184bd082b3a459db13c9dfaed63ccfcde5d0f6b039dcb4a7a3d16d9a6549", kill_on_drop: false }` [INFO] [stdout] 3534184bd082b3a459db13c9dfaed63ccfcde5d0f6b039dcb4a7a3d16d9a6549