[INFO] cloning repository https://github.com/danthedaniel/gameoflife-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/danthedaniel/gameoflife-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanthedaniel%2Fgameoflife-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanthedaniel%2Fgameoflife-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6ed89ed1dda8a129a680027ca6e5c4cca5126f2e [INFO] checking danthedaniel/gameoflife-rs/6ed89ed1dda8a129a680027ca6e5c4cca5126f2e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanthedaniel%2Fgameoflife-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/danthedaniel/gameoflife-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/danthedaniel/gameoflife-rs [INFO] finished tweaking git repo https://github.com/danthedaniel/gameoflife-rs [INFO] tweaked toml for git repo https://github.com/danthedaniel/gameoflife-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/danthedaniel/gameoflife-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1e5eb78007f4f89d3bcd0dfa9a0c4ca0d7deb5e2e3c7fa1a47b4c309121f6228 [INFO] running `Command { std: "docker" "start" "-a" "1e5eb78007f4f89d3bcd0dfa9a0c4ca0d7deb5e2e3c7fa1a47b4c309121f6228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1e5eb78007f4f89d3bcd0dfa9a0c4ca0d7deb5e2e3c7fa1a47b4c309121f6228", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e5eb78007f4f89d3bcd0dfa9a0c4ca0d7deb5e2e3c7fa1a47b4c309121f6228", kill_on_drop: false }` [INFO] [stdout] 1e5eb78007f4f89d3bcd0dfa9a0c4ca0d7deb5e2e3c7fa1a47b4c309121f6228 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] db6b51a17100b4f69ca674096773390bd07f5c6e114805a6e3f2a45a214b4b86 [INFO] running `Command { std: "docker" "start" "-a" "db6b51a17100b4f69ca674096773390bd07f5c6e114805a6e3f2a45a214b4b86", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.4 [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling cc v1.0.37 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling cfg-if v0.1.9 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking downcast-rs v1.0.4 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling backtrace v0.3.26 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking stb_truetype v0.2.6 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling gl_generator v0.13.1 [INFO] [stderr] Compiling gl_generator v0.11.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking takeable-option v0.4.0 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling libloading v0.5.1 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling glium v0.25.1 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking rusttype v0.7.6 [INFO] [stderr] Compiling glutin_egl_sys v0.1.4 [INFO] [stderr] Compiling glutin_glx_sys v0.1.6 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.21.2 [INFO] [stderr] Checking gameoflife v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/gol.rs:91:14 [INFO] [stdout] | [INFO] [stdout] 90 | (2..=3, true) => true, // Goldilocks zone [INFO] [stdout] | ----- this range overlaps on `3_u8`... [INFO] [stdout] 91 | (3..=8, true) => false, // Overcrowded [INFO] [stdout] | ^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple patterns overlap on their endpoints [INFO] [stdout] --> src/gol.rs:91:14 [INFO] [stdout] | [INFO] [stdout] 90 | (2..=3, true) => true, // Goldilocks zone [INFO] [stdout] | ----- this range overlaps on `3_u8`... [INFO] [stdout] 91 | (3..=8, true) => false, // Overcrowded [INFO] [stdout] | ^^^^^ ... with this range [INFO] [stdout] | [INFO] [stdout] = note: you likely meant to write mutually exclusive ranges [INFO] [stdout] = note: `#[warn(overlapping_range_endpoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `mouse_pressed` is never used [INFO] [stdout] --> src/state.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 78 | impl GameState { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn mouse_pressed(&mut self, button: MouseButton) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | let window = glutin::WindowBuilder::new().with_title("Game of Life"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Display::new(window.with_dimensions(window_size), context, &events_loop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `mouse_pressed` is never used [INFO] [stdout] --> src/state.rs:173:12 [INFO] [stdout] | [INFO] [stdout] 78 | impl GameState { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 173 | pub fn mouse_pressed(&mut self, button: MouseButton) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:96:32 [INFO] [stdout] | [INFO] [stdout] 80 | let (simulation_thread, tick_sender, tex_receiver) = GameState::start_thread(); [INFO] [stdout] | ----------------- ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | simulation_thread: Some(simulation_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 41 | let window = glutin::WindowBuilder::new().with_title("Game of Life"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | Display::new(window.with_dimensions(window_size), context, &events_loop) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state.rs:96:32 [INFO] [stdout] | [INFO] [stdout] 80 | let (simulation_thread, tick_sender, tex_receiver) = GameState::start_thread(); [INFO] [stdout] | ----------------- ----------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | simulation_thread: Some(simulation_thread), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gameoflife` (bin "gameoflife") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gameoflife` (bin "gameoflife" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "db6b51a17100b4f69ca674096773390bd07f5c6e114805a6e3f2a45a214b4b86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "db6b51a17100b4f69ca674096773390bd07f5c6e114805a6e3f2a45a214b4b86", kill_on_drop: false }` [INFO] [stdout] db6b51a17100b4f69ca674096773390bd07f5c6e114805a6e3f2a45a214b4b86