[INFO] cloning repository https://github.com/dann-tran/codecrafters-redis-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dann-tran/codecrafters-redis-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdann-tran%2Fcodecrafters-redis-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdann-tran%2Fcodecrafters-redis-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 171067308852ad956f565058a3ad85e2710d72fb [INFO] checking dann-tran/codecrafters-redis-rust/171067308852ad956f565058a3ad85e2710d72fb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdann-tran%2Fcodecrafters-redis-rust" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dann-tran/codecrafters-redis-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dann-tran/codecrafters-redis-rust [INFO] finished tweaking git repo https://github.com/dann-tran/codecrafters-redis-rust [INFO] tweaked toml for git repo https://github.com/dann-tran/codecrafters-redis-rust written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dann-tran/codecrafters-redis-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 872d9628ce7d6c61f031be8d8ab05c6b744516774053382ac5173d90ef6dd890 [INFO] running `Command { std: "docker" "start" "-a" "872d9628ce7d6c61f031be8d8ab05c6b744516774053382ac5173d90ef6dd890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "872d9628ce7d6c61f031be8d8ab05c6b744516774053382ac5173d90ef6dd890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "872d9628ce7d6c61f031be8d8ab05c6b744516774053382ac5173d90ef6dd890", kill_on_drop: false }` [INFO] [stdout] 872d9628ce7d6c61f031be8d8ab05c6b744516774053382ac5173d90ef6dd890 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9ae6963c9a509a04b974d08cf8edbf53ceddda38bd94ade301612e294625bca [INFO] running `Command { std: "docker" "start" "-a" "e9ae6963c9a509a04b974d08cf8edbf53ceddda38bd94ade301612e294625bca", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.138 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling parking_lot_core v0.9.5 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling tokio v1.23.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.59 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Checking lzf v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking signal-hook-registry v1.2.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking mio v0.8.5 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Compiling thiserror-impl v1.0.32 [INFO] [stderr] Compiling tokio-macros v1.8.2 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking thiserror v1.0.32 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking redis-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdb.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 132 | let mut databases = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(Rdb { [INFO] [stdout] | ________^ [INFO] [stdout] 235 | | // ver_num, [INFO] [stdout] 236 | | // aux, [INFO] [stdout] 237 | | databases, [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:58:60 [INFO] [stdout] | [INFO] [stdout] 58 | async fn handle_conn(&mut self, mut socket: TcpStream) { [INFO] [stdout] | _________________________________________-----------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | | let mut buf = [0u8; 1024]; [INFO] [stdout] 60 | | loop { [INFO] [stdout] 61 | | socket [INFO] [stdout] ... | [INFO] [stdout] 357 | | } [INFO] [stdout] 358 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:299:33 [INFO] [stdout] | [INFO] [stdout] 291 | ... let mut join_set = JoinSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | ... join_set.join_next().await.expect("Join set is not empty") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:296:76 [INFO] [stdout] | [INFO] [stdout] 294 | ... let mut receiver = self.store.get_stream_receiver(&key).await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | ... join_set.spawn( [INFO] [stdout] 296 | ... async move { (key, receiver.recv().await.unwrap()) }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | async fn handle_conn(&mut self, mut socket: TcpStream) { [INFO] [stdout] | _________________________________________-----------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | let mut buf = [0u8; 1024]; [INFO] [stdout] 31 | | loop { [INFO] [stdout] 32 | | socket [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 114 | let rdb = parse_rdb(rdb)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok((rdb, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:220:71 [INFO] [stdout] | [INFO] [stdout] 156 | pub async fn new(port: u16, mut socket: TcpStream) -> anyhow::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let mut master_watcher = server.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | tokio::spawn(async move { master_watcher.watch_master(socket).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/store.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|(k, v)| (k, Arc::new(Mutex::new(v)))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdb.rs:234:8 [INFO] [stdout] | [INFO] [stdout] 132 | let mut databases = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 234 | Ok(Rdb { [INFO] [stdout] | ________^ [INFO] [stdout] 235 | | // ver_num, [INFO] [stdout] 236 | | // aux, [INFO] [stdout] 237 | | databases, [INFO] [stdout] 238 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:58:60 [INFO] [stdout] | [INFO] [stdout] 58 | async fn handle_conn(&mut self, mut socket: TcpStream) { [INFO] [stdout] | _________________________________________-----------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | | let mut buf = [0u8; 1024]; [INFO] [stdout] 60 | | loop { [INFO] [stdout] 61 | | socket [INFO] [stdout] ... | [INFO] [stdout] 357 | | } [INFO] [stdout] 358 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:299:33 [INFO] [stdout] | [INFO] [stdout] 291 | ... let mut join_set = JoinSet::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | ... join_set.join_next().await.expect("Join set is not empty") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/master.rs:296:76 [INFO] [stdout] | [INFO] [stdout] 294 | ... let mut receiver = self.store.get_stream_receiver(&key).await; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | ... join_set.spawn( [INFO] [stdout] 296 | ... async move { (key, receiver.recv().await.unwrap()) }, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:29:60 [INFO] [stdout] | [INFO] [stdout] 29 | async fn handle_conn(&mut self, mut socket: TcpStream) { [INFO] [stdout] | _________________________________________-----------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | | let mut buf = [0u8; 1024]; [INFO] [stdout] 31 | | loop { [INFO] [stdout] 32 | | socket [INFO] [stdout] ... | [INFO] [stdout] 60 | | } [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 114 | let rdb = parse_rdb(rdb)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Ok((rdb, remaining)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/replica.rs:220:71 [INFO] [stdout] | [INFO] [stdout] 156 | pub async fn new(port: u16, mut socket: TcpStream) -> anyhow::Result { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let mut master_watcher = server.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | tokio::spawn(async move { master_watcher.watch_master(socket).await }); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/store.rs:29:31 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|(k, v)| (k, Arc::new(Mutex::new(v)))) [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-starter-rust` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "e9ae6963c9a509a04b974d08cf8edbf53ceddda38bd94ade301612e294625bca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9ae6963c9a509a04b974d08cf8edbf53ceddda38bd94ade301612e294625bca", kill_on_drop: false }` [INFO] [stdout] e9ae6963c9a509a04b974d08cf8edbf53ceddda38bd94ade301612e294625bca