[INFO] cloning repository https://github.com/danielwaterworth/raft-logic [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/danielwaterworth/raft-logic" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanielwaterworth%2Fraft-logic", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanielwaterworth%2Fraft-logic'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 335b4fadd367577c11b1012a7327a10d00e706f2 [INFO] checking danielwaterworth/raft-logic/335b4fadd367577c11b1012a7327a10d00e706f2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdanielwaterworth%2Fraft-logic" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/danielwaterworth/raft-logic on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/danielwaterworth/raft-logic [INFO] finished tweaking git repo https://github.com/danielwaterworth/raft-logic [INFO] tweaked toml for git repo https://github.com/danielwaterworth/raft-logic written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/danielwaterworth/raft-logic already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2aa516c677b5b25661b4454ccd37b82441ded48b54fa53671473a1887d8aca9 [INFO] running `Command { std: "docker" "start" "-a" "e2aa516c677b5b25661b4454ccd37b82441ded48b54fa53671473a1887d8aca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2aa516c677b5b25661b4454ccd37b82441ded48b54fa53671473a1887d8aca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2aa516c677b5b25661b4454ccd37b82441ded48b54fa53671473a1887d8aca9", kill_on_drop: false }` [INFO] [stdout] e2aa516c677b5b25661b4454ccd37b82441ded48b54fa53671473a1887d8aca9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39221866c4554d0a1d8cd68bfdd1da2c270287b9dc9814a29df2df4f11467985 [INFO] running `Command { std: "docker" "start" "-a" "39221866c4554d0a1d8cd68bfdd1da2c270287b9dc9814a29df2df4f11467985", kill_on_drop: false }` [INFO] [stderr] Checking raft-logic v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `LogIndex` [INFO] [stdout] --> src/raft.rs:2:56 [INFO] [stdout] | [INFO] [stdout] 2 | compare_log_versions, GetResult, InsertError, Log, LogIndex, LogStatus, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `LogIndex` [INFO] [stdout] --> src/raft.rs:2:56 [INFO] [stdout] | [INFO] [stdout] 2 | compare_log_versions, GetResult, InsertError, Log, LogIndex, LogStatus, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:415:32 [INFO] [stdout] | [INFO] [stdout] 415 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:418:29 [INFO] [stdout] | [INFO] [stdout] 418 | State::Leader { follower_infos } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 426 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `server_id` [INFO] [stdout] --> src/raft.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | server_id: ServerID, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_server_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:461:32 [INFO] [stdout] | [INFO] [stdout] 461 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:476:29 [INFO] [stdout] | [INFO] [stdout] 476 | State::Leader { follower_infos } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:488:29 [INFO] [stdout] | [INFO] [stdout] 488 | State::Follower(follower_state) => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:520:29 [INFO] [stdout] | [INFO] [stdout] 520 | State::Leader { follower_infos } => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:549:29 [INFO] [stdout] | [INFO] [stdout] 549 | State::Follower(follower_state) => unreachable!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:552:32 [INFO] [stdout] | [INFO] [stdout] 552 | State::Candidate { votes_received } => unreachable!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 544 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:647:29 [INFO] [stdout] | [INFO] [stdout] 647 | State::Follower(follower_state) => self.transition_to_candidate(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:648:32 [INFO] [stdout] | [INFO] [stdout] 648 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:651:29 [INFO] [stdout] | [INFO] [stdout] 651 | State::Leader { follower_infos } => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singleton.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(x: X) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Singleton { value: Some(x) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:148:26 [INFO] [stdout] | [INFO] [stdout] 146 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 148 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 149 | | term, [INFO] [stdout] 150 | | server_id, [INFO] [stdout] 151 | | message: Message::VoteAccepted, [INFO] [stdout] 152 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 157 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 159 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 160 | | term, [INFO] [stdout] 161 | | server_id, [INFO] [stdout] 162 | | message: Message::VoteRejected, [INFO] [stdout] 163 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:196:26 [INFO] [stdout] | [INFO] [stdout] 194 | current_leader: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 196 | Operation::OneAction(Singleton::new(Action::ClientRequestRejected { [INFO] [stdout] | __________________________^ [INFO] [stdout] 197 | | current_leader, [INFO] [stdout] 198 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:205:15 [INFO] [stdout] | [INFO] [stdout] 202 | then: Operation, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | then: Box::new(then), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:222:24 [INFO] [stdout] | [INFO] [stdout] 222 | server_id: server_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 224 | message: Message::RequestVote { version }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | server_id: server_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:247:22 [INFO] [stdout] | [INFO] [stdout] 247 | message: Message::ApplyEntriesRequest { [INFO] [stdout] | ______________________^ [INFO] [stdout] 248 | | commit: None, [INFO] [stdout] 249 | | log_version: version, [INFO] [stdout] 250 | | entries: Vec::new(), [INFO] [stdout] 251 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:286:26 [INFO] [stdout] | [INFO] [stdout] 278 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | log_version: LogVersion, [INFO] [stdout] 280 | entries: Vec<(Term, Entry)>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 287 | | term, [INFO] [stdout] 288 | | server_id, [INFO] [stdout] 289 | | message: Message::ApplyEntriesRequest { [INFO] [stdout] ... | [INFO] [stdout] 293 | | }, [INFO] [stdout] 294 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 338 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | servers: HashSet, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | state: State::Follower(FollowerState::Oblivious), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 338 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | servers: HashSet, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | log: L::empty(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:505:43 [INFO] [stdout] | [INFO] [stdout] 505 | .map(|server_id| (server_id.clone(), value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:529:15 [INFO] [stdout] | [INFO] [stdout] 526 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | match self.log.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raft-logic` (lib test) due to 15 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:415:32 [INFO] [stdout] | [INFO] [stdout] 415 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:418:29 [INFO] [stdout] | [INFO] [stdout] 418 | State::Leader { follower_infos } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:426:9 [INFO] [stdout] | [INFO] [stdout] 426 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `server_id` [INFO] [stdout] --> src/raft.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | server_id: ServerID, [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_server_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:461:32 [INFO] [stdout] | [INFO] [stdout] 461 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:476:29 [INFO] [stdout] | [INFO] [stdout] 476 | State::Leader { follower_infos } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:488:29 [INFO] [stdout] | [INFO] [stdout] 488 | State::Follower(follower_state) => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:520:29 [INFO] [stdout] | [INFO] [stdout] 520 | State::Leader { follower_infos } => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:549:29 [INFO] [stdout] | [INFO] [stdout] 549 | State::Follower(follower_state) => unreachable!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:552:32 [INFO] [stdout] | [INFO] [stdout] 552 | State::Candidate { votes_received } => unreachable!( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/raft.rs:544:9 [INFO] [stdout] | [INFO] [stdout] 544 | term: Term, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_state` [INFO] [stdout] --> src/raft.rs:647:29 [INFO] [stdout] | [INFO] [stdout] 647 | State::Follower(follower_state) => self.transition_to_candidate(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_follower_state` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `votes_received` [INFO] [stdout] --> src/raft.rs:648:32 [INFO] [stdout] | [INFO] [stdout] 648 | State::Candidate { votes_received } => { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `votes_received: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `follower_infos` [INFO] [stdout] --> src/raft.rs:651:29 [INFO] [stdout] | [INFO] [stdout] 651 | State::Leader { follower_infos } => do_nothing(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try ignoring the field: `follower_infos: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singleton.rs:19:28 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(x: X) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Singleton { value: Some(x) } [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:148:26 [INFO] [stdout] | [INFO] [stdout] 146 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 148 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 149 | | term, [INFO] [stdout] 150 | | server_id, [INFO] [stdout] 151 | | message: Message::VoteAccepted, [INFO] [stdout] 152 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:159:26 [INFO] [stdout] | [INFO] [stdout] 157 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 159 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 160 | | term, [INFO] [stdout] 161 | | server_id, [INFO] [stdout] 162 | | message: Message::VoteRejected, [INFO] [stdout] 163 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:196:26 [INFO] [stdout] | [INFO] [stdout] 194 | current_leader: Option, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | ) -> Operation<'a, ServerID, Entry> { [INFO] [stdout] 196 | Operation::OneAction(Singleton::new(Action::ClientRequestRejected { [INFO] [stdout] | __________________________^ [INFO] [stdout] 197 | | current_leader, [INFO] [stdout] 198 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:205:15 [INFO] [stdout] | [INFO] [stdout] 202 | then: Operation, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | then: Box::new(then), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:222:24 [INFO] [stdout] | [INFO] [stdout] 222 | server_id: server_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:224:22 [INFO] [stdout] | [INFO] [stdout] 224 | message: Message::RequestVote { version }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 245 | server_id: server_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:247:22 [INFO] [stdout] | [INFO] [stdout] 247 | message: Message::ApplyEntriesRequest { [INFO] [stdout] | ______________________^ [INFO] [stdout] 248 | | commit: None, [INFO] [stdout] 249 | | log_version: version, [INFO] [stdout] 250 | | entries: Vec::new(), [INFO] [stdout] 251 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:286:26 [INFO] [stdout] | [INFO] [stdout] 278 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | log_version: LogVersion, [INFO] [stdout] 280 | entries: Vec<(Term, Entry)>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | Operation::OneAction(Singleton::new(Action::SendMessage { [INFO] [stdout] | __________________________^ [INFO] [stdout] 287 | | term, [INFO] [stdout] 288 | | server_id, [INFO] [stdout] 289 | | message: Message::ApplyEntriesRequest { [INFO] [stdout] ... | [INFO] [stdout] 293 | | }, [INFO] [stdout] 294 | | })) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 338 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | servers: HashSet, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 345 | state: State::Follower(FollowerState::Oblivious), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:346:18 [INFO] [stdout] | [INFO] [stdout] 338 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | servers: HashSet, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | log: L::empty(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:505:43 [INFO] [stdout] | [INFO] [stdout] 505 | .map(|server_id| (server_id.clone(), value.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/raft.rs:529:15 [INFO] [stdout] | [INFO] [stdout] 526 | server_id: ServerID, [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | match self.log.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raft-logic` (lib) due to 15 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "39221866c4554d0a1d8cd68bfdd1da2c270287b9dc9814a29df2df4f11467985", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39221866c4554d0a1d8cd68bfdd1da2c270287b9dc9814a29df2df4f11467985", kill_on_drop: false }` [INFO] [stdout] 39221866c4554d0a1d8cd68bfdd1da2c270287b9dc9814a29df2df4f11467985