[INFO] cloning repository https://github.com/daniel5151/ray-tracing-in-1-weekend [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daniel5151/ray-tracing-in-1-weekend" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel5151%2Fray-tracing-in-1-weekend", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel5151%2Fray-tracing-in-1-weekend'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 893a0d66a917beec69d6c33ca7230a82a5d92cac [INFO] checking daniel5151/ray-tracing-in-1-weekend/893a0d66a917beec69d6c33ca7230a82a5d92cac against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel5151%2Fray-tracing-in-1-weekend" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/daniel5151/ray-tracing-in-1-weekend on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/daniel5151/ray-tracing-in-1-weekend [INFO] finished tweaking git repo https://github.com/daniel5151/ray-tracing-in-1-weekend [INFO] tweaked toml for git repo https://github.com/daniel5151/ray-tracing-in-1-weekend written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/daniel5151/ray-tracing-in-1-weekend already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d33cabb27e29ffc57210bbb83212bfe8c3159ec161d4a055623f5bbef0e3be0 [INFO] running `Command { std: "docker" "start" "-a" "3d33cabb27e29ffc57210bbb83212bfe8c3159ec161d4a055623f5bbef0e3be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d33cabb27e29ffc57210bbb83212bfe8c3159ec161d4a055623f5bbef0e3be0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d33cabb27e29ffc57210bbb83212bfe8c3159ec161d4a055623f5bbef0e3be0", kill_on_drop: false }` [INFO] [stdout] 3d33cabb27e29ffc57210bbb83212bfe8c3159ec161d4a055623f5bbef0e3be0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2a8c5129286e217ff876189fdc4b545251ac05fca0420e0f35cf45a66cded00e [INFO] running `Command { std: "docker" "start" "-a" "2a8c5129286e217ff876189fdc4b545251ac05fca0420e0f35cf45a66cded00e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling cc v1.0.38 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Compiling x11-dl v2.18.3 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Compiling minifb v0.12.0 [INFO] [stderr] Checking getrandom v0.1.7 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking vrai-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/scenes/random.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | _ => (material::Dielectric::new_material(1.5)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - _ => (material::Dielectric::new_material(1.5)), [INFO] [stdout] 67 + _ => material::Dielectric::new_material(1.5), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around match arm expression [INFO] [stdout] --> src/scenes/random.rs:67:26 [INFO] [stdout] | [INFO] [stdout] 67 | _ => (material::Dielectric::new_material(1.5)), [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 67 - _ => (material::Dielectric::new_material(1.5)), [INFO] [stdout] 67 + _ => material::Dielectric::new_material(1.5), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/scenes/random.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 51 | (material::Lambertian::new_material(Vec3::new( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 55 | ))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 51 ~ material::Lambertian::new_material(Vec3::new( [INFO] [stdout] 52 | rng.gen::() * rng.gen::(), [INFO] [stdout] 53 | rng.gen::() * rng.gen::(), [INFO] [stdout] 54 | rng.gen::() * rng.gen::(), [INFO] [stdout] 55 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/scenes/random.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 51 | (material::Lambertian::new_material(Vec3::new( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 55 | ))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 51 ~ material::Lambertian::new_material(Vec3::new( [INFO] [stdout] 52 | rng.gen::() * rng.gen::(), [INFO] [stdout] 53 | rng.gen::() * rng.gen::(), [INFO] [stdout] 54 | rng.gen::() * rng.gen::(), [INFO] [stdout] 55 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/scenes/random.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | (material::Metal::new_material( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 65 | )) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 ~ material::Metal::new_material( [INFO] [stdout] 59 | 0.5 * Vec3::new( [INFO] [stdout] ... [INFO] [stdout] 64 | 0.5 * rng.gen::(), [INFO] [stdout] 65 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/scenes/random.rs:58:25 [INFO] [stdout] | [INFO] [stdout] 58 | (material::Metal::new_material( [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 65 | )) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 58 ~ material::Metal::new_material( [INFO] [stdout] 59 | 0.5 * Vec3::new( [INFO] [stdout] ... [INFO] [stdout] 64 | 0.5 * rng.gen::(), [INFO] [stdout] 65 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/infplane.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_hittable(center: Vec3, normal: Vec3, material: MaterialT) -> HittableT { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / InfPlane { [INFO] [stdout] 21 | | center, [INFO] [stdout] 22 | | normal, [INFO] [stdout] 23 | | material, [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/sphere.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_hittable(center: Vec3, radius: f32, material: MaterialT) -> HittableT { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / Sphere { [INFO] [stdout] 21 | | center, [INFO] [stdout] 22 | | radius, [INFO] [stdout] 23 | | material, [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/nonblocking.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 56 | progress_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | thread_rx: mpsc::Receiver<(usize, ThreadProgress)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread_term_tx: Vec>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | progress_rx: Some(progress_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/nonblocking.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 56 | progress_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | thread_rx: mpsc::Receiver<(usize, ThreadProgress)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread_term_tx: Vec>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | thread_rx: Some(thread_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vrai-tracer` (bin "vrai-tracer" test) due to 5 previous errors; 3 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/infplane.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_hittable(center: Vec3, normal: Vec3, material: MaterialT) -> HittableT { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / InfPlane { [INFO] [stdout] 21 | | center, [INFO] [stdout] 22 | | normal, [INFO] [stdout] 23 | | material, [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/hittable/sphere.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_hittable(center: Vec3, radius: f32, material: MaterialT) -> HittableT { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | / Sphere { [INFO] [stdout] 21 | | center, [INFO] [stdout] 22 | | radius, [INFO] [stdout] 23 | | material, [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/nonblocking.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 56 | progress_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | thread_rx: mpsc::Receiver<(usize, ThreadProgress)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread_term_tx: Vec>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | progress_rx: Some(progress_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/nonblocking.rs:65:24 [INFO] [stdout] | [INFO] [stdout] 56 | progress_rx: mpsc::Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | thread_rx: mpsc::Receiver<(usize, ThreadProgress)>, [INFO] [stdout] | -------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | thread_term_tx: Vec>, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | thread_rx: Some(thread_rx), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vrai-tracer` (bin "vrai-tracer") due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2a8c5129286e217ff876189fdc4b545251ac05fca0420e0f35cf45a66cded00e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a8c5129286e217ff876189fdc4b545251ac05fca0420e0f35cf45a66cded00e", kill_on_drop: false }` [INFO] [stdout] 2a8c5129286e217ff876189fdc4b545251ac05fca0420e0f35cf45a66cded00e