[INFO] cloning repository https://github.com/daniel-j-anderson-dev/leetcode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daniel-j-anderson-dev/leetcode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-j-anderson-dev%2Fleetcode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-j-anderson-dev%2Fleetcode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bba54fcfe703dfa69a21857ebaca23fcb2f7ecc8 [INFO] checking daniel-j-anderson-dev/leetcode/bba54fcfe703dfa69a21857ebaca23fcb2f7ecc8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-j-anderson-dev%2Fleetcode" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/daniel-j-anderson-dev/leetcode on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/daniel-j-anderson-dev/leetcode [INFO] finished tweaking git repo https://github.com/daniel-j-anderson-dev/leetcode [INFO] tweaked toml for git repo https://github.com/daniel-j-anderson-dev/leetcode written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/daniel-j-anderson-dev/leetcode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5723b753733b9ae544be1d8828c5f432cefd4b8e3c0a3f0c186e6f380b1a0c60 [INFO] running `Command { std: "docker" "start" "-a" "5723b753733b9ae544be1d8828c5f432cefd4b8e3c0a3f0c186e6f380b1a0c60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5723b753733b9ae544be1d8828c5f432cefd4b8e3c0a3f0c186e6f380b1a0c60", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5723b753733b9ae544be1d8828c5f432cefd4b8e3c0a3f0c186e6f380b1a0c60", kill_on_drop: false }` [INFO] [stdout] 5723b753733b9ae544be1d8828c5f432cefd4b8e3c0a3f0c186e6f380b1a0c60 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 48abc36c72e0abf000dd05d3f571ec9339704c02caef0630717bcd6c5c979be1 [INFO] running `Command { std: "docker" "start" "-a" "48abc36c72e0abf000dd05d3f571ec9339704c02caef0630717bcd6c5c979be1", kill_on_drop: false }` [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking leetcode v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: function `median` is never used [INFO] [stdout] --> examples/median_of_two_sorted_arrays.rs:30:4 [INFO] [stdout] | [INFO] [stdout] 30 | fn median(nums1: Vec, nums2: Vec) -> f64 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `longest` [INFO] [stdout] --> examples/longest_substring_wihtout_repeating_characters.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut longest = ""; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_longest` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> examples/longest_substring_wihtout_repeating_characters.rs:73:9 [INFO] [stdout] | [INFO] [stdout] 73 | let mut longest = ""; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `length_of_longest_substring_without_repeats_loops` is never used [INFO] [stdout] --> examples/longest_substring_wihtout_repeating_characters.rs:71:4 [INFO] [stdout] | [INFO] [stdout] 71 | fn length_of_longest_substring_without_repeats_loops(s: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `length_of_longest_substring_without_repeats` is never used [INFO] [stdout] --> examples/longest_substring_wihtout_repeating_characters.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn length_of_longest_substring_without_repeats(s: &str) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `minimum_boxes` is never used [INFO] [stdout] --> examples/building_boxes_1739.rs:200:12 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn minimum_boxes(n: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all_indexes` is never used [INFO] [stdout] --> examples/building_boxes_1739.rs:221:8 [INFO] [stdout] | [INFO] [stdout] 221 | fn all_indexes(len: usize) -> impl ParallelIterator { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `valid_indexes` is never used [INFO] [stdout] --> examples/building_boxes_1739.rs:229:8 [INFO] [stdout] | [INFO] [stdout] 229 | fn valid_indexes<'a>( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_best_index` is never used [INFO] [stdout] --> examples/building_boxes_1739.rs:274:8 [INFO] [stdout] | [INFO] [stdout] 274 | fn find_best_index( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_to_vec` is never used [INFO] [stdout] --> examples/add_two_numbers.rs:56:4 [INFO] [stdout] | [INFO] [stdout] 56 | fn list_to_vec(val: Box) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_into_iter` is never used [INFO] [stdout] --> examples/add_two_numbers.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn list_into_iter(val: Box) -> impl Iterator> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_from_iter` is never used [INFO] [stdout] --> examples/add_two_numbers.rs:62:4 [INFO] [stdout] | [INFO] [stdout] 62 | fn list_from_iter>(iter: I) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `list_from_usize` is never used [INFO] [stdout] --> examples/add_two_numbers.rs:75:4 [INFO] [stdout] | [INFO] [stdout] 75 | fn list_from_usize(value: usize) -> Box { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `add` is never used [INFO] [stdout] --> examples/add_two_numbers.rs:91:4 [INFO] [stdout] | [INFO] [stdout] 91 | fn add(l1: Option>, l2: Option>) -> Option> { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/add_two_numbers.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 56 | fn list_to_vec(val: Box) -> Vec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | list_into_iter(val).map(|node| node.val).collect::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/add_two_numbers.rs:60:14 [INFO] [stdout] | [INFO] [stdout] 59 | fn list_into_iter(val: Box) -> impl Iterator> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | NodeIter(Some(val)) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/add_two_numbers.rs:130:10 [INFO] [stdout] | [INFO] [stdout] 91 | fn add(l1: Option>, l2: Option>) -> Option> { [INFO] [stdout] | ------------------------- ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Some(list_from_iter(sum.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `leetcode` (example "add_two_numbers") due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "48abc36c72e0abf000dd05d3f571ec9339704c02caef0630717bcd6c5c979be1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "48abc36c72e0abf000dd05d3f571ec9339704c02caef0630717bcd6c5c979be1", kill_on_drop: false }` [INFO] [stdout] 48abc36c72e0abf000dd05d3f571ec9339704c02caef0630717bcd6c5c979be1