[INFO] cloning repository https://github.com/daniel-dimovski/ggpk [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/daniel-dimovski/ggpk" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-dimovski%2Fggpk", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-dimovski%2Fggpk'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 06c571c1f63c139ba7bbb9f8967ee59a1fbd482a [INFO] checking daniel-dimovski/ggpk/06c571c1f63c139ba7bbb9f8967ee59a1fbd482a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdaniel-dimovski%2Fggpk" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/daniel-dimovski/ggpk on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/daniel-dimovski/ggpk [INFO] finished tweaking git repo https://github.com/daniel-dimovski/ggpk [INFO] tweaked toml for git repo https://github.com/daniel-dimovski/ggpk written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/daniel-dimovski/ggpk already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aae9b23ee214d0721c23bf0b7a5a6e0c97f3761110f46ebe092af1c29c8c2c8a [INFO] running `Command { std: "docker" "start" "-a" "aae9b23ee214d0721c23bf0b7a5a6e0c97f3761110f46ebe092af1c29c8c2c8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aae9b23ee214d0721c23bf0b7a5a6e0c97f3761110f46ebe092af1c29c8c2c8a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aae9b23ee214d0721c23bf0b7a5a6e0c97f3761110f46ebe092af1c29c8c2c8a", kill_on_drop: false }` [INFO] [stdout] aae9b23ee214d0721c23bf0b7a5a6e0c97f3761110f46ebe092af1c29c8c2c8a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c2fa8e42fb7167367778cc603dc6990a2f0e3ad8843c119953deeedf76501b0 [INFO] running `Command { std: "docker" "start" "-a" "8c2fa8e42fb7167367778cc603dc6990a2f0e3ad8843c119953deeedf76501b0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.134 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.11 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking itoa v1.0.4 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking widestring v1.0.2 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking time v0.3.15 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking simplelog v0.12.0 [INFO] [stderr] Checking ggpk v1.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mmap = util::to_mmap_unsafe(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(GGPK { mmap, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|_| c.read_u64::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:189:18 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|_| c.read_u16::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:197:18 [INFO] [stdout] | [INFO] [stdout] 197 | .map(|_| c.read_u32::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | .unwrap_or_else(|| Err(Error::new(InvalidData, "Read outside GGPK"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | .unwrap_or_else(|| Err(Error::new(InvalidData, "Read outside GGPK"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ggpk` (lib test) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 28 | let mmap = util::to_mmap_unsafe(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(GGPK { mmap, version }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:87:26 [INFO] [stdout] | [INFO] [stdout] 87 | .map(|_| c.read_u64::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:189:18 [INFO] [stdout] | [INFO] [stdout] 189 | .map(|_| c.read_u16::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ggpk.rs:197:18 [INFO] [stdout] | [INFO] [stdout] 197 | .map(|_| c.read_u32::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | .unwrap_or_else(|| Err(Error::new(InvalidData, "Read outside GGPK"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:33:36 [INFO] [stdout] | [INFO] [stdout] 33 | .unwrap_or_else(|| Err(Error::new(InvalidData, "Read outside GGPK"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ggpk` (lib) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "8c2fa8e42fb7167367778cc603dc6990a2f0e3ad8843c119953deeedf76501b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c2fa8e42fb7167367778cc603dc6990a2f0e3ad8843c119953deeedf76501b0", kill_on_drop: false }` [INFO] [stdout] 8c2fa8e42fb7167367778cc603dc6990a2f0e3ad8843c119953deeedf76501b0