[INFO] cloning repository https://github.com/dandels/dmodman [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dandels/dmodman" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdandels%2Fdmodman", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdandels%2Fdmodman'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54a02745a0a7e27488bd834c0885410036d64087 [INFO] checking dandels/dmodman/54a02745a0a7e27488bd834c0885410036d64087 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdandels%2Fdmodman" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dandels/dmodman on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dandels/dmodman [INFO] finished tweaking git repo https://github.com/dandels/dmodman [INFO] tweaked toml for git repo https://github.com/dandels/dmodman written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dandels/dmodman already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5d257bcf0857974d77aabef6234d0c20e413e431d220c33f848639d9e9efb423 [INFO] running `Command { std: "docker" "start" "-a" "5d257bcf0857974d77aabef6234d0c20e413e431d220c33f848639d9e9efb423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5d257bcf0857974d77aabef6234d0c20e413e431d220c33f848639d9e9efb423", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5d257bcf0857974d77aabef6234d0c20e413e431d220c33f848639d9e9efb423", kill_on_drop: false }` [INFO] [stdout] 5d257bcf0857974d77aabef6234d0c20e413e431d220c33f848639d9e9efb423 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09a2d33ad2f6fe73e0b0b3e30b6ac56b3bb56c9121e6105b335563e90fb70d82 [INFO] running `Command { std: "docker" "start" "-a" "09a2d33ad2f6fe73e0b0b3e30b6ac56b3bb56c9121e6105b335563e90fb70d82", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling pkg-config v0.3.29 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling ahash v0.8.8 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling openssl v0.10.63 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking indexmap v2.2.3 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking http v0.2.11 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling openssl-sys v0.9.99 [INFO] [stderr] Checking castaway v0.2.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking compact_str v0.7.1 [INFO] [stderr] Checking termion v3.0.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking lru v0.12.2 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling compress-tools v0.13.0 [INFO] [stderr] Checking http v1.0.0 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking winnow v0.5.39 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking termion v2.0.3 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling strum_macros v0.26.1 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling stability v0.1.1 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking strum v0.26.1 [INFO] [stderr] Checking ratatui v0.26.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tui-textarea v0.4.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking signal-hook-tokio v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.14 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking toml_edit v0.22.4 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking toml v0.8.10 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.24 [INFO] [stderr] Checking dmodman v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Ordering` [INFO] [stdout] --> src/ui/component/popup_dialog.rs:4:37 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::atomic::{AtomicBool, Ordering}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Ordering` [INFO] [stdout] --> src/ui/component/popup_dialog.rs:4:37 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::atomic::{AtomicBool, Ordering}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `url`, `key`, `expires`, and `user_id` are never read [INFO] [stdout] --> src/api/downloads/nxm_url.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NxmUrl { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 10 | pub url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | pub expires: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub user_id: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NxmUrl` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `needs_redraw` is never read [INFO] [stdout] --> src/ui/component/bottom_bar.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct BottomBar<'a> { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub needs_redraw: AtomicBool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `needs_redraw` and `redraw_terminal` are never read [INFO] [stdout] --> src/ui/component/popup_dialog.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct PopupDialog<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 9 | pub textarea: TextArea<'a>, [INFO] [stdout] 10 | pub needs_redraw: AtomicBool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | redraw_terminal: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `highlight_style` is never read [INFO] [stdout] --> src/ui/component/tabbar.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TabBar<'a> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 9 | pub widget: Tabs<'a>, [INFO] [stdout] 10 | pub highlight_style: Style, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `deselect` is never used [INFO] [stdout] --> src/ui/component/traits/select.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub trait Select { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 52 | fn deselect(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/client.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 64 | let api_headers = match &*self.api_headers { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(self.client.get(url).headers(api_headers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | cache: cache.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | client: client.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | logger: logger.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | join_handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/query/queriable.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 16 | let resp = client.send_api_request(&endpoint).await?.error_for_status()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | move || async move { Ok(serde_json::from_value::(resp.json().await.unwrap()).unwrap()) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/update_checker.rs:258:15 [INFO] [stdout] | [INFO] [stdout] 253 | let cache = Cache::new(&config).await.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let client = Client::new(&config).await; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | let logger = Logger::default(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 256 | let updater = UpdateChecker::new(cache.clone(), client, config, logger); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | [INFO] [stdout] 258 | match updater.refresh_filelist(game, mod_id).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archives/mod.rs:68:42 [INFO] [stdout] | [INFO] [stdout] 67 | let logger = self.logger.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | std::thread::spawn(move || match File::open(&src_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/file_index.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 50 | dir_entries.sort_by_key(|f| match f.metadata() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/bottom_bar.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(redraw_terminal: Arc, request_counter: RequestCounter) -> Self { [INFO] [stdout] | -------------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | request_counter: request_counter.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/file_table.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(redraw_terminal: Arc, file_index: FileIndex) -> Self { [INFO] [stdout] | -------------------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let has_data_changed = file_index.has_changed.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file_index: file_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/log_list.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(redraw_terminal: Arc, logger: Logger) -> Self { [INFO] [stdout] | -------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | logger: logger.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmodman` (bin "dmodman" test) due to 13 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `url`, `key`, `expires`, and `user_id` are never read [INFO] [stdout] --> src/api/downloads/nxm_url.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct NxmUrl { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 10 | pub url: Url, [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | pub key: String, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | pub expires: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 17 | pub user_id: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `NxmUrl` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `needs_redraw` is never read [INFO] [stdout] --> src/ui/component/bottom_bar.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct BottomBar<'a> { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | pub needs_redraw: AtomicBool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `needs_redraw` and `redraw_terminal` are never read [INFO] [stdout] --> src/ui/component/popup_dialog.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct PopupDialog<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 9 | pub textarea: TextArea<'a>, [INFO] [stdout] 10 | pub needs_redraw: AtomicBool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 11 | redraw_terminal: Arc, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `highlight_style` is never read [INFO] [stdout] --> src/ui/component/tabbar.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct TabBar<'a> { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] 9 | pub widget: Tabs<'a>, [INFO] [stdout] 10 | pub highlight_style: Style, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `deselect` is never used [INFO] [stdout] --> src/ui/component/traits/select.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 45 | pub trait Select { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] ... [INFO] [stdout] 52 | fn deselect(&mut self) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/client.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 64 | let api_headers = match &*self.api_headers { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | Ok(self.client.get(url).headers(api_headers)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:41:20 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | cache: cache.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | client: client.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | logger: logger.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/downloads/download_task.rs:47:26 [INFO] [stdout] | [INFO] [stdout] 37 | dl_info: DownloadInfo, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | downloads: Downloads, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | join_handle: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/api/query/queriable.rs:20:37 [INFO] [stdout] | [INFO] [stdout] 16 | let resp = client.send_api_request(&endpoint).await?.error_for_status()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | move || async move { Ok(serde_json::from_value::(resp.json().await.unwrap()).unwrap()) }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/archives/mod.rs:68:42 [INFO] [stdout] | [INFO] [stdout] 67 | let logger = self.logger.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | std::thread::spawn(move || match File::open(&src_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache/file_index.rs:50:43 [INFO] [stdout] | [INFO] [stdout] 50 | dir_entries.sort_by_key(|f| match f.metadata() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/bottom_bar.rs:20:30 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(redraw_terminal: Arc, request_counter: RequestCounter) -> Self { [INFO] [stdout] | -------------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | request_counter: request_counter.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/file_table.rs:45:25 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(redraw_terminal: Arc, file_index: FileIndex) -> Self { [INFO] [stdout] | -------------------------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let has_data_changed = file_index.has_changed.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | file_index: file_index.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/component/log_list.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(redraw_terminal: Arc, logger: Logger) -> Self { [INFO] [stdout] | -------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | logger: logger.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmodman` (bin "dmodman") due to 12 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "09a2d33ad2f6fe73e0b0b3e30b6ac56b3bb56c9121e6105b335563e90fb70d82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09a2d33ad2f6fe73e0b0b3e30b6ac56b3bb56c9121e6105b335563e90fb70d82", kill_on_drop: false }` [INFO] [stdout] 09a2d33ad2f6fe73e0b0b3e30b6ac56b3bb56c9121e6105b335563e90fb70d82