[INFO] cloning repository https://github.com/damoonrashidi/action-chess [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/damoonrashidi/action-chess" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamoonrashidi%2Faction-chess", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamoonrashidi%2Faction-chess'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a379338aeefd1235c5eb755e57e41030ac53a8b2 [INFO] checking damoonrashidi/action-chess/a379338aeefd1235c5eb755e57e41030ac53a8b2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdamoonrashidi%2Faction-chess" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/damoonrashidi/action-chess on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/damoonrashidi/action-chess [INFO] finished tweaking git repo https://github.com/damoonrashidi/action-chess [INFO] tweaked toml for git repo https://github.com/damoonrashidi/action-chess written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/damoonrashidi/action-chess already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29fea3adc49f47953040985f76e31ad83a91e8e71eabad77057efc1e6a4ea6e6 [INFO] running `Command { std: "docker" "start" "-a" "29fea3adc49f47953040985f76e31ad83a91e8e71eabad77057efc1e6a4ea6e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29fea3adc49f47953040985f76e31ad83a91e8e71eabad77057efc1e6a4ea6e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29fea3adc49f47953040985f76e31ad83a91e8e71eabad77057efc1e6a4ea6e6", kill_on_drop: false }` [INFO] [stdout] 29fea3adc49f47953040985f76e31ad83a91e8e71eabad77057efc1e6a4ea6e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4354aa0c29c4de9e0c6e47d06f8d4013831779b6470257b4b3216fcd1a2efe4e [INFO] running `Command { std: "docker" "start" "-a" "4354aa0c29c4de9e0c6e47d06f8d4013831779b6470257b4b3216fcd1a2efe4e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling rustix v0.38.21 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking state v0.1.0 (/opt/rustwide/workdir/state) [INFO] [stderr] Checking network v0.1.0 (/opt/rustwide/workdir/network) [INFO] [stderr] Checking chess_client v0.1.0 (/opt/rustwide/workdir/chess_client) [INFO] [stderr] Checking server v0.1.0 (/opt/rustwide/workdir/server) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> chess_client/src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | let connection = UdpSocket::bind(format!("127.0.0.1:{port}"))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | connection.connect(host)?; [INFO] [stdout] 22 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> chess_client/src/lib.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 20 | let connection = UdpSocket::bind(format!("127.0.0.1:{port}"))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | connection.connect(host)?; [INFO] [stdout] 22 | Ok(Self { connection }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chess_client` (lib) due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/main.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 28 | let world = Arc::clone(world); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | if let Ok(mut world) = world.lock() { [INFO] [stdout] 31 | | for game in world.games_mut() { [INFO] [stdout] 32 | | game.tick(); [INFO] [stdout] ... | [INFO] [stdout] 35 | | thread::sleep(BOARD_TICK_RATE); [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/main.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 41 | socket: UdpSocket, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> JoinHandle> { [INFO] [stdout] 43 | let world = Arc::clone(world); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | thread::spawn(move || -> std::io::Result<()> { [INFO] [stdout] | ___________________^ [INFO] [stdout] 45 | | loop { [INFO] [stdout] 46 | | let mut msg: [u8; 4] = [0, 0, 0, 0]; [INFO] [stdout] 47 | | let (_, addr) = socket.recv_from(&mut msg)?; [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/world/mod.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self { [INFO] [stdout] 21 | games: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chess_client` (lib test) due to 2 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/main.rs:29:19 [INFO] [stdout] | [INFO] [stdout] 28 | let world = Arc::clone(world); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | thread::spawn(move || loop { [INFO] [stdout] | ___________________^ [INFO] [stdout] 30 | | if let Ok(mut world) = world.lock() { [INFO] [stdout] 31 | | for game in world.games_mut() { [INFO] [stdout] 32 | | game.tick(); [INFO] [stdout] ... | [INFO] [stdout] 35 | | thread::sleep(BOARD_TICK_RATE); [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/main.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 41 | socket: UdpSocket, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | ) -> JoinHandle> { [INFO] [stdout] 43 | let world = Arc::clone(world); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | thread::spawn(move || -> std::io::Result<()> { [INFO] [stdout] | ___________________^ [INFO] [stdout] 45 | | loop { [INFO] [stdout] 46 | | let mut msg: [u8; 4] = [0, 0, 0, 0]; [INFO] [stdout] 47 | | let (_, addr) = socket.recv_from(&mut msg)?; [INFO] [stdout] ... | [INFO] [stdout] 55 | | } [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> server/world/mod.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 19 | pub(crate) fn new(socket: UdpSocket) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Self { [INFO] [stdout] 21 | games: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `server` (bin "server" test) due to 4 previous errors [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `server` (bin "server") due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4354aa0c29c4de9e0c6e47d06f8d4013831779b6470257b4b3216fcd1a2efe4e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4354aa0c29c4de9e0c6e47d06f8d4013831779b6470257b4b3216fcd1a2efe4e", kill_on_drop: false }` [INFO] [stdout] 4354aa0c29c4de9e0c6e47d06f8d4013831779b6470257b4b3216fcd1a2efe4e