[INFO] cloning repository https://github.com/dalloriam/jd [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dalloriam/jd" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalloriam%2Fjd", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalloriam%2Fjd'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 40a15845b952d409af7bc51d5437ea391a4b09e6 [INFO] checking dalloriam/jd/40a15845b952d409af7bc51d5437ea391a4b09e6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdalloriam%2Fjd" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dalloriam/jd on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dalloriam/jd [INFO] finished tweaking git repo https://github.com/dalloriam/jd [INFO] tweaked toml for git repo https://github.com/dalloriam/jd written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dalloriam/jd already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec2a6d489ba8b49d0c71db4dac6f6e48e570fd8b425dfa7eb08972df7f6e5c76 [INFO] running `Command { std: "docker" "start" "-a" "ec2a6d489ba8b49d0c71db4dac6f6e48e570fd8b425dfa7eb08972df7f6e5c76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec2a6d489ba8b49d0c71db4dac6f6e48e570fd8b425dfa7eb08972df7f6e5c76", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec2a6d489ba8b49d0c71db4dac6f6e48e570fd8b425dfa7eb08972df7f6e5c76", kill_on_drop: false }` [INFO] [stdout] ec2a6d489ba8b49d0c71db4dac6f6e48e570fd8b425dfa7eb08972df7f6e5c76 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0ac4416c36659bfb3e1c0091f112b58309c5a3d3c4437a15f99332e081e8983 [INFO] running `Command { std: "docker" "start" "-a" "b0ac4416c36659bfb3e1c0091f112b58309c5a3d3c4437a15f99332e081e8983", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling syn v1.0.77 [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking pathdiff v0.2.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling litrs v0.2.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking open v2.0.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking fs_extra v1.2.0 [INFO] [stderr] Checking dirs-sys v0.3.6 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling bunt-macros v0.2.5 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking bunt v0.2.6 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling snafu-derive v0.6.10 [INFO] [stderr] Compiling clap_derive v3.0.6 [INFO] [stderr] Checking snafu v0.6.10 [INFO] [stderr] Checking clap v3.0.10 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking polyglot v0.2.1 [INFO] [stderr] Checking cfgloader v0.1.1 [INFO] [stderr] Checking jd v0.2.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/client.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 18 | let index = Box::new(Index::load(&config.index_path).unwrap_or_default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let mut resolvers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | config, [INFO] [stdout] 34 | | index, [INFO] [stdout] 35 | | resolvers, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 14 | fn from_vec<'de, D>(deserializer: D) -> std::result::Result<[Option>; 1000], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let v: Vec>> = Deserialize::deserialize(deserializer)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | v.try_into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:132:23 [INFO] [stdout] | [INFO] [stdout] 132 | .map(|i| *i.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jd` (lib) due to 5 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn load>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let f = fs::File::open(path.as_ref())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Ok(serde_json::from_reader(f)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/client.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 18 | let index = Box::new(Index::load(&config.index_path).unwrap_or_default()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let mut resolvers = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | config, [INFO] [stdout] 34 | | index, [INFO] [stdout] 35 | | resolvers, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 14 | fn from_vec<'de, D>(deserializer: D) -> std::result::Result<[Option>; 1000], D::Error> [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let v: Vec>> = Deserialize::deserialize(deserializer)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | v.try_into() [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:132:23 [INFO] [stdout] | [INFO] [stdout] 132 | .map(|i| *i.clone()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/johnny/index.rs:249:12 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn load>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | let f = fs::File::open(path.as_ref())?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Ok(serde_json::from_reader(f)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `jd` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b0ac4416c36659bfb3e1c0091f112b58309c5a3d3c4437a15f99332e081e8983", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0ac4416c36659bfb3e1c0091f112b58309c5a3d3c4437a15f99332e081e8983", kill_on_drop: false }` [INFO] [stdout] b0ac4416c36659bfb3e1c0091f112b58309c5a3d3c4437a15f99332e081e8983