[INFO] cloning repository https://github.com/dacid44/r_place_data [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dacid44/r_place_data" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdacid44%2Fr_place_data", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdacid44%2Fr_place_data'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ba778a2e321a02688fc7ce9c2fd0f41a53da31db [INFO] checking dacid44/r_place_data/ba778a2e321a02688fc7ce9c2fd0f41a53da31db against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdacid44%2Fr_place_data" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/dacid44/r_place_data on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/dacid44/r_place_data [INFO] finished tweaking git repo https://github.com/dacid44/r_place_data [INFO] tweaked toml for git repo https://github.com/dacid44/r_place_data written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/dacid44/r_place_data already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb073d1e45bfbfe300b17f6014da45a8489bb0789cc5e9511cf60f64090ce615 [INFO] running `Command { std: "docker" "start" "-a" "fb073d1e45bfbfe300b17f6014da45a8489bb0789cc5e9511cf60f64090ce615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb073d1e45bfbfe300b17f6014da45a8489bb0789cc5e9511cf60f64090ce615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb073d1e45bfbfe300b17f6014da45a8489bb0789cc5e9511cf60f64090ce615", kill_on_drop: false }` [INFO] [stdout] fb073d1e45bfbfe300b17f6014da45a8489bb0789cc5e9511cf60f64090ce615 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b29a44f7b488d385ee5293f0903f7566502ce54d2fa3f3dbfc8f2f4f642a21b1 [INFO] running `Command { std: "docker" "start" "-a" "b29a44f7b488d385ee5293f0903f7566502ce54d2fa3f3dbfc8f2f4f642a21b1", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.3 [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling once_cell v1.10.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.2 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling unindent v0.1.8 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking matrixmultiply v0.3.2 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Compiling indoc v1.0.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Compiling pyo3-build-config v0.16.3 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking ndarray v0.15.4 [INFO] [stderr] Checking regex v1.5.5 [INFO] [stderr] Compiling pyo3-ffi v0.16.3 [INFO] [stderr] Compiling pyo3 v0.16.3 [INFO] [stderr] Compiling pyo3-macros-backend v0.16.3 [INFO] [stderr] Compiling pyo3-macros v0.16.3 [INFO] [stderr] Checking numpy v0.16.2 [INFO] [stderr] Checking r_place_data v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::Compression` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use flate2::Compression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::write::GzEncoder` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use flate2::write::GzEncoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::PlaceData` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::data::PlaceData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `max` and `min` [INFO] [stdout] --> src/data.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp::{max, min}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/data.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayViewMut` and `s` [INFO] [stdout] --> src/data.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | use ndarray::{ArrayViewMut, s}; [INFO] [stdout] | ^^^^^^^^^^^^ ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EntryError` [INFO] [stdout] --> src/parser.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::data::{DrawType, EntryError, PlaceEntry}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::fs::File` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::fs::File; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/main.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::io::Write` [INFO] [stdout] --> src/main.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::Write; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::Compression` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use flate2::Compression; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `flate2::write::GzEncoder` [INFO] [stdout] --> src/main.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use flate2::write::GzEncoder; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::data::PlaceData` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::data::PlaceData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `max` and `min` [INFO] [stdout] --> src/data.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp::{max, min}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/data.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayViewMut` and `s` [INFO] [stdout] --> src/data.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | use ndarray::{ArrayViewMut, s}; [INFO] [stdout] | ^^^^^^^^^^^^ ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EntryError` [INFO] [stdout] --> src/parser.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::data::{DrawType, EntryError, PlaceEntry}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pyo3::exceptions::PyValueError` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use pyo3::exceptions::PyValueError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PyArray`, `PyReadonlyArray2`, and `ToPyArray` [INFO] [stdout] --> src/lib.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use numpy::{ToPyArray, PyArray, IntoPyArray, PyArray2, PyReadonlyArray2}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `max` and `min` [INFO] [stdout] --> src/data.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp::{max, min}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/data.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayViewMut` and `s` [INFO] [stdout] --> src/data.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | use ndarray::{ArrayViewMut, s}; [INFO] [stdout] | ^^^^^^^^^^^^ ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EntryError` [INFO] [stdout] --> src/parser.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::data::{DrawType, EntryError, PlaceEntry}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pyo3::exceptions::PyValueError` [INFO] [stdout] --> src/lib.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use pyo3::exceptions::PyValueError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PyArray`, `PyReadonlyArray2`, and `ToPyArray` [INFO] [stdout] --> src/lib.rs:5:13 [INFO] [stdout] | [INFO] [stdout] 5 | use numpy::{ToPyArray, PyArray, IntoPyArray, PyArray2, PyReadonlyArray2}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `max` and `min` [INFO] [stdout] --> src/data.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use std::cmp::{max, min}; [INFO] [stdout] | ^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/data.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `ArrayViewMut` and `s` [INFO] [stdout] --> src/data.rs:12:15 [INFO] [stdout] | [INFO] [stdout] 12 | use ndarray::{ArrayViewMut, s}; [INFO] [stdout] | ^^^^^^^^^^^^ ^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `EntryError` [INFO] [stdout] --> src/parser.rs:9:29 [INFO] [stdout] | [INFO] [stdout] 9 | use crate::data::{DrawType, EntryError, PlaceEntry}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rect` [INFO] [stdout] --> src/data.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rect` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x1` [INFO] [stdout] --> src/data.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/data.rs:204:40 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x2` [INFO] [stdout] --> src/data.rs:204:44 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/data.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rect` [INFO] [stdout] --> src/data.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rect` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x1` [INFO] [stdout] --> src/data.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/data.rs:204:40 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x2` [INFO] [stdout] --> src/data.rs:204:44 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/data.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `testdata` [INFO] [stdout] --> src/main.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let testdata = data::ParallelPlaceData::pixel_frequencies_nom(0); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_testdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Rect` is never used [INFO] [stdout] --> src/data.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub type Rect = (u32, u32, u32, u32); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/data.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl PlaceData { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 23 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `pixel_frequencies`, `pixel_frequencies_fragment`, `find_rects`, `find_rects_fragment`, `find_before_rects`, and `find_before_rects_fragment` are never used [INFO] [stdout] --> src/data.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl ParallelPlaceData { [INFO] [stdout] | ---------------------- associated functions in this implementation [INFO] [stdout] 43 | pub fn pixel_frequencies(print_status: usize) -> ndarray::Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | fn pixel_frequencies_fragment(n: usize, print_status: usize) -> ndarray::Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 124 | pub fn find_rects() -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 139 | fn find_rects_fragment(n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 152 | pub fn find_before_rects(rects: &Vec<(Rect, i64)>) -> Vec<(Rect, ndarray::Array2>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 177 | fn find_before_rects_fragment( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `in_rect` is never used [INFO] [stdout] --> src/data.rs:229:4 [INFO] [stdout] | [INFO] [stdout] 229 | fn in_rect(rect: &Rect, point: (u32, u32)) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rects_intersect` is never used [INFO] [stdout] --> src/data.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn rects_intersect(rect1: &Rect, rect2: &Rect) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/data.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | Rect(u32, u32, u32, u32), [INFO] [stdout] | ---- ^^^ ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DrawType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 242 | Rect((), (), (), ()), [INFO] [stdout] | ~~ ~~ ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `timestamp`, `uid_hash`, and `color` are never read [INFO] [stdout] --> src/data.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 247 | pub struct PlaceEntry { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 248 | pub timestamp: NaiveDateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 249 | pub uid_hash: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 250 | pub color: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlaceEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 50 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 90 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 162 | | .reduce(|mut r, next| { [INFO] [stdout] 163 | | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] 164 | | for (old_pixel, new_pixel) in r[i].1.iter_mut().zip(pixels.into_iter()) { [INFO] [stdout] ... | [INFO] [stdout] 172 | | r [INFO] [stdout] 173 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut before_rects: Vec<(Rect, i64, ndarray::Array2>)> = rects.into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | / before_rects.into_iter() [INFO] [stdout] 218 | | .map(|(rect, _, pixels)| (rect, pixels)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:186:36 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|(r, ts)| (r, ts, ndarray::Array2::default(((r.2 - r.0 + 1) as usize, (r.3 - r.1 + 1) as usize)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 223 | fn get_gzip_reader>(path: P) -> DataLines { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / BufReader::new(GzDecoder::new(File::open(path).expect("No data file"))) [INFO] [stdout] 225 | | .lines() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r_place_data` (bin "r_place_data" test) due to 10 previous errors; 29 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `testdata` [INFO] [stdout] --> src/main.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | let testdata = data::ParallelPlaceData::pixel_frequencies_nom(0); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_testdata` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Rect` is never used [INFO] [stdout] --> src/data.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub type Rect = (u32, u32, u32, u32); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/data.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 22 | impl PlaceData { [INFO] [stdout] | -------------- associated function in this implementation [INFO] [stdout] 23 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `pixel_frequencies`, `pixel_frequencies_fragment`, `find_rects`, `find_rects_fragment`, `find_before_rects`, and `find_before_rects_fragment` are never used [INFO] [stdout] --> src/data.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | impl ParallelPlaceData { [INFO] [stdout] | ---------------------- associated functions in this implementation [INFO] [stdout] 43 | pub fn pixel_frequencies(print_status: usize) -> ndarray::Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 54 | fn pixel_frequencies_fragment(n: usize, print_status: usize) -> ndarray::Array2 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 124 | pub fn find_rects() -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 139 | fn find_rects_fragment(n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 152 | pub fn find_before_rects(rects: &Vec<(Rect, i64)>) -> Vec<(Rect, ndarray::Array2>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 177 | fn find_before_rects_fragment( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `in_rect` is never used [INFO] [stdout] --> src/data.rs:229:4 [INFO] [stdout] | [INFO] [stdout] 229 | fn in_rect(rect: &Rect, point: (u32, u32)) -> bool { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rects_intersect` is never used [INFO] [stdout] --> src/data.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn rects_intersect(rect1: &Rect, rect2: &Rect) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0`, `1`, `2`, and `3` are never read [INFO] [stdout] --> src/data.rs:242:10 [INFO] [stdout] | [INFO] [stdout] 242 | Rect(u32, u32, u32, u32), [INFO] [stdout] | ---- ^^^ ^^^ ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DrawType` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the fields to be of unit type to suppress this warning while preserving the field numbering, or remove the fields [INFO] [stdout] | [INFO] [stdout] 242 | Rect((), (), (), ()), [INFO] [stdout] | ~~ ~~ ~~ ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `timestamp`, `uid_hash`, and `color` are never read [INFO] [stdout] --> src/data.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 247 | pub struct PlaceEntry { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 248 | pub timestamp: NaiveDateTime, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 249 | pub uid_hash: String, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 250 | pub color: String, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlaceEntry` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 50 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rect` [INFO] [stdout] --> src/data.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rect` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x1` [INFO] [stdout] --> src/data.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/data.rs:204:40 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x2` [INFO] [stdout] --> src/data.rs:204:44 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/data.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 90 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 162 | | .reduce(|mut r, next| { [INFO] [stdout] 163 | | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] 164 | | for (old_pixel, new_pixel) in r[i].1.iter_mut().zip(pixels.into_iter()) { [INFO] [stdout] ... | [INFO] [stdout] 172 | | r [INFO] [stdout] 173 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut before_rects: Vec<(Rect, i64, ndarray::Array2>)> = rects.into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | / before_rects.into_iter() [INFO] [stdout] 218 | | .map(|(rect, _, pixels)| (rect, pixels)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:186:36 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|(r, ts)| (r, ts, ndarray::Array2::default(((r.2 - r.0 + 1) as usize, (r.3 - r.1 + 1) as usize)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 223 | fn get_gzip_reader>(path: P) -> DataLines { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / BufReader::new(GzDecoder::new(File::open(path).expect("No data file"))) [INFO] [stdout] 225 | | .lines() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 125 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rect` [INFO] [stdout] --> src/data.rs:163:26 [INFO] [stdout] | [INFO] [stdout] 163 | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_rect` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/data.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x1` [INFO] [stdout] --> src/data.rs:204:36 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y1` [INFO] [stdout] --> src/data.rs:204:40 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y1` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x2` [INFO] [stdout] --> src/data.rs:204:44 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_x2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y2` [INFO] [stdout] --> src/data.rs:204:48 [INFO] [stdout] | [INFO] [stdout] 204 | DrawType::Rect(x1, y1, x2, y2) => { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_y2` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r_place_data` (bin "r_place_data") due to 10 previous errors; 29 warnings emitted [INFO] [stdout] warning: function `rects_intersect` is never used [INFO] [stdout] --> src/data.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn rects_intersect(rect1: &Rect, rect2: &Rect) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 33 | let frequencies = data::ParallelPlaceData::pixel_frequencies(print_status); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Python::with_gil(|py| frequencies.into_pyarray(py).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 39 | let frequencies = data::ParallelPlaceData::pixel_frequencies_nom(print_status); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Python::with_gil(|py| frequencies.into_pyarray(py).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 50 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 90 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 162 | | .reduce(|mut r, next| { [INFO] [stdout] 163 | | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] 164 | | for (old_pixel, new_pixel) in r[i].1.iter_mut().zip(pixels.into_iter()) { [INFO] [stdout] ... | [INFO] [stdout] 172 | | r [INFO] [stdout] 173 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut before_rects: Vec<(Rect, i64, ndarray::Array2>)> = rects.into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | / before_rects.into_iter() [INFO] [stdout] 218 | | .map(|(rect, _, pixels)| (rect, pixels)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:186:36 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|(r, ts)| (r, ts, ndarray::Array2::default(((r.2 - r.0 + 1) as usize, (r.3 - r.1 + 1) as usize)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 223 | fn get_gzip_reader>(path: P) -> DataLines { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / BufReader::new(GzDecoder::new(File::open(path).expect("No data file"))) [INFO] [stdout] 225 | | .lines() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rects_intersect` is never used [INFO] [stdout] --> src/data.rs:233:4 [INFO] [stdout] | [INFO] [stdout] 233 | fn rects_intersect(rect1: &Rect, rect2: &Rect) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:34:22 [INFO] [stdout] | [INFO] [stdout] 33 | let frequencies = data::ParallelPlaceData::pixel_frequencies(print_status); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Python::with_gil(|py| frequencies.into_pyarray(py).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:22 [INFO] [stdout] | [INFO] [stdout] 39 | let frequencies = data::ParallelPlaceData::pixel_frequencies_nom(print_status); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Python::with_gil(|py| frequencies.into_pyarray(py).to_owned()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 44 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 50 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:49:37 [INFO] [stdout] | [INFO] [stdout] 49 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r_place_data` (lib test) due to 12 previous errors; 18 warnings emitted [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:74:21 [INFO] [stdout] | [INFO] [stdout] 74 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 74 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 84 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 90 | | .reduce(|arr, y| arr + y) [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:89:37 [INFO] [stdout] | [INFO] [stdout] 89 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/data.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 115 | std::io::stdout().flush(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 115 | let _ = std::io::stdout().flush(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 153 | let mut threads = (0..12) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 161 | / threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] 162 | | .reduce(|mut r, next| { [INFO] [stdout] 163 | | for (i, (rect, pixels)) in next.into_iter().enumerate() { [INFO] [stdout] 164 | | for (old_pixel, new_pixel) in r[i].1.iter_mut().zip(pixels.into_iter()) { [INFO] [stdout] ... | [INFO] [stdout] 172 | | r [INFO] [stdout] 173 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:161:37 [INFO] [stdout] | [INFO] [stdout] 161 | threads.into_iter().map(|x| x.join().unwrap()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 185 | let mut before_rects: Vec<(Rect, i64, ndarray::Array2>)> = rects.into_iter() [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 217 | / before_rects.into_iter() [INFO] [stdout] 218 | | .map(|(rect, _, pixels)| (rect, pixels)) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:186:36 [INFO] [stdout] | [INFO] [stdout] 186 | .map(|(r, ts)| (r, ts, ndarray::Array2::default(((r.2 - r.0 + 1) as usize, (r.3 - r.1 + 1) as usize)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data.rs:224:5 [INFO] [stdout] | [INFO] [stdout] 223 | fn get_gzip_reader>(path: P) -> DataLines { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 224 | / BufReader::new(GzDecoder::new(File::open(path).expect("No data file"))) [INFO] [stdout] 225 | | .lines() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 18 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r_place_data` (lib) due to 12 previous errors; 18 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b29a44f7b488d385ee5293f0903f7566502ce54d2fa3f3dbfc8f2f4f642a21b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b29a44f7b488d385ee5293f0903f7566502ce54d2fa3f3dbfc8f2f4f642a21b1", kill_on_drop: false }` [INFO] [stdout] b29a44f7b488d385ee5293f0903f7566502ce54d2fa3f3dbfc8f2f4f642a21b1