[INFO] cloning repository https://github.com/customtiy13/myinterpreters [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/customtiy13/myinterpreters" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcustomtiy13%2Fmyinterpreters", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcustomtiy13%2Fmyinterpreters'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f8c5922ad44d5c360bbc6ddf70835dfe6870ca26 [INFO] checking customtiy13/myinterpreters/f8c5922ad44d5c360bbc6ddf70835dfe6870ca26 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcustomtiy13%2Fmyinterpreters" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/customtiy13/myinterpreters on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/customtiy13/myinterpreters [INFO] finished tweaking git repo https://github.com/customtiy13/myinterpreters [INFO] tweaked toml for git repo https://github.com/customtiy13/myinterpreters written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/customtiy13/myinterpreters already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7db016708b0c622db1c4394c2455fbd91e5568e6f5fffa78f3970936019f8f28 [INFO] running `Command { std: "docker" "start" "-a" "7db016708b0c622db1c4394c2455fbd91e5568e6f5fffa78f3970936019f8f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7db016708b0c622db1c4394c2455fbd91e5568e6f5fffa78f3970936019f8f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7db016708b0c622db1c4394c2455fbd91e5568e6f5fffa78f3970936019f8f28", kill_on_drop: false }` [INFO] [stdout] 7db016708b0c622db1c4394c2455fbd91e5568e6f5fffa78f3970936019f8f28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8d241e402bc1c309e71b859640ff91459de42a0e5f88fa64fad94b443544f48f [INFO] running `Command { std: "docker" "start" "-a" "8d241e402bc1c309e71b859640ff91459de42a0e5f88fa64fad94b443544f48f", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking predicates v3.0.3 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking bstr v1.6.0 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking assert_cmd v2.0.12 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking myjlox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::iter::zip` [INFO] [stdout] --> src/stmt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::iter::zip; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use log::{debug, error}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::zip` [INFO] [stdout] --> src/stmt.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use std::iter::zip; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `debug` [INFO] [stdout] --> src/main.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | use log::{debug, error}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/interpreter.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | fun @ Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:85:50 [INFO] [stdout] | [INFO] [stdout] 85 | fun @ Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paren` [INFO] [stdout] --> src/interpreter.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | paren, [INFO] [stdout] | ^^^^^ help: try ignoring the field: `paren: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/interpreter.rs:85:42 [INFO] [stdout] | [INFO] [stdout] 85 | fun @ Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/interpreter.rs:85:50 [INFO] [stdout] | [INFO] [stdout] 85 | fun @ Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `paren` [INFO] [stdout] --> src/interpreter.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | paren, [INFO] [stdout] | ^^^^^ help: try ignoring the field: `paren: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/stmt.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | Stmt::Function { name, params, body } => Ok(params.len()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/stmt.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 50 | Stmt::Function { name, params, body } => Ok(params.len()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/stmt.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/tokens.rs:24:44 [INFO] [stdout] | [INFO] [stdout] 24 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/tokens.rs:24:52 [INFO] [stdout] | [INFO] [stdout] 24 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_environment` is never used [INFO] [stdout] --> src/interpreter.rs:298:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl Interpreter { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 298 | pub fn get_environment(&self) -> Result<&RefCell> { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `synchronize` is never used [INFO] [stdout] --> src/parser.rs:531:8 [INFO] [stdout] | [INFO] [stdout] 56 | impl Parser { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 531 | fn synchronize(&self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `arity` is never used [INFO] [stdout] --> src/stmt.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub trait Callable { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 37 | fn arity(&self) -> Result; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(enclosing: Option>>) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | values: HashMap::new().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | is_REPL: RefCell, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 19 | let env = Rc::new(RefCell::new(Environment::new(None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Interpreter { [INFO] [stdout] 21 | globals: env.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 19 | let env = Rc::new(RefCell::new(Environment::new(None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | environment: env.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(is_REPL: bool) -> Self { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 135 | let value = match expr { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | fn is_REPL(&self) -> bool { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 100 | let mut params = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let body = match self.block_stmt()? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Stmt::Block(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Stmt::Function { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | name: name.clone(), [INFO] [stdout] 132 | | params, [INFO] [stdout] 133 | | body, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 139 | let mut initializer = Expr::Null; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Stmt::VarStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | name: name.clone(), [INFO] [stdout] 151 | | initializer, [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 238 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | self.consume(TokenType::RightParen, "Expect ')' after if condition.")?; [INFO] [stdout] 240 | let body = self.statement()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | [INFO] [stdout] 242 | Ok(Stmt::WhileStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 243 | | condition, [INFO] [stdout] 244 | | body: Box::new(body), [INFO] [stdout] 245 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 250 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let then_branch = self.statement()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let else_branch = if self.is_match(&[TokenType::ELSE]) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Stmt::IfStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | condition, [INFO] [stdout] 262 | | then_branch: Box::new(then_branch), [INFO] [stdout] 263 | | else_branch: Box::new(else_branch), [INFO] [stdout] 264 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 268 | let mut statements = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(Stmt::Block(statements)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 280 | let value = self.expression()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(Stmt::PrintStmt(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 287 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Stmt::ExprStmt(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:420:12 [INFO] [stdout] | [INFO] [stdout] 404 | let mut arguments = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | Ok(Expr::Call { [INFO] [stdout] | ____________^ [INFO] [stdout] 421 | | callee: Box::new(expr.clone()), [INFO] [stdout] 422 | | paren: paren.clone(), [INFO] [stdout] 423 | | arguments, [INFO] [stdout] 424 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scanner.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 232 | let literal = match token_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | self.tokens.borrow_mut().push(Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scanner.rs:241:39 [INFO] [stdout] | [INFO] [stdout] 232 | let literal = match token_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | self.tokens.borrow_mut().push(Token { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 242 | | token_type, [INFO] [stdout] 243 | | lexeme: text.to_string(), [INFO] [stdout] 244 | | literal, [INFO] [stdout] 245 | | line: *self.line.borrow(), [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `collect` that must be used [INFO] [stdout] --> src/stmt.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / params [INFO] [stdout] 60 | | .iter() [INFO] [stdout] 61 | | .zip(arguments.iter()) [INFO] [stdout] 62 | | .map(|(x, y)| environment.define(&x.lexeme, y)) [INFO] [stdout] 63 | | .collect::>(); [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 59 | let _ = params [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/stmt.rs:50:30 [INFO] [stdout] | [INFO] [stdout] 50 | Stmt::Function { name, params, body } => Ok(params.len()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/stmt.rs:50:44 [INFO] [stdout] | [INFO] [stdout] 50 | Stmt::Function { name, params, body } => Ok(params.len()), [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/stmt.rs:58:30 [INFO] [stdout] | [INFO] [stdout] 58 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `name: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `params` [INFO] [stdout] --> src/tokens.rs:24:44 [INFO] [stdout] | [INFO] [stdout] 24 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `params: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `body` [INFO] [stdout] --> src/tokens.rs:24:52 [INFO] [stdout] | [INFO] [stdout] 24 | Stmt::Function { name, params, body } => { [INFO] [stdout] | ^^^^ help: try ignoring the field: `body: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `myjlox` (bin "myjlox") due to 15 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `synchronize` is never used [INFO] [stdout] --> src/parser.rs:531:8 [INFO] [stdout] | [INFO] [stdout] 56 | impl Parser { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 531 | fn synchronize(&self) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `arity` is never used [INFO] [stdout] --> src/stmt.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub trait Callable { [INFO] [stdout] | -------- method in this trait [INFO] [stdout] 37 | fn arity(&self) -> Result; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/environment.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(enclosing: Option>>) -> Self { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | values: HashMap::new().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: structure field `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | is_REPL: RefCell, [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 19 | let env = Rc::new(RefCell::new(Environment::new(None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Interpreter { [INFO] [stdout] 21 | globals: env.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:22:26 [INFO] [stdout] | [INFO] [stdout] 19 | let env = Rc::new(RefCell::new(Environment::new(None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | environment: env.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:18:16 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(is_REPL: bool) -> Self { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 135 | let value = match expr { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_REPL` should have a snake case name [INFO] [stdout] --> src/interpreter.rs:302:8 [INFO] [stdout] | [INFO] [stdout] 302 | fn is_REPL(&self) -> bool { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `is_repl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:130:12 [INFO] [stdout] | [INFO] [stdout] 100 | let mut params = Vec::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | let body = match self.block_stmt()? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | Stmt::Block(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Stmt::Function { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | name: name.clone(), [INFO] [stdout] 132 | | params, [INFO] [stdout] 133 | | body, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 139 | let mut initializer = Expr::Null; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | Ok(Stmt::VarStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 150 | | name: name.clone(), [INFO] [stdout] 151 | | initializer, [INFO] [stdout] 152 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 238 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | self.consume(TokenType::RightParen, "Expect ')' after if condition.")?; [INFO] [stdout] 240 | let body = self.statement()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | [INFO] [stdout] 242 | Ok(Stmt::WhileStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 243 | | condition, [INFO] [stdout] 244 | | body: Box::new(body), [INFO] [stdout] 245 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 250 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let then_branch = self.statement()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | let else_branch = if self.is_match(&[TokenType::ELSE]) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Stmt::IfStmt { [INFO] [stdout] | ____________^ [INFO] [stdout] 261 | | condition, [INFO] [stdout] 262 | | then_branch: Box::new(then_branch), [INFO] [stdout] 263 | | else_branch: Box::new(else_branch), [INFO] [stdout] 264 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 268 | let mut statements = Vec::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | Ok(Stmt::Block(statements)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:283:12 [INFO] [stdout] | [INFO] [stdout] 280 | let value = self.expression()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | Ok(Stmt::PrintStmt(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:290:12 [INFO] [stdout] | [INFO] [stdout] 287 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 290 | Ok(Stmt::ExprStmt(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:420:12 [INFO] [stdout] | [INFO] [stdout] 404 | let mut arguments = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | Ok(Expr::Call { [INFO] [stdout] | ____________^ [INFO] [stdout] 421 | | callee: Box::new(expr.clone()), [INFO] [stdout] 422 | | paren: paren.clone(), [INFO] [stdout] 423 | | arguments, [INFO] [stdout] 424 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scanner.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 232 | let literal = match token_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | self.tokens.borrow_mut().push(Token { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scanner.rs:241:39 [INFO] [stdout] | [INFO] [stdout] 232 | let literal = match token_type { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | self.tokens.borrow_mut().push(Token { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 242 | | token_type, [INFO] [stdout] 243 | | lexeme: text.to_string(), [INFO] [stdout] 244 | | literal, [INFO] [stdout] 245 | | line: *self.line.borrow(), [INFO] [stdout] 246 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `collect` that must be used [INFO] [stdout] --> src/stmt.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | / params [INFO] [stdout] 60 | | .iter() [INFO] [stdout] 61 | | .zip(arguments.iter()) [INFO] [stdout] 62 | | .map(|(x, y)| environment.define(&x.lexeme, y)) [INFO] [stdout] 63 | | .collect::>(); [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 59 | let _ = params [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 16 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `myjlox` (bin "myjlox" test) due to 15 previous errors; 16 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8d241e402bc1c309e71b859640ff91459de42a0e5f88fa64fad94b443544f48f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8d241e402bc1c309e71b859640ff91459de42a0e5f88fa64fad94b443544f48f", kill_on_drop: false }` [INFO] [stdout] 8d241e402bc1c309e71b859640ff91459de42a0e5f88fa64fad94b443544f48f