[INFO] cloning repository https://github.com/curtisxk38/rcheer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/curtisxk38/rcheer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtisxk38%2Frcheer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtisxk38%2Frcheer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 55f1932a5f93e958f035c4a1e9082beaa3b30ab8 [INFO] checking curtisxk38/rcheer/55f1932a5f93e958f035c4a1e9082beaa3b30ab8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtisxk38%2Frcheer" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/curtisxk38/rcheer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/curtisxk38/rcheer [INFO] finished tweaking git repo https://github.com/curtisxk38/rcheer [INFO] tweaked toml for git repo https://github.com/curtisxk38/rcheer written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/curtisxk38/rcheer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4e7911e3236fc8aac7fd555bd28af121225ca1f935ecc2cfe24e1bd84415dcbe [INFO] running `Command { std: "docker" "start" "-a" "4e7911e3236fc8aac7fd555bd28af121225ca1f935ecc2cfe24e1bd84415dcbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4e7911e3236fc8aac7fd555bd28af121225ca1f935ecc2cfe24e1bd84415dcbe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e7911e3236fc8aac7fd555bd28af121225ca1f935ecc2cfe24e1bd84415dcbe", kill_on_drop: false }` [INFO] [stdout] 4e7911e3236fc8aac7fd555bd28af121225ca1f935ecc2cfe24e1bd84415dcbe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa4cadf193a783f3d8834010af804888f7a41dbb1b0b3cfed66b86b31e7aa792 [INFO] running `Command { std: "docker" "start" "-a" "aa4cadf193a783f3d8834010af804888f7a41dbb1b0b3cfed66b86b31e7aa792", kill_on_drop: false }` [INFO] [stderr] Checking rcheer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: named argument `op` is not used by name [INFO] [stdout] --> src/ast.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 92 | repr = format!("{:>width$}\n{left}\n{right}", [INFO] [stdout] | ---------- this formatting argument uses named argument `op` by position [INFO] [stdout] 93 | op=op, [INFO] [stdout] | ^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 92 | repr = format!("{op:>width$}\n{left}\n{right}", [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `op` is not used by name [INFO] [stdout] --> src/ast.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 103 | repr = format!("{:>width$}\n{right}", [INFO] [stdout] | ---------- this formatting argument uses named argument `op` by position [INFO] [stdout] 104 | op=op, [INFO] [stdout] | ^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 103 | repr = format!("{op:>width$}\n{right}", [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `lit` is not used by name [INFO] [stdout] --> src/ast.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | repr = format!("{:>width$}", lit=n.token.lexeme.clone(), width = indent); [INFO] [stdout] | ---------- ^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `lit` by position [INFO] [stdout] | [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 110 | repr = format!("{lit:>width$}", lit=n.token.lexeme.clone(), width = indent); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fmt::format` [INFO] [stdout] --> src/parse.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::format, iter::Peekable, slice::Iter}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `op` is not used by name [INFO] [stdout] --> src/ast.rs:93:17 [INFO] [stdout] | [INFO] [stdout] 92 | repr = format!("{:>width$}\n{left}\n{right}", [INFO] [stdout] | ---------- this formatting argument uses named argument `op` by position [INFO] [stdout] 93 | op=op, [INFO] [stdout] | ^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 92 | repr = format!("{op:>width$}\n{left}\n{right}", [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `op` is not used by name [INFO] [stdout] --> src/ast.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 103 | repr = format!("{:>width$}\n{right}", [INFO] [stdout] | ---------- this formatting argument uses named argument `op` by position [INFO] [stdout] 104 | op=op, [INFO] [stdout] | ^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 103 | repr = format!("{op:>width$}\n{right}", [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `lit` is not used by name [INFO] [stdout] --> src/ast.rs:110:42 [INFO] [stdout] | [INFO] [stdout] 110 | repr = format!("{:>width$}", lit=n.token.lexeme.clone(), width = indent); [INFO] [stdout] | ---------- ^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | | [INFO] [stdout] | this formatting argument uses named argument `lit` by position [INFO] [stdout] | [INFO] [stdout] help: use the named argument by name to avoid ambiguity [INFO] [stdout] | [INFO] [stdout] 110 | repr = format!("{lit:>width$}", lit=n.token.lexeme.clone(), width = indent); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `fmt::format` [INFO] [stdout] --> src/parse.rs:1:11 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{fmt::format, iter::Peekable, slice::Iter}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `line` and `column` are never read [INFO] [stdout] --> src/token.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Token { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub line: i32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub column: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 56 | let condition = Box::new(expression(tokens)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let then_branch = Box::new(expression(tokens)?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let else_branch = match tokens.peek() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let else_branch = expression(tokens)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(Expr::If(If{token, condition, then_branch, else_branch, type_kind: None})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `line` and `column` are never read [INFO] [stdout] --> src/token.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct Token { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 6 | pub line: i32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 7 | pub column: i32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 56 | let condition = Box::new(expression(tokens)?); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let then_branch = Box::new(expression(tokens)?); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let else_branch = match tokens.peek() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let else_branch = expression(tokens)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(Expr::If(If{token, condition, then_branch, else_branch, type_kind: None})) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rcheer` (lib) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rcheer` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa4cadf193a783f3d8834010af804888f7a41dbb1b0b3cfed66b86b31e7aa792", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa4cadf193a783f3d8834010af804888f7a41dbb1b0b3cfed66b86b31e7aa792", kill_on_drop: false }` [INFO] [stdout] aa4cadf193a783f3d8834010af804888f7a41dbb1b0b3cfed66b86b31e7aa792