[INFO] cloning repository https://github.com/curtis3389/sisko [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/curtis3389/sisko" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtis3389%2Fsisko", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtis3389%2Fsisko'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9234b31a9023eb2536843c87c664ed577c8cc2ed [INFO] checking curtis3389/sisko/9234b31a9023eb2536843c87c664ed577c8cc2ed against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcurtis3389%2Fsisko" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/curtis3389/sisko on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/curtis3389/sisko [INFO] finished tweaking git repo https://github.com/curtis3389/sisko [INFO] tweaked toml for git repo https://github.com/curtis3389/sisko written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/curtis3389/sisko already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a04bb5763c2e40a604cb01b963eb26d3a4ece6be61b7b09c9a4d79d977ee9704 [INFO] running `Command { std: "docker" "start" "-a" "a04bb5763c2e40a604cb01b963eb26d3a4ece6be61b7b09c9a4d79d977ee9704", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a04bb5763c2e40a604cb01b963eb26d3a4ece6be61b7b09c9a4d79d977ee9704", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a04bb5763c2e40a604cb01b963eb26d3a4ece6be61b7b09c9a4d79d977ee9704", kill_on_drop: false }` [INFO] [stdout] a04bb5763c2e40a604cb01b963eb26d3a4ece6be61b7b09c9a4d79d977ee9704 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0ae6c8c10599de7298f42fdab08d57a71e7dd33f956989c6762c22da14df99f [INFO] running `Command { std: "docker" "start" "-a" "c0ae6c8c10599de7298f42fdab08d57a71e7dd33f956989c6762c22da14df99f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.84 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Compiling ncurses v5.101.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking thread-id v4.2.1 [INFO] [stderr] Checking term_size v0.3.2 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking sisko_lib v0.1.0 (/opt/rustwide/workdir/sisko_lib) [INFO] [stderr] Compiling darling_core v0.20.9 [INFO] [stdout] warning: method `calc_padding_to_total` is never used [INFO] [stdout] --> sisko_lib/src/id3v2_tag.rs:236:8 [INFO] [stdout] | [INFO] [stdout] 30 | impl ID3v2Tag { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 236 | fn calc_padding_to_total(&self, total: u32) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `calc_padding_to_total` is never used [INFO] [stdout] --> sisko_lib/src/id3v2_tag.rs:236:8 [INFO] [stdout] | [INFO] [stdout] 30 | impl ID3v2Tag { [INFO] [stdout] | ------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 236 | fn calc_padding_to_total(&self, total: u32) -> u32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling darling_macro v0.20.9 [INFO] [stderr] Compiling darling v0.20.9 [INFO] [stderr] Compiling enumset_derive v0.8.1 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking enumset v1.1.3 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking cursive_core v0.3.7 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking cursive v0.20.0 [INFO] [stderr] Checking cursive_table_view v0.14.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking sisko v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `release` [INFO] [stdout] --> src/domain/album_service.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | fn get_priority(&self, release: &Release) -> f64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_release` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `release` [INFO] [stdout] --> src/domain/album_service.rs:98:28 [INFO] [stdout] | [INFO] [stdout] 98 | fn get_priority(&self, release: &Release) -> f64 { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_release` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_priority` is never used [INFO] [stdout] --> src/domain/album_service.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl AlbumService { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | fn get_priority(&self, release: &Release) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/infrastructure/acoustid/acoustid_service.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | struct LookupResponse { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 83 | pub status: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:27 [INFO] [stdout] | [INFO] [stdout] 134 | let audio_file = audio_file.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | tokio::spawn(async move { [INFO] [stdout] 136 | match SiskoService::instance().scan_audio_file(&audio_file).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_priority` is never used [INFO] [stdout] --> src/domain/album_service.rs:98:8 [INFO] [stdout] | [INFO] [stdout] 13 | impl AlbumService { [INFO] [stdout] | ----------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 98 | fn get_priority(&self, release: &Release) -> f64 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/infrastructure/acoustid/acoustid_service.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 82 | struct LookupResponse { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 83 | pub status: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domain/tag_field.rs:295:35 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|(_, group)| group.map(|(_, s)| s).collect_vec()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:136:27 [INFO] [stdout] | [INFO] [stdout] 134 | let audio_file = audio_file.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | tokio::spawn(async move { [INFO] [stdout] 136 | match SiskoService::instance().scan_audio_file(&audio_file).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domain/tag_field.rs:299:39 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|(a, group)| (a, group.map(|(_, s)| s).collect_vec())) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/infrastructure/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 47 | map_single: impl Fn(&From) -> Result, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | map_partial: impl Fn(&PartialGroup, Vec<&From>) -> Result, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | map_multi: impl Fn(&MultiType, &From) -> Result>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut multis = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut partials = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let singles = singles.iter().map(|f| map_single(f)).collect_vec(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let multis = multis [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let partials = partials [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | singles.into_iter().chain(multis).chain(partials).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/infrastructure/mod.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 60 | .for_each(|f| match MappingType::::from(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domain/tag_field.rs:295:35 [INFO] [stdout] | [INFO] [stdout] 295 | .map(|(_, group)| group.map(|(_, s)| s).collect_vec()) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/domain/tag_field.rs:299:39 [INFO] [stdout] | [INFO] [stdout] 299 | .map(|(a, group)| (a, group.map(|(_, s)| s).collect_vec())) [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/infrastructure/mod.rs:86:5 [INFO] [stdout] | [INFO] [stdout] 47 | map_single: impl Fn(&From) -> Result, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | map_partial: impl Fn(&PartialGroup, Vec<&From>) -> Result, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | map_multi: impl Fn(&MultiType, &From) -> Result>, [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | let mut multis = vec![]; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut partials = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let singles = singles.iter().map(|f| map_single(f)).collect_vec(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let multis = multis [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | let partials = partials [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | singles.into_iter().chain(multis).chain(partials).collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/infrastructure/mod.rs:60:29 [INFO] [stdout] | [INFO] [stdout] 60 | .for_each(|f| match MappingType::::from(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/album_view.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|track| AlbumView::for_track(am.clone(), album_id.clone(), track)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/album_view.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 128 | let am = album.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let album = album [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | id: album.id.clone(), [INFO] [stdout] 134 | | album_id: album.id.clone(), [INFO] [stdout] 135 | | album: am, [INFO] [stdout] 136 | | track_id: None, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/album_view.rs:33:47 [INFO] [stdout] | [INFO] [stdout] 33 | .map(|track| AlbumView::for_track(am.clone(), album_id.clone(), track)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/audio_file_view.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 39 | let mutex = audio_file.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let audio_file = audio_file.lock().map_err(|_| anyhow!(""))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | audio_file: mutex, [INFO] [stdout] 43 | | path: audio_file.file.absolute_path.clone(), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 27 | let mut root = cursive::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | root: Mutex::new(root), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/album_view.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 128 | let am = album.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let album = album [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | id: album.id.clone(), [INFO] [stdout] 134 | | album_id: album.id.clone(), [INFO] [stdout] 135 | | album: am, [INFO] [stdout] 136 | | track_id: None, [INFO] [stdout] 137 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/audio_file_view.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 39 | let mutex = audio_file.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let audio_file = audio_file.lock().map_err(|_| anyhow!(""))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | audio_file: mutex, [INFO] [stdout] 43 | | path: audio_file.file.absolute_path.clone(), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:36:19 [INFO] [stdout] | [INFO] [stdout] 27 | let mut root = cursive::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | root: Mutex::new(root), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:122:53 [INFO] [stdout] | [INFO] [stdout] 121 | let selected_audio_file = s.clone_audio_file_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | UiEventService::instance().send(UiEvent::SelectClusterFile(selected_audio_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:122:53 [INFO] [stdout] | [INFO] [stdout] 121 | let selected_audio_file = s.clone_audio_file_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | UiEventService::instance().send(UiEvent::SelectClusterFile(selected_audio_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:130:53 [INFO] [stdout] | [INFO] [stdout] 129 | let selected_audio_file = s.clone_audio_file_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | UiEventService::instance().send(UiEvent::SubmitClusterFile(selected_audio_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 155 | let selected_album_view = s.clone_album_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | UiEventService::instance().send(UiEvent::SelectAlbumView(selected_album_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:164:53 [INFO] [stdout] | [INFO] [stdout] 163 | let submitted_album_view = s.clone_album_view(index)?; [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | UiEventService::instance().send(UiEvent::SubmitAlbumView(submitted_album_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:130:53 [INFO] [stdout] | [INFO] [stdout] 129 | let selected_audio_file = s.clone_audio_file_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | UiEventService::instance().send(UiEvent::SubmitClusterFile(selected_audio_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:186:53 [INFO] [stdout] | [INFO] [stdout] 185 | let selected_field = s.clone_tag_field_view(index)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | UiEventService::instance().send(UiEvent::SubmitMetadataRow(selected_field)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:156:53 [INFO] [stdout] | [INFO] [stdout] 155 | let selected_album_view = s.clone_album_view(index)?; [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | UiEventService::instance().send(UiEvent::SelectAlbumView(selected_album_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:164:53 [INFO] [stdout] | [INFO] [stdout] 163 | let submitted_album_view = s.clone_album_view(index)?; [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | UiEventService::instance().send(UiEvent::SubmitAlbumView(submitted_album_view)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:186:53 [INFO] [stdout] | [INFO] [stdout] 185 | let selected_field = s.clone_tag_field_view(index)?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | UiEventService::instance().send(UiEvent::SubmitMetadataRow(selected_field)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:298:20 [INFO] [stdout] | [INFO] [stdout] 298 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:266:20 [INFO] [stdout] | [INFO] [stdout] 266 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn add_cluster_file(&self, audio_file: Arc>) -> Result<()> { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let audio_file_view = AudioFileView::try_from(&audio_file)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / CbSinkService::instance()? [INFO] [stdout] 58 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 59 | | s.call_on_name( [INFO] [stdout] 60 | | CLUSTER_FILE_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 78 | | ); [INFO] [stdout] 79 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:284:20 [INFO] [stdout] | [INFO] [stdout] 284 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | let view = view.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / CbSinkService::instance()? [INFO] [stdout] 128 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 129 | | if let Err(e) = album_view_dialog(s, &view) { [INFO] [stdout] 130 | | error!("Error opening album view dialog: {e}!"); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 137 | let field = field.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | / CbSinkService::instance()? [INFO] [stdout] 139 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 140 | | if let Err(e) = tag_field_dialog(s, &field) { [INFO] [stdout] 141 | | error!("Error opening tag field dialog: {e}!"); [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:298:20 [INFO] [stdout] | [INFO] [stdout] 298 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | let audio_file = audio_file.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / CbSinkService::instance()? [INFO] [stdout] 150 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 151 | | audio_file_dialog(s, &audio_file); [INFO] [stdout] 152 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/cursive_wrapper.rs:316:20 [INFO] [stdout] | [INFO] [stdout] 316 | Ok(item.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / CbSinkService::instance()? [INFO] [stdout] 164 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 165 | | s.call_on_name( [INFO] [stdout] 166 | | CLUSTER_FILE_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 177 | | ); [INFO] [stdout] 178 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 184 | let audio_file = audio_file [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let items: Vec = audio_file [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | / CbSinkService::instance()? [INFO] [stdout] 197 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 198 | | s.call_on_name( [INFO] [stdout] 199 | | METADATA_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 203 | | ); [INFO] [stdout] 204 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:301:28 [INFO] [stdout] | [INFO] [stdout] 301 | Ok(table_view [INFO] [stdout] | ____________________________^ [INFO] [stdout] 302 | | .borrow_item(index) [INFO] [stdout] 303 | | .ok_or(anyhow!( [INFO] [stdout] 304 | | "Error getting currently selected item in {} by index {}!", [INFO] [stdout] ... | [INFO] [stdout] 307 | | ))? [INFO] [stdout] 308 | | .clone()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn add_cluster_file(&self, audio_file: Arc>) -> Result<()> { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let audio_file_view = AudioFileView::try_from(&audio_file)?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | / CbSinkService::instance()? [INFO] [stdout] 58 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 59 | | s.call_on_name( [INFO] [stdout] 60 | | CLUSTER_FILE_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 78 | | ); [INFO] [stdout] 79 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:127:9 [INFO] [stdout] | [INFO] [stdout] 126 | let view = view.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | / CbSinkService::instance()? [INFO] [stdout] 128 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 129 | | if let Err(e) = album_view_dialog(s, &view) { [INFO] [stdout] 130 | | error!("Error opening album view dialog: {e}!"); [INFO] [stdout] 131 | | } [INFO] [stdout] 132 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 137 | let field = field.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | / CbSinkService::instance()? [INFO] [stdout] 139 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 140 | | if let Err(e) = tag_field_dialog(s, &field) { [INFO] [stdout] 141 | | error!("Error opening tag field dialog: {e}!"); [INFO] [stdout] 142 | | } [INFO] [stdout] 143 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | let audio_file = audio_file.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | / CbSinkService::instance()? [INFO] [stdout] 150 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 151 | | audio_file_dialog(s, &audio_file); [INFO] [stdout] 152 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / CbSinkService::instance()? [INFO] [stdout] 164 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 165 | | s.call_on_name( [INFO] [stdout] 166 | | CLUSTER_FILE_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 177 | | ); [INFO] [stdout] 178 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 184 | let audio_file = audio_file [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | let items: Vec = audio_file [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | / CbSinkService::instance()? [INFO] [stdout] 197 | | .send(Box::new(move |s: &mut Cursive| { [INFO] [stdout] 198 | | s.call_on_name( [INFO] [stdout] 199 | | METADATA_TABLE, [INFO] [stdout] ... | [INFO] [stdout] 203 | | ); [INFO] [stdout] 204 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ui/ui_wrapper.rs:301:28 [INFO] [stdout] | [INFO] [stdout] 301 | Ok(table_view [INFO] [stdout] | ____________________________^ [INFO] [stdout] 302 | | .borrow_item(index) [INFO] [stdout] 303 | | .ok_or(anyhow!( [INFO] [stdout] 304 | | "Error getting currently selected item in {} by index {}!", [INFO] [stdout] ... | [INFO] [stdout] 307 | | ))? [INFO] [stdout] 308 | | .clone()) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 25 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 25 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sisko` (bin "sisko") due to 26 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `sisko` (bin "sisko" test) due to 26 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c0ae6c8c10599de7298f42fdab08d57a71e7dd33f956989c6762c22da14df99f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0ae6c8c10599de7298f42fdab08d57a71e7dd33f956989c6762c22da14df99f", kill_on_drop: false }` [INFO] [stdout] c0ae6c8c10599de7298f42fdab08d57a71e7dd33f956989c6762c22da14df99f