[INFO] cloning repository https://github.com/ctangam/lua-interpreter-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ctangam/lua-interpreter-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctangam%2Flua-interpreter-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctangam%2Flua-interpreter-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 24628bd2d0f79778e4027bcca5c352fb5df6fe98 [INFO] checking ctangam/lua-interpreter-rust/24628bd2d0f79778e4027bcca5c352fb5df6fe98 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fctangam%2Flua-interpreter-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ctangam/lua-interpreter-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ctangam/lua-interpreter-rust [INFO] finished tweaking git repo https://github.com/ctangam/lua-interpreter-rust [INFO] tweaked toml for git repo https://github.com/ctangam/lua-interpreter-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ctangam/lua-interpreter-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f64162619fd4398e23d04c573a446e12a58ec83acccbadd96663dbc9ba0b02c6 [INFO] running `Command { std: "docker" "start" "-a" "f64162619fd4398e23d04c573a446e12a58ec83acccbadd96663dbc9ba0b02c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f64162619fd4398e23d04c573a446e12a58ec83acccbadd96663dbc9ba0b02c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f64162619fd4398e23d04c573a446e12a58ec83acccbadd96663dbc9ba0b02c6", kill_on_drop: false }` [INFO] [stdout] f64162619fd4398e23d04c573a446e12a58ec83acccbadd96663dbc9ba0b02c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d6219f825b74054071a581928639a0f53c2f300471197eb909c624d225f11d0 [INFO] running `Command { std: "docker" "start" "-a" "4d6219f825b74054071a581928639a0f53c2f300471197eb909c624d225f11d0", kill_on_drop: false }` [INFO] [stderr] Checking luar v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `parse::ParseProto` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use parse::ParseProto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Read`, `arch::x86_64::_SIDD_NEGATIVE_POLARITY`, `collections::HashMap`, `env::var`, `fmt::DebugStruct`, and `iter` [INFO] [stdout] --> src/vm.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | arch::x86_64::_SIDD_NEGATIVE_POLARITY, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 5 | collections::HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | env::var, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | fmt::DebugStruct, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 8 | io::{Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 9 | iter, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parse::ParseProto` [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use parse::ParseProto; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Read`, `arch::x86_64::_SIDD_NEGATIVE_POLARITY`, `collections::HashMap`, `env::var`, `fmt::DebugStruct`, and `iter` [INFO] [stdout] --> src/vm.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | arch::x86_64::_SIDD_NEGATIVE_POLARITY, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 5 | collections::HashMap, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 6 | env::var, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 7 | fmt::DebugStruct, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 8 | io::{Read, Write}, [INFO] [stdout] | ^^^^ [INFO] [stdout] 9 | iter, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `ParseContext` is more private than the item `ParseProto::ctx` [INFO] [stdout] --> src/parse.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub ctx: &'a mut ParseContext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::ctx` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `ParseContext` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | struct ParseContext { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `GotoLabel` is more private than the item `ParseProto::gotos` [INFO] [stdout] --> src/parse.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub gotos: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::gotos` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `GotoLabel` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | struct GotoLabel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `GotoLabel` is more private than the item `ParseProto::labels` [INFO] [stdout] --> src/parse.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub labels: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::labels` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `GotoLabel` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | struct GotoLabel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lex.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(input: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { input: input.bytes().peekable(), ahead: Token::Eos} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:1482:29 [INFO] [stdout] | [INFO] [stdout] 1476 | fn add_const(&mut self, c: impl Into) -> usize { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1477 | let c = c.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1482 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 1483 | | self.fp.constants.push(c); [INFO] [stdout] 1484 | | self.fp.constants.len() - 1 [INFO] [stdout] 1485 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:852:51 [INFO] [stdout] | [INFO] [stdout] 852 | .unwrap_or_else(|| table.map.get(&Value::Integer(key)).unwrap_or(&Value::Nil)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:852:83 [INFO] [stdout] | [INFO] [stdout] 852 | .unwrap_or_else(|| table.map.get(&Value::Integer(key)).unwrap_or(&Value::Nil)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:881:25 [INFO] [stdout] | [INFO] [stdout] 880 | pub fn push(&mut self, v: impl Into) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 881 | self.stack.push(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luar` (bin "luar") due to 6 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: type `ParseContext` is more private than the item `ParseProto::ctx` [INFO] [stdout] --> src/parse.rs:79:5 [INFO] [stdout] | [INFO] [stdout] 79 | pub ctx: &'a mut ParseContext, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::ctx` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `ParseContext` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:63:1 [INFO] [stdout] | [INFO] [stdout] 63 | struct ParseContext { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `GotoLabel` is more private than the item `ParseProto::gotos` [INFO] [stdout] --> src/parse.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub gotos: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::gotos` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `GotoLabel` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | struct GotoLabel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `GotoLabel` is more private than the item `ParseProto::labels` [INFO] [stdout] --> src/parse.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | pub labels: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ field `ParseProto::labels` is reachable at visibility `pub(crate)` [INFO] [stdout] | [INFO] [stdout] note: but type `GotoLabel` is only usable at visibility `pub(self)` [INFO] [stdout] --> src/parse.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | struct GotoLabel { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lex.rs:44:23 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn new(input: R) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | Self { input: input.bytes().peekable(), ahead: Token::Eos} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:1482:29 [INFO] [stdout] | [INFO] [stdout] 1476 | fn add_const(&mut self, c: impl Into) -> usize { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1477 | let c = c.into(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1482 | .unwrap_or_else(|| { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 1483 | | self.fp.constants.push(c); [INFO] [stdout] 1484 | | self.fp.constants.len() - 1 [INFO] [stdout] 1485 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:852:51 [INFO] [stdout] | [INFO] [stdout] 852 | .unwrap_or_else(|| table.map.get(&Value::Integer(key)).unwrap_or(&Value::Nil)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:852:83 [INFO] [stdout] | [INFO] [stdout] 852 | .unwrap_or_else(|| table.map.get(&Value::Integer(key)).unwrap_or(&Value::Nil)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:881:25 [INFO] [stdout] | [INFO] [stdout] 880 | pub fn push(&mut self, v: impl Into) { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 881 | self.stack.push(v.into()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `luar` (bin "luar" test) due to 6 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4d6219f825b74054071a581928639a0f53c2f300471197eb909c624d225f11d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d6219f825b74054071a581928639a0f53c2f300471197eb909c624d225f11d0", kill_on_drop: false }` [INFO] [stdout] 4d6219f825b74054071a581928639a0f53c2f300471197eb909c624d225f11d0