[INFO] cloning repository https://github.com/cstorey/mio-rules-example [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cstorey/mio-rules-example" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcstorey%2Fmio-rules-example", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcstorey%2Fmio-rules-example'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0ceedffc2370de15cc6e7b73d44d8999b98c0ee0 [INFO] checking cstorey/mio-rules-example/0ceedffc2370de15cc6e7b73d44d8999b98c0ee0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcstorey%2Fmio-rules-example" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cstorey/mio-rules-example on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cstorey/mio-rules-example [INFO] finished tweaking git repo https://github.com/cstorey/mio-rules-example [INFO] tweaked toml for git repo https://github.com/cstorey/mio-rules-example written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cstorey/mio-rules-example already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5a7adfe559545c27f577c91c253dedbc66fcd2640468116ecc35faf4caa1f4b [INFO] running `Command { std: "docker" "start" "-a" "b5a7adfe559545c27f577c91c253dedbc66fcd2640468116ecc35faf4caa1f4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5a7adfe559545c27f577c91c253dedbc66fcd2640468116ecc35faf4caa1f4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5a7adfe559545c27f577c91c253dedbc66fcd2640468116ecc35faf4caa1f4b", kill_on_drop: false }` [INFO] [stdout] b5a7adfe559545c27f577c91c253dedbc66fcd2640468116ecc35faf4caa1f4b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df1adad01a9262df5a676a3ee9ebfc411441af2093164ac0a26709d4726ce00d [INFO] running `Command { std: "docker" "start" "-a" "df1adad01a9262df5a676a3ee9ebfc411441af2093164ac0a26709d4726ce00d", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Compiling proc-macro2 v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling version_check v0.1.4 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling log v0.4.10 [INFO] [stderr] Compiling failure_derive v0.1.6 [INFO] [stderr] Checking ucd-util v0.1.1 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking utf8-ranges v1.0.1 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking bytes v0.5.3 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling synstructure v0.12.1 [INFO] [stderr] Checking failure v0.1.6 [INFO] [stderr] Checking michat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 97 | let _ = &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 183 | fn new(socket: TcpStream, token: mio::Token) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let peer = socket.peer_addr()?; [INFO] [stdout] 185 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | socket: socket, [INFO] [stdout] 187 | | peer: peer, [INFO] [stdout] 188 | | sock_status: mio::Ready::empty(), [INFO] [stdout] ... | [INFO] [stdout] 192 | | read_eof: false, [INFO] [stdout] 193 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:46 [INFO] [stdout] | [INFO] [stdout] 387 | if let Err(e) = conn.process_rules(event_loop, &mut |action| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | parent_actions.push_back((idx, action)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `michat` (bin "michat") due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 57 | let _ = &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/main.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 97 | let _ = &self.connections[token.into()].register(event_loop, token)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 183 | fn new(socket: TcpStream, token: mio::Token) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let peer = socket.peer_addr()?; [INFO] [stdout] 185 | Ok(Connection { [INFO] [stdout] | ____________^ [INFO] [stdout] 186 | | socket: socket, [INFO] [stdout] 187 | | peer: peer, [INFO] [stdout] 188 | | sock_status: mio::Ready::empty(), [INFO] [stdout] ... | [INFO] [stdout] 192 | | read_eof: false, [INFO] [stdout] 193 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:388:46 [INFO] [stdout] | [INFO] [stdout] 387 | if let Err(e) = conn.process_rules(event_loop, &mut |action| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 388 | parent_actions.push_back((idx, action)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `michat` (bin "michat" test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "df1adad01a9262df5a676a3ee9ebfc411441af2093164ac0a26709d4726ce00d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df1adad01a9262df5a676a3ee9ebfc411441af2093164ac0a26709d4726ce00d", kill_on_drop: false }` [INFO] [stdout] df1adad01a9262df5a676a3ee9ebfc411441af2093164ac0a26709d4726ce00d