[INFO] cloning repository https://github.com/cryslith/gadget-down [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cryslith/gadget-down" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcryslith%2Fgadget-down", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcryslith%2Fgadget-down'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8bcbdc24337806d51ea899ede64063dbfbc6e0b4 [INFO] checking cryslith/gadget-down/8bcbdc24337806d51ea899ede64063dbfbc6e0b4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcryslith%2Fgadget-down" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cryslith/gadget-down on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cryslith/gadget-down [INFO] finished tweaking git repo https://github.com/cryslith/gadget-down [INFO] tweaked toml for git repo https://github.com/cryslith/gadget-down written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cryslith/gadget-down already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56b8f54d38a5b6fea7286325026d787e352ba3078301849ef1e54b69df97eada [INFO] running `Command { std: "docker" "start" "-a" "56b8f54d38a5b6fea7286325026d787e352ba3078301849ef1e54b69df97eada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56b8f54d38a5b6fea7286325026d787e352ba3078301849ef1e54b69df97eada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56b8f54d38a5b6fea7286325026d787e352ba3078301849ef1e54b69df97eada", kill_on_drop: false }` [INFO] [stdout] 56b8f54d38a5b6fea7286325026d787e352ba3078301849ef1e54b69df97eada [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8834d4a96f77d2f13558e45093c7b4bb8f46951c757f1c3258e4b3831824f54f [INFO] running `Command { std: "docker" "start" "-a" "8834d4a96f77d2f13558e45093c7b4bb8f46951c757f1c3258e4b3831824f54f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde_derive v1.0.143 [INFO] [stderr] Compiling serde v1.0.143 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking unsafe-libyaml v0.2.2 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking refinery v0.1.1 (https://github.com/cryslith/refinery?branch=expose-rev-partition#0ac844f3) [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking serde_yaml v0.9.9 [INFO] [stderr] Checking gadget-down v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `l1` [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | for ((l1, l2), v) in transitions_into_a.into_iter().sorted_by_key(|&(k, _)| k) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l2` [INFO] [stdout] --> src/lib.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | for ((l1, l2), v) in transitions_into_a.into_iter().sorted_by_key(|&(k, _)| k) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `partition` [INFO] [stdout] --> src/lib.rs:278:49 [INFO] [stdout] | [INFO] [stdout] 278 | partition.refine_with_callback(&v[..], |partition, orig, new| { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_partition` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l1` [INFO] [stdout] --> src/lib.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | for ((l1, l2), v) in transitions_into_a.into_iter().sorted_by_key(|&(k, _)| k) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `l2` [INFO] [stdout] --> src/lib.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | for ((l1, l2), v) in transitions_into_a.into_iter().sorted_by_key(|&(k, _)| k) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_l2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `partition` [INFO] [stdout] --> src/lib.rs:278:49 [INFO] [stdout] | [INFO] [stdout] 278 | partition.refine_with_callback(&v[..], |partition, orig, new| { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_partition` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 84 | fn from_states(x: impl IntoIterator) -> u64 { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | x.into_iter().fold(0, |a, b| a | (1 << b)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 150 | .map(|&x_s| to_states(x_s).any(|s| self.accept[s])) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Name` is never used [INFO] [stdout] --> src/lib.rs:10:6 [INFO] [stdout] | [INFO] [stdout] 10 | type Name = usize; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|(&(l1, s1), v)| ((l1, p[s1]), v.iter().map(|&(l2, s2)| (l2, p[s2])).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `renumber_states` is never used [INFO] [stdout] --> src/lib.rs:161:6 [INFO] [stdout] | [INFO] [stdout] 31 | impl Transitions { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 161 | fn renumber_states(&self, p: &[State]) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `GadgetSpec` is never constructed [INFO] [stdout] --> src/lib.rs:405:8 [INFO] [stdout] | [INFO] [stdout] 405 | struct GadgetSpec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Network` is never constructed [INFO] [stdout] --> src/lib.rs:413:8 [INFO] [stdout] | [INFO] [stdout] 413 | struct Network { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:7 [INFO] [stdout] | [INFO] [stdout] 190 | let mut reverse_state_lookup: HashMap>> = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let mut alive: HashSet = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let mut partition = Partition::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let mut distinguishers_set: HashSet = (0..partition.num_parts()).collect(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let mut transitions: HashMap<(Location, State), HashSet<(Location, State)>> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | / Self { [INFO] [stdout] 344 | | locations: self.locations, [INFO] [stdout] 345 | | states: partition.num_parts(), [INFO] [stdout] 346 | | transitions, [INFO] [stdout] 347 | | accept, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `reverse_location_map`, `neighbors`, `transitions`, and `is_accepting` are never used [INFO] [stdout] --> src/lib.rs:424:6 [INFO] [stdout] | [INFO] [stdout] 422 | impl Network { [INFO] [stdout] | ------------ methods in this implementation [INFO] [stdout] 423 | // network location -> [(gadgetspec index, location)] [INFO] [stdout] 424 | fn reverse_location_map(&self) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 438 | fn neighbors<'a>( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 466 | fn transitions(&self, defs: &[Transitions]) -> Transitions { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 543 | fn is_accepting(&self, defs: &[Transitions], state: &Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:7 [INFO] [stdout] | [INFO] [stdout] 368 | let mut transitions: HashMap<(Location, State), HashSet<(Location, State)>> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | / Self { [INFO] [stdout] 386 | | locations: nloc, [INFO] [stdout] 387 | | states: nstates, [INFO] [stdout] 388 | | transitions, [INFO] [stdout] 389 | | accept, [INFO] [stdout] 390 | | }, [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:7 [INFO] [stdout] | [INFO] [stdout] 84 | fn from_states(x: impl IntoIterator) -> u64 { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | x.into_iter().fold(0, |a, b| a | (1 << b)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 150 | .map(|&x_s| to_states(x_s).any(|s| self.accept[s])) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:168:43 [INFO] [stdout] | [INFO] [stdout] 168 | .map(|(&(l1, s1), v)| ((l1, p[s1]), v.iter().map(|&(l2, s2)| (l2, p[s2])).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:343:7 [INFO] [stdout] | [INFO] [stdout] 190 | let mut reverse_state_lookup: HashMap>> = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let mut alive: HashSet = HashSet::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | let mut partition = Partition::new( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let mut distinguishers_set: HashSet = (0..partition.num_parts()).collect(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | let mut transitions: HashMap<(Location, State), HashSet<(Location, State)>> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | / Self { [INFO] [stdout] 344 | | locations: self.locations, [INFO] [stdout] 345 | | states: partition.num_parts(), [INFO] [stdout] 346 | | transitions, [INFO] [stdout] 347 | | accept, [INFO] [stdout] 348 | | }, [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:385:7 [INFO] [stdout] | [INFO] [stdout] 368 | let mut transitions: HashMap<(Location, State), HashSet<(Location, State)>> = HashMap::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 385 | / Self { [INFO] [stdout] 386 | | locations: nloc, [INFO] [stdout] 387 | | states: nstates, [INFO] [stdout] 388 | | transitions, [INFO] [stdout] 389 | | accept, [INFO] [stdout] 390 | | }, [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gadget-down` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `gadget-down` (lib) due to 6 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8834d4a96f77d2f13558e45093c7b4bb8f46951c757f1c3258e4b3831824f54f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8834d4a96f77d2f13558e45093c7b4bb8f46951c757f1c3258e4b3831824f54f", kill_on_drop: false }` [INFO] [stdout] 8834d4a96f77d2f13558e45093c7b4bb8f46951c757f1c3258e4b3831824f54f