[INFO] cloning repository https://github.com/cppcoffee/kvm-box [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cppcoffee/kvm-box" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcppcoffee%2Fkvm-box", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcppcoffee%2Fkvm-box'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54c5741e5af96ac05cf481c360ca26da757f8b73 [INFO] checking cppcoffee/kvm-box/54c5741e5af96ac05cf481c360ca26da757f8b73 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcppcoffee%2Fkvm-box" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cppcoffee/kvm-box on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cppcoffee/kvm-box [INFO] finished tweaking git repo https://github.com/cppcoffee/kvm-box [INFO] tweaked toml for git repo https://github.com/cppcoffee/kvm-box written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cppcoffee/kvm-box already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a0a85aeb6b524d27b3c5a76ea47f52c7e094f24ede66dd9188c354a5ae10b7f8 [INFO] running `Command { std: "docker" "start" "-a" "a0a85aeb6b524d27b3c5a76ea47f52c7e094f24ede66dd9188c354a5ae10b7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a0a85aeb6b524d27b3c5a76ea47f52c7e094f24ede66dd9188c354a5ae10b7f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a0a85aeb6b524d27b3c5a76ea47f52c7e094f24ede66dd9188c354a5ae10b7f8", kill_on_drop: false }` [INFO] [stdout] a0a85aeb6b524d27b3c5a76ea47f52c7e094f24ede66dd9188c354a5ae10b7f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5b7179d19f2833635fd1c6b67f4ebfd603d1780ca08b6141740b5d98b4d6c1b [INFO] running `Command { std: "docker" "start" "-a" "b5b7179d19f2833635fd1c6b67f4ebfd603d1780ca08b6141740b5d98b4d6c1b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling kvm-ioctls v0.16.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking vm-superio v0.8.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.55 [INFO] [stderr] Checking vmm-sys-util v0.12.1 [INFO] [stderr] Checking kvm-bindings v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking vm-memory v0.14.1 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking linux-loader v0.11.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking argh_shared v0.1.12 [INFO] [stderr] Compiling argh_derive v0.1.12 [INFO] [stderr] Checking argh v0.1.12 [INFO] [stderr] Checking kvm-box v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `input` is never read [INFO] [stdout] --> src/devices/serial.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct SerialWrapper { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | pub input: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SerialWrapper` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/port_io.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(serial: Arc>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | debug_assert!(matches!(*serial.lock().unwrap(), BusDevice::Serial(_))); [INFO] [stdout] 48 | let io_bus = crate::devices::Bus::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let com_evt_1_3 = serial [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let com_evt_2_4 = EventFdTrigger::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let kbd_evt = EventFd::new(EFD_NONBLOCK)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | Ok(PortIODeviceManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | io_bus, [INFO] [stdout] 63 | | stdio_serial: serial, [INFO] [stdout] 64 | | com_evt_1_3, [INFO] [stdout] 65 | | com_evt_2_4, [INFO] [stdout] 66 | | kbd_evt, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vmm.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 20 | let kvm = Kvm::new().context("failed to create kvm")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let vm = kvm.create_vm().context("failed to create vm")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let guest_mem = crate::arch::memory::create_guest_memory(&vm, ram_size)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | Ok(Vmm { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | kvm, [INFO] [stdout] 29 | | vm, [INFO] [stdout] 30 | | guest_mem, [INFO] [stdout] 31 | | vcpu: None, [INFO] [stdout] 32 | | pio_device_manager: None, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvm-box` (bin "kvm-box" test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `input` is never read [INFO] [stdout] --> src/devices/serial.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub struct SerialWrapper { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 54 | pub input: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SerialWrapper` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/devices/port_io.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(serial: Arc>) -> Result { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | debug_assert!(matches!(*serial.lock().unwrap(), BusDevice::Serial(_))); [INFO] [stdout] 48 | let io_bus = crate::devices::Bus::new(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let com_evt_1_3 = serial [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let com_evt_2_4 = EventFdTrigger::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let kbd_evt = EventFd::new(EFD_NONBLOCK)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | Ok(PortIODeviceManager { [INFO] [stdout] | ____________^ [INFO] [stdout] 62 | | io_bus, [INFO] [stdout] 63 | | stdio_serial: serial, [INFO] [stdout] 64 | | com_evt_1_3, [INFO] [stdout] 65 | | com_evt_2_4, [INFO] [stdout] 66 | | kbd_evt, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vmm.rs:27:12 [INFO] [stdout] | [INFO] [stdout] 20 | let kvm = Kvm::new().context("failed to create kvm")?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | let vm = kvm.create_vm().context("failed to create vm")?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | let guest_mem = crate::arch::memory::create_guest_memory(&vm, ram_size)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | Ok(Vmm { [INFO] [stdout] | ____________^ [INFO] [stdout] 28 | | kvm, [INFO] [stdout] 29 | | vm, [INFO] [stdout] 30 | | guest_mem, [INFO] [stdout] 31 | | vcpu: None, [INFO] [stdout] 32 | | pio_device_manager: None, [INFO] [stdout] 33 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvm-box` (bin "kvm-box") due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b5b7179d19f2833635fd1c6b67f4ebfd603d1780ca08b6141740b5d98b4d6c1b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5b7179d19f2833635fd1c6b67f4ebfd603d1780ca08b6141740b5d98b4d6c1b", kill_on_drop: false }` [INFO] [stdout] b5b7179d19f2833635fd1c6b67f4ebfd603d1780ca08b6141740b5d98b4d6c1b