[INFO] cloning repository https://github.com/cortesi/mrpc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/cortesi/mrpc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortesi%2Fmrpc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortesi%2Fmrpc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] af9ff2be2e8691e9874232b8931ffb431a2b78f8 [INFO] checking cortesi/mrpc/af9ff2be2e8691e9874232b8931ffb431a2b78f8 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fcortesi%2Fmrpc" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/cortesi/mrpc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/cortesi/mrpc [INFO] finished tweaking git repo https://github.com/cortesi/mrpc [INFO] tweaked toml for git repo https://github.com/cortesi/mrpc written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/cortesi/mrpc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c08b3f6f1ef195448f0b019b86e517d16c22b13abb3df689f53b24e09a9a8f8 [INFO] running `Command { std: "docker" "start" "-a" "8c08b3f6f1ef195448f0b019b86e517d16c22b13abb3df689f53b24e09a9a8f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c08b3f6f1ef195448f0b019b86e517d16c22b13abb3df689f53b24e09a9a8f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c08b3f6f1ef195448f0b019b86e517d16c22b13abb3df689f53b24e09a9a8f8", kill_on_drop: false }` [INFO] [stdout] 8c08b3f6f1ef195448f0b019b86e517d16c22b13abb3df689f53b24e09a9a8f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 09d5949956ad79244f3d9aa4416f1d727189f19a394358ebf32011b108652ddd [INFO] running `Command { std: "docker" "start" "-a" "09d5949956ad79244f3d9aa4416f1d727189f19a394358ebf32011b108652ddd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking rmpv v1.3.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-test-macro v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing-test v0.2.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking msgpack-rpc v0.4.2 [INFO] [stderr] Checking mrpc v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 88 | connection: RpcConnection, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | service: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | client_sender: mpsc::Sender, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | connection: Arc::new(Mutex::new(connection)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 88 | connection: RpcConnection, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | service: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | client_sender: mpsc::Sender, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | rpc_sender: RpcSender { [INFO] [stdout] | _________________________^ [INFO] [stdout] 96 | | sender: client_sender, [INFO] [stdout] 97 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:343:65 [INFO] [stdout] | [INFO] [stdout] 343 | async fn connected(&self, _client: RpcSender) -> Result<()> { [INFO] [stdout] | _______________________________------------------________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | | Ok(()) [INFO] [stdout] 345 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:355:24 [INFO] [stdout] | [INFO] [stdout] 352 | _client: RpcSender, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 355 | ) -> Result { [INFO] [stdout] | ________________________^ [INFO] [stdout] 356 | | tracing::warn!("Unhandled request: method={}, params={:?}", method, params); [INFO] [stdout] 357 | | Err(RpcError::Protocol(format!( [INFO] [stdout] 358 | | "Method '{}' not implemented", [INFO] [stdout] 359 | | method [INFO] [stdout] 360 | | ))) [INFO] [stdout] 361 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:371:21 [INFO] [stdout] | [INFO] [stdout] 368 | _client: RpcSender, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 371 | ) -> Result<()> { [INFO] [stdout] | _____________________^ [INFO] [stdout] 372 | | tracing::warn!( [INFO] [stdout] 373 | | "Unhandled notification: method={}, params={:?}", [INFO] [stdout] 374 | | method, [INFO] [stdout] ... | [INFO] [stdout] 377 | | Ok(()) [INFO] [stdout] 378 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:427:31 [INFO] [stdout] | [INFO] [stdout] 400 | pub fn new(stream: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | let (read_half, write_half) = tokio::io::split(stream); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let (message_sender, message_receiver) = mpsc::channel(1000); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 427 | pending_requests: std::collections::HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/connection.rs:428:31 [INFO] [stdout] | [INFO] [stdout] 400 | pub fn new(stream: S) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 401 | let (read_half, write_half) = tokio::io::split(stream); [INFO] [stdout] | --------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let (message_sender, message_receiver) = mpsc::channel(1000); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 428 | message_receiver: Some(message_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:113:31 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn from_maker(maker: M) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 113 | connection_maker: Arc::new(maker), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 108 | pub fn from_maker(maker: M) -> Self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | listener: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:124:26 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn from_fn(f: F) -> Self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | Self::from_maker(ConnectionMakerFn::new(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transport.rs:174:23 [INFO] [stdout] | [INFO] [stdout] 169 | let rpc_conn = listener.accept().await?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | let connection = self.connection_maker.make_connection(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | tokio::spawn(async move { [INFO] [stdout] 172 | let (sender, receiver) = mpsc::channel(100); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let mut handler = ConnectionHandler::new(rpc_conn, connection, sender.clone()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | match handler.run(receiver).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mrpc` (lib) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "09d5949956ad79244f3d9aa4416f1d727189f19a394358ebf32011b108652ddd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09d5949956ad79244f3d9aa4416f1d727189f19a394358ebf32011b108652ddd", kill_on_drop: false }` [INFO] [stdout] 09d5949956ad79244f3d9aa4416f1d727189f19a394358ebf32011b108652ddd